Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Apr 2023 16:05:54 +0200
From:   Federico Vaga <federico.vaga@cern.ch>
To:     Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Cc:     Peter Korsgaard <peter@korsgaard.com>,
        Andrew Lunn <andrew@lunn.ch>, Wolfram Sang <wsa@kernel.org>,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux@ew.tq-group.com,
        Gregor Herburger <gregor.herburger@tq-group.com>
Subject: Re: [PATCH v2] i2c: ocores: generate stop condition after timeout in
 polling mode
Message-ID: <t4labnjauvgkwt6ebt7tv4nshlerc7h3ihp7cr2qsxhwvw4xay@3zbagnzuhglj>
References: <20230413093737.15303-1-matthias.schiffer@ew.tq-group.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20230413093737.15303-1-matthias.schiffer@ew.tq-group.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FRX5CmwFs8/pmoiQFocxQH4HZ7DrzY9PKJ3lpocXdjjbmJ4UShclS50WYVgo?=
 =?us-ascii?Q?6Yf6EyzNA65nep15IfniE5t3wAGqgPMropc4Nl8edYLg8z6UKig+s3BJOIna?=
 =?us-ascii?Q?YxMu0BwnM9LL0vpFbdrYs+AgMyhv3JR2yhB/MLCuEm7sc+hK921T7YkJEyVT?=
 =?us-ascii?Q?lOwax+pjcW3TI53bCjDQgc6gBHhEXKIaldXI182pqWeDoKL/DN8XefkiBYtq?=
 =?us-ascii?Q?+eynHLdixRLwkGlLmo9Hb1F6EEEeM1PSMy8UEIu5CO4WZ9fWHV4z1jF0wU0i?=
 =?us-ascii?Q?q4AqfHjZQMIs76efA7Ly1VubSJSBlHgg5XZ9y0TiZbfoAnzfSANtCYSvtJfX?=
 =?us-ascii?Q?/KCf3HAfcIFOsLTVf30IslbBs5NtOPzM/33wIYN/K2pIh3dnyHoHmqbkCkqn?=
 =?us-ascii?Q?kuTQ2Higio/kxYydlbYeGI5GqjYyhPdVTfky+E5ahkFrCp/pFwauaZfhLqZx?=
 =?us-ascii?Q?APqJE4BE5ep+hBonJK2IYEiyxj4H6hfx0limaTEiunpIsVyRIZomgNLcOa/v?=
 =?us-ascii?Q?vP2NxXoRLDnNIcxcZ2BSY04Nb8RCVBvujMb0pdRwToW14W2UHHM9i+CoQDCp?=
 =?us-ascii?Q?Wu0Un/VfYNePiRP9AEvCyJ7tOdqeWEBrelOB7FYPBfel1DWjr3xM8omH/SRT?=
 =?us-ascii?Q?U+H+wVq0C53YOXyxpWLfmljBISqLfjCvtLpWY9pEGxZ79CXwald8pA5Oye+K?=
 =?us-ascii?Q?LtphXBaalbT7g1anbOgjBQGaz36yG3QcyMhBb4GWO5a/iSn3of3/vrS43L8e?=
 =?us-ascii?Q?KvR8UXWIYnoYsWSvM82LN29L6xIc6JUl/LxxAUuCmWfAE6lDw9RFu85IRjBH?=
 =?us-ascii?Q?u/qskO0vIhLXjJKKAi+KH0ShNUixTTVcdtgcEnD5Z2mvyuTMESmz/dWW3WVu?=
 =?us-ascii?Q?5j4wwBSRNhmzKK9DaH3EyKnefjjpIz7+dPt5YQ/+ZwI/HGn/7NIMTIoZfJR6?=
 =?us-ascii?Q?yFeF9WtgfMoLlfawjINIxTEh1Tcbk+Jfdt7kM2cEf44v1K5AwqsUUG0xI9G4?=
 =?us-ascii?Q?rdyhmn5xuFeP/Tn/fUEnzFytvRIxsARLE/Asj32FP9ZNDkhNq5+0poqy3MsH?=
 =?us-ascii?Q?9GgmO/8DInt0wxArijymNT7iFbBLLqU0Ds2DXa7Y3vsRHzqQ4VgkgGR4KcF7?=
 =?us-ascii?Q?IVQRgBOjRgQJ9UrHJl0S10gcadCMPy1AKyz5pAgSg+l31Gk7TC+6JJC1I+rN?=
 =?us-ascii?Q?QNw36QThQbPT46Fdk+8gbnC7BqqXN8oCOHDqx6GsoHFyh4hDzzcrauIN+FcG?=
 =?us-ascii?Q?pdPVQsqfC+Yices8FLYp6fmSvbRCUBySWrCnjYn5kkv7gul8Zx429ET5rWMF?=
 =?us-ascii?Q?lUiaBT8mivCQ/7f4PBnQL3Y3tUn9br0jMjmMLsdQBiuUJx8iZcmvC+oB51Dw?=
 =?us-ascii?Q?Gh5UtjKFUWofKvlJkf/TzXw9ShF/9eXT8w8UHwkQAYK/559h31yzmOJpfcy0?=
 =?us-ascii?Q?f/W12qWgLrUU3T0TIu9vLl5EVKNxXheD4NO+ft9tdvPXCBYc0sIT6novhxj4?=
 =?us-ascii?Q?gkdXWLI0KVlovE4ZotBJjXdOSNF2+GK2Z8yRfb77DboIY1xtOY2OhhcZm3LG?=
 =?us-ascii?Q?lCEyeBfQ+4r+KlznW5iPMdPSHY+lBbI3V1odFqKZNNRRF2SQaNWhd1aeFvY4?=
 =?us-ascii?Q?Ii0IRzQfiPxQEQzTwDm3g6I=3D?=
X-OriginatorOrg: cern.ch
X-MS-Exchange-CrossTenant-Network-Message-Id: c6f2912f-c0a5-481e-2999-08db3c283348
X-MS-Exchange-CrossTenant-AuthSource: ZRAP278MB0062.CHEP278.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 14:05:56.1024
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: c80d3499-4a40-4a8c-986e-abce017d6b19
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tiEroF2Ca6mgt33BWZ/VSbvryXPy5rS6wfDiP72cwYTp4vNneKZa+XxlHw9iPLR/bdmzqEQGhQvDlNqhhaI2sQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: ZRAP278MB0158
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Apr 13, 2023 at 11:37:37AM +0200, Matthias Schiffer wrote:
>From: Gregor Herburger <gregor.herburger@tq-group.com>
>
>In polling mode, no stop condition is generated after a timeout. This
>causes SCL to remain low and thereby block the bus. If this happens
>during a transfer it can cause slaves to misinterpret the subsequent
>transfer and return wrong values.
>
>To solve this, pass the ETIMEDOUT error up from ocores_process_polling()
>instead of setting STATE_ERROR directly. The caller is adjusted to call
>ocores_process_timeout() on error both in polling and in IRQ mode, which
>will set STATE_ERROR and generate a stop condition.
>
>Fixes: 69c8c0c0efa8 ("i2c: ocores: add polling interface")
>Signed-off-by: Gregor Herburger <gregor.herburger@tq-group.com>
>Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
>---
>
>v2: style improvements based on feedback from Federico and Andrew. I went
>    with a slightly different solution than Andrew suggested to avoid using
>    the ret variable for two different kinds of returns.
>
> drivers/i2c/busses/i2c-ocores.c | 35 ++++++++++++++++++---------------
> 1 file changed, 19 insertions(+), 16 deletions(-)

Reviewed-by: Federico Vaga <federico.vaga@cern.ch>

-- 
Federico Vaga - CERN BE-CEM-EDL