Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp2538014rwl; Thu, 13 Apr 2023 07:45:49 -0700 (PDT) X-Google-Smtp-Source: AKy350auffxcZqrh5XfSPpYLJhs3RFDnWvaqiT25oDt9lJWg4+NKtvmMuYLkb4/jIitOkl6I3iFl X-Received: by 2002:a17:902:db04:b0:19a:96ea:3850 with SMTP id m4-20020a170902db0400b0019a96ea3850mr2995234plx.17.1681397149339; Thu, 13 Apr 2023 07:45:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681397149; cv=none; d=google.com; s=arc-20160816; b=tIPHB02mk0i8nEpFtZz+niH4rIRLEcWsCjnU0oltohx4RqDlKUoTP6YqwzmHZcAPSO fGylZ6qToloJLef+HCbPlVOAoc+xPlcEnfw/DGdTyVUGunHmiOS+StK4afII04BDB6oK 0t3/lrP4uSX3pk913K6tfyXK4v3YPY6/mxeXn7u8zzBumAYtplSDm3Q2j/ZLUQzvklEy DoLd986cSPmT/XGUZ0UFggSNljX1D0RTmbkmAq9StAT6nqey00XtHBf0pVkR/7EESjph nbi/5j4O+sU+xoa2s8x2ZvumMeO8oAo6R2ki8jAW6yFbruHL3zd0rTWPFOu7trsfwfOc RDtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=J5w0b8Fobg2W9RujUD13uGJH7vRMN8dHc0B4sOAwikM=; b=ZZu2be3gaqU7DscAYAYsiqDpv4Mc6oZ72xFNAfvYlwudncL+dBrAI/7IXCUel+8mFn 7C0RtVByYY4QJnAvmGNaIMXkKPfVdGBV2z2T4u/3vr0ohfgnzQGlrIIvCUYz8u6V7h6r ZK1MAi9xuIpszFc8gKNL3GrCfOBR57qfdhE8JV3vjmu5jwjtfaKXGXlFnCbyJxdhakdO MftYJp7oI+dw8ipnHUEgsyTs+IV25YJm/J0ogSIrxFgLxzUqrOyXo8/+SWM9JAxn76cD o5QikUpO146/ZvFJQP1CXDLfvNVLYwTc3hH5MIO/GP0SlhJo5o1LU5oNMfwA8TC4kPd1 2eXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=5TjbN28t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l10-20020a170903120a00b0019ca3bea326si2372277plh.269.2023.04.13.07.45.37; Thu, 13 Apr 2023 07:45:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=5TjbN28t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229888AbjDMOn7 (ORCPT + 99 others); Thu, 13 Apr 2023 10:43:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229784AbjDMOnu (ORCPT ); Thu, 13 Apr 2023 10:43:50 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4DBFB76E; Thu, 13 Apr 2023 07:43:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=J5w0b8Fobg2W9RujUD13uGJH7vRMN8dHc0B4sOAwikM=; b=5TjbN28trjt5HISvTlm95p0A9G D9M1FUwIBttbFB3gbsuaO9mbk3vXv4+yRqyZZ19apAILewifcs3qVozNt1PG9U/NozW0WFJ5NF4Mn 26Hx/eLWptWB7cbOupRNhwJelVtjvJ+RY33Xa4ZQEc6x6adDxZx3Gjac/K9aKr2J/KXA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1pmyAb-00ACJL-AV; Thu, 13 Apr 2023 16:43:29 +0200 Date: Thu, 13 Apr 2023 16:43:29 +0200 From: Andrew Lunn To: Florian Fainelli Cc: Christian Marangi , Pavel Machek , Lee Jones , Rob Herring , Krzysztof Kozlowski , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Heiner Kallweit , Russell King , Gregory Clement , Sebastian Hesselbarth , Andy Gross , Bjorn Andersson , Konrad Dybcio , John Crispin , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [net-next PATCH v6 06/16] net: phy: phy_device: Call into the PHY driver to set LED brightness Message-ID: <60d5bad7-e7c1-4ffe-be6c-5d92e482b1ba@lunn.ch> References: <20230327141031.11904-1-ansuelsmth@gmail.com> <20230327141031.11904-7-ansuelsmth@gmail.com> <202ae4b9-8995-474a-1282-876078e15e47@gmail.com> <64380b46.7b0a0220.978a.1eb4@mx.google.com> <7ea465d9-95eb-d158-632a-a2aa892fd2bf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7ea465d9-95eb-d158-632a-a2aa892fd2bf@gmail.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Humm just thought of something else, is it OK for led_brightness_set and > led_blink_set to call into functions that might require sleeping (MDIO, I2C, > SPI, etc.)? Hi Florian That is fine. The LED class is similar to GPIOs. There is a can sleep version, and an atomic version. For phylib we are using the can sleep version. The LED core then hides the differences from the users. Andrew