Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp2538662rwl; Thu, 13 Apr 2023 07:46:19 -0700 (PDT) X-Google-Smtp-Source: AKy350YGFec79yKcvexweQ3PSi7hEJPSTX/o4ygVPfZ9fqgsiA3GWaTYeRHWNvkyQVkXiG/7ZdxA X-Received: by 2002:a17:903:22d0:b0:19e:b2ed:6fff with SMTP id y16-20020a17090322d000b0019eb2ed6fffmr2477116plg.31.1681397178844; Thu, 13 Apr 2023 07:46:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681397178; cv=none; d=google.com; s=arc-20160816; b=H3Vu7MJg47RpEcofP39NsvhIoIGZNWUHsaj6lUgw0T0fZ6hcBqJ5GA7r+2CpbkUHfm 0vC2Tfj2P86HB7fKa968t8QAmDqScK9xWKFk+YQmtswIeH0BBiJyAhqp4G6UXkSo38AA tK0DbmCkXZxzE0CgAY/SiMRE5ZciVaEMEBuh0ctx4hunV1yQtWNirj1ys09clwrBD4iE dB5hAZ0O88Wn9dSzi6OwQc++Kf41mnz6cd0is6fwpL79NocuS0pIh7Gg2KQ2j+hRpY8P AeQynitpmwkL7DKGyUGqmX0ZVFqkEfLmGowLby7PmazvxdOHTwExSzD24ALih3t8ooUt P/FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id; bh=AF1/7Fot4ImvNBwPUihbeB7WPmjeKOBZiU0yvmWD+1k=; b=DLfogxg7p3b+Q7XTiGt7xF7iuoAi/Xw0fcQWsSYSX4UJoGtwhOp02v0O1FZO7daTog JKnfz3Qur51Ua+ca6rUvrFkhEId8KAHZ13mC7TwY4uRKZg4qst2B4gEMpJSZgssMD0V6 /l0nOWEJsYXeJj3/qAQeyNcd8WVdC35xhHFTmOlosfjtQWmJUsjkLoMf/J36XIL5ARhz RUxJd3Jkwga0GDUxRA3knIqY7MpUs+B7HrTvLUfwrNTqjjIVh96XqtPEv/KCnLsWMmhV rOHhpDVGt9uR/i+LonCKmLDOcpnxHRcyI/F5TSdDU8LB+hniv2M+tzni+EtkHeGE9/AQ ylLw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 123-20020a630481000000b0051b54dcd000si1291094pge.779.2023.04.13.07.46.06; Thu, 13 Apr 2023 07:46:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230130AbjDMOqA convert rfc822-to-8bit (ORCPT + 99 others); Thu, 13 Apr 2023 10:46:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229611AbjDMOp5 (ORCPT ); Thu, 13 Apr 2023 10:45:57 -0400 X-Greylist: delayed 494 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 13 Apr 2023 07:45:32 PDT Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5083EA5EC; Thu, 13 Apr 2023 07:45:31 -0700 (PDT) Received: from r6.localdomain (82-217-174-174.cable.dynamic.v4.ziggo.nl [82.217.174.174]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 7C8A2302BB02; Thu, 13 Apr 2023 16:37:14 +0200 (CEST) Received: by r6.localdomain (Postfix, from userid 1000) id 2A6AB34014C; Thu, 13 Apr 2023 16:37:14 +0200 (CEST) Message-ID: <718c102205750a00b86e8d33748e9bfb3c485ee1.camel@klomp.org> Subject: Re: [PATCH v5 1/2] check-uapi: Introduce check-uapi.sh From: Mark Wielaard To: John Moon , Greg Kroah-Hartman Cc: Masahiro Yamada , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Randy Dunlap , Arnd Bergmann , Bjorn Andersson , Todd Kjos , Matthias Maennich , Giuliano Procida , kernel-team@android.com, libabigail@sourceware.org, Jordan Crouse , Trilok Soni , Satya Durga Srinivasu Prabhala , Elliot Berman , Guru Das Srinagesh Date: Thu, 13 Apr 2023 16:37:14 +0200 In-Reply-To: References: <20230407203456.27141-1-quic_johmoo@quicinc.com> <20230407203456.27141-2-quic_johmoo@quicinc.com> <2023041015-lunar-dandelion-1b4e@gregkh> <2023041136-donator-faceplate-5f91@gregkh> <2023041209-armed-overlaid-3d3d@gregkh> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, 2023-04-12 at 09:37 -0700, John Moon via Libabigail wrote: > On 4/11/2023 11:14 PM, Greg Kroah-Hartman wrote: > > > Would you find the tool more useful if it simply filtered out all instances > > > where the size of the type did not change? This would filter out the > > > following which the tool currently flags: > > > > > > - enum expansions > > > - reserved field expansions > > > - expansions of a struct with a flex array at the end > > > - type changes > > > - re-ordering of existing members > > > - ...others? > > > > Obviously not, as some of those are real breakages, and some are not at > > all. > > > > Please understand what is an abi breakage. Adding new enums is not. > > Using a reserved field is not. Reording existing members IS. > > > > Yes, understood that method would miss certain classes of breakages. I > was suggesting it as a way to improve the signal-to-noise ratio of the > tool since we don't currently have an algorithm for determining > breakages with 100% accuracy. Note that you can check the exit code of libabigail's abidiff to see whether something is an incompatible abi change or not, see: https://sourceware.org/libabigail/manual/abidiff.html#return-values You can also of course use suppressions to instruct abidiff to avoid reporting changes involving certain ABI artifacts: https://sourceware.org/libabigail/manual/libabigail-concepts.html#suppr-spec-label Cheers, Mark