Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Apr 2023 08:03:21 -0700
From:   Josh Poimboeuf <jpoimboe@kernel.org>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     x86@kernel.org, linux-kernel@vger.kernel.org,
        Miroslav Benes <mbenes@suse.cz>
Subject: Re: [PATCH v2 3/9] objtool: Limit unreachable warnings to once per
 function
Message-ID: <20230413150321.6hd4m3vlnonom3qo@treble>
References: <cover.1681325924.git.jpoimboe@kernel.org>
 <81ed0b8e5218ac6ecae49af901bf5e0fb3687cef.1681325924.git.jpoimboe@kernel.org>
 <20230413080112.GF4253@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230413080112.GF4253@hirez.programming.kicks-ass.net>
Precedence: bulk

On Thu, Apr 13, 2023 at 10:01:12AM +0200, Peter Zijlstra wrote:
> On Wed, Apr 12, 2023 at 12:03:18PM -0700, Josh Poimboeuf wrote:
> 
> > diff --git a/tools/objtool/include/objtool/warn.h b/tools/objtool/include/objtool/warn.h
> > index b1c920dc9516..4ef9b278e5fd 100644
> > --- a/tools/objtool/include/objtool/warn.h
> > +++ b/tools/objtool/include/objtool/warn.h
> > @@ -55,7 +55,10 @@ static inline char *offstr(struct section *sec, unsigned long offset)
> >  
> >  #define WARN_INSN(insn, format, ...)					\
> >  ({									\
> > -	WARN_FUNC(format, insn->sec, insn->offset,  ##__VA_ARGS__);	\
> > +	if (!insn->sym || !insn->sym->warned)				\
> > +		WARN_FUNC(format, insn->sec, insn->offset, ##__VA_ARGS__);\
> > +	if (insn->sym)							\
> > +		insn->sym->warned = 1;					\
> >  })
> 
> Do we want to write that like:
> 
> #define WARN_INSN(insn, format, ...)					\
> ({									\
> 	struct instruction *_insn = (insn);				\
> 	if (!_insn->sym || !_insn->sym->warned)				\
> 		WARN_FUNC(format, _insn->sec, _insn->offset, ##__VA_ARGS__);\
> 	if (_insn->sym)							\
> 		_insn->sym->warned = 1;					\
> })
> 
> instead ?

Yes indeed.

-- 
Josh