Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp2574598rwl; Thu, 13 Apr 2023 08:10:59 -0700 (PDT) X-Google-Smtp-Source: AKy350Z9Hc9NCJo86BvRWu0bbqz2rwtv7Jj0M63EAfBt6Ws7OYk+qLuhABKeABIllwLNrtnf1+hi X-Received: by 2002:a67:e98e:0:b0:42c:9d63:47ea with SMTP id b14-20020a67e98e000000b0042c9d6347eamr944145vso.0.1681398658848; Thu, 13 Apr 2023 08:10:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681398658; cv=none; d=google.com; s=arc-20160816; b=bmBCTBr77Xn3mJ6EKbAwKrvgBYJXYBQblbK/+lC5Mn4KMebUo7zvxonlVjFQ26vqhv qCFtRzhnRtFPuKioIHz+m1dIyFXToy8NJWZAs2pgTE0fdZaTBNha9XKXt0jH8lKURurW 2PB0Ttx2zCgDa0+wOuVkilnElhXCL7okaoDMbt+cvfPFp8nJvaECoi2HhlrU/GDwdswd 53A/B1K0WoE6P4r2DMEAXYXhbnk/Kv9g8p37KTubienrQiIP98jfBI38aOh4g5ePXRwU EYNMRmUhGWPOGmb6HOZ3XWSY48LHOTjxbw2LwH6WcORw6KTcbRWpx3x1aZxWizbQCICv PNVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=NiP9x7ZNnv9oF3tF2N1MoGrkI3/dX+xEdtAjPLF+c9M=; b=zil1Y74lzIU0Wc3VhrAlwcd9F95VB42MtLvE/aiFLcIgSDx75I0lP9Rlg7m79lp454 qJSF/wf/VmSNvIXEs1xFuRz6WPZh/ZkPx9sTeJuH7cKMjgTVgUQMbq3MB1eaZ/pybjPu lJmyc3rnoAXX/gUOUECaevO3BpAI0U3epI0EHkACGcyLn58eS7D7Oke9Qmeoiyk/sA33 A8P/H3uJqdTvFM6O3m+ES7TNOLfiykFUTCrCXKxc++pT5UIdqoMHxu/3k7yitvxn8uAL Ffryjn06x1L0rV9iHhfzv7oHNzyZVSc3fJ54uRexTTa6ghXAjuoVYwxj/YhrK4ZgDqdA I9nw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="YPGDH/bb"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g24-20020ab02458000000b0077208618ed7si382260uan.103.2023.04.13.08.10.43; Thu, 13 Apr 2023 08:10:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="YPGDH/bb"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230483AbjDMPEK (ORCPT + 99 others); Thu, 13 Apr 2023 11:04:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229660AbjDMPEJ (ORCPT ); Thu, 13 Apr 2023 11:04:09 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5631783E2; Thu, 13 Apr 2023 08:04:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E73A263BBE; Thu, 13 Apr 2023 15:04:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC5A7C433EF; Thu, 13 Apr 2023 15:04:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681398247; bh=JdbgbeQTK4oXXpvwy/OkbrBX79V7CMl8I2rByssnbK8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YPGDH/bbVb36/Vi0t11lP6f2sRR4SOLUf7fIxJRUtI28miO5mrqAWIL/3j1+kYij5 Znu5MBMUAZ+ABRUL93fKTMB8SrOPqtCDWAWceK9xh6JuqFmfUN0jdOLKeXXtxaZjlk Mji3Ymgy4JBemOYnGu9wR+RTKyZ/BPk926GVY3BLbrJozJPXSyT4kwpnvRSM1BGqMQ lDdzkfb6wkR/K9+ZE7ddssGuJ4sacrzsSzrfTlCIV7dOuOB08yFa6iiLh6ZIpQyFy4 pQXosljbJNj3i7pKtYMvmQu2Iu5JzdM+4DG/oqhlS/RRYM3agdlvngB1MvkVuACpU7 GLBtV7XMPP1Sw== Date: Thu, 13 Apr 2023 08:04:05 -0700 From: Jakub Kicinski To: "Kubalewski, Arkadiusz" Cc: "jiri@resnulli.us" , "davem@davemloft.net" , "edumazet@google.com" , "pabeni@redhat.com" , "corbet@lwn.net" , "Brandeburg, Jesse" , "Nguyen, Anthony L" , "richardcochran@gmail.com" , "netdev@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" Subject: Re: [RFC PATCH v1] ice: add CGU info to devlink info callback Message-ID: <20230413080405.30bbe3bd@kernel.org> In-Reply-To: References: <20230412133811.2518336-1-arkadiusz.kubalewski@intel.com> <20230412203500.36fb7c36@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 13 Apr 2023 13:43:52 +0000 Kubalewski, Arkadiusz wrote: > >Is it flashed together with the rest of the FW components of the NIC? > >Or the update method is different? > > Right now there is no mechanics for CGU firmware update at all, this is why I > mention that this is for now mostly for debugging purposes. > There are already some works ongoing to have CGU FW update possible, first with > Intel's nvmupdate packages and tools. But, for Linux we probably also gonna > need to support update through devlink, at least this seems right thing to do, > as there is already possibility to update NIC firmware with devlink. Only FW versions which are updated with a single flashing operation / are part of a single FW image should be reported under the device instance. If the flash is separate you need to create a separate devlink (sub)instance or something along those lines. Differently put - the components in the API are components of the FW image, not components of a board. We had a similar discussion about "line cards" before.