Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Apr 2023 08:05:16 -0700
From:   Josh Poimboeuf <jpoimboe@kernel.org>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     x86@kernel.org, linux-kernel@vger.kernel.org,
        Miroslav Benes <mbenes@suse.cz>
Subject: Re: [PATCH v2 5/9] objtool: Add verbose option for disassembling
 affected functions
Message-ID: <20230413150516.obilsce2akxihri6@treble>
References: <cover.1681325924.git.jpoimboe@kernel.org>
 <4cadacc719db1e792c335309056960ca6f71139e.1681325924.git.jpoimboe@kernel.org>
 <20230413080527.GG4253@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230413080527.GG4253@hirez.programming.kicks-ass.net>
Precedence: bulk

On Thu, Apr 13, 2023 at 10:05:27AM +0200, Peter Zijlstra wrote:
> > @@ -118,6 +119,10 @@ int cmd_parse_options(int argc, const char **argv, const char * const usage[])
> >  		parse_options(envc, envv, check_options, env_usage, 0);
> >  	}
> >  
> > +	env = getenv("OBJTOOL_VERBOSE");
> > +	if (env && !strcmp(env, "1"))
> > +		opts.verbose = true;
> > +
> >  	argc = parse_options(argc, argv, check_options, usage, 0);
> >  	if (argc != 1)
> >  		usage_with_options(usage, check_options);
> 
> No real objection; but I do feel obliged to point out that:
> OBJTOOL_ARGS="-v" achieves much the same.

But OBJTOOL_VERBOSE=1 just rolls off the fingers :-)

-- 
Josh