Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Apr 2023 18:33:39 +0200
From:   Wolfram Sang <wsa@kernel.org>
To:     Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Cc:     Peter Korsgaard <peter@korsgaard.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Federico Vaga <federico.vaga@cern.ch>,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux@ew.tq-group.com,
        Gregor Herburger <gregor.herburger@tq-group.com>
Subject: Re: [PATCH v2] i2c: ocores: generate stop condition after timeout in
 polling mode
Message-ID: <ZDgu45b/tN4On+8o@sai>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
        Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
        Peter Korsgaard <peter@korsgaard.com>, Andrew Lunn <andrew@lunn.ch>,
        Federico Vaga <federico.vaga@cern.ch>, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux@ew.tq-group.com,
        Gregor Herburger <gregor.herburger@tq-group.com>
References: <20230413093737.15303-1-matthias.schiffer@ew.tq-group.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="y5zp1yi9Gcj7gXLr"
Content-Disposition: inline
In-Reply-To: <20230413093737.15303-1-matthias.schiffer@ew.tq-group.com>
Precedence: bulk


--y5zp1yi9Gcj7gXLr
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 13, 2023 at 11:37:37AM +0200, Matthias Schiffer wrote:
> From: Gregor Herburger <gregor.herburger@tq-group.com>
>=20
> In polling mode, no stop condition is generated after a timeout. This
> causes SCL to remain low and thereby block the bus. If this happens
> during a transfer it can cause slaves to misinterpret the subsequent
> transfer and return wrong values.
>=20
> To solve this, pass the ETIMEDOUT error up from ocores_process_polling()
> instead of setting STATE_ERROR directly. The caller is adjusted to call
> ocores_process_timeout() on error both in polling and in IRQ mode, which
> will set STATE_ERROR and generate a stop condition.
>=20
> Fixes: 69c8c0c0efa8 ("i2c: ocores: add polling interface")
> Signed-off-by: Gregor Herburger <gregor.herburger@tq-group.com>
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>

Applied to for-current, thanks everyone!


--y5zp1yi9Gcj7gXLr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmQ4LuMACgkQFA3kzBSg
KbZMpA/5AdpLkRX/rjzS6kMU4oLlfJr7u0f9cI/LyMXSxS2BoRNr7raFFVybmVp1
onlRFYfpwRrx8QIFXY7nIPBytQHdEhK5Ns72Psbb82XBr9gNxw+BuxIwt+X6kCfS
sArTlXBhQpgiTHqb6M7/ORIDBYfCevxUYQ2GmhhUTX32gnQIqmwqk97CmgXTFvc0
1au5vglKU46tPk7tpzQzixoU9LJDvzUeny9QsEWweP3UyDNIzTRqXt4+rNlD5clg
GS4VaylPP1sX2XK53F3CkYGAg+8aJxgclll/xxLZfRVV8ZsW61yHyhjB+Bueo4f+
1CL70KWzc41VZv3DcBELAlQf/XPK1H5i3Wh2gyNzr7YR9mvkgFNNzk7e0+CM9GvM
pb0X+lLbPHlSzj6nDj5B6nKkvKYaeWb8uUy2atoNtcDE+4MyD3bWWag5Rv1HtV3k
bAOrWxbFfijmqh1U5XzQXAmcFKzRxbSDfAfdHK58hNBMGK7dRHuLnltFPeWeEZa0
usYCQd3TKaa8/X8vcOSBS3Y899WPB0/Cilgw5etjKyEF/casJewQofiIxdnnnprQ
+h8D009dpaAuFUyXqvDzSSFwMX7bvqz6Gf5V1rwUxwyrNUXgGpUEl76t1+N1GPSh
WrkuKO7BHpkidDy1xVIuJpjUjqt/VNLCbOtco4kA4FPT+QVK/Kw=
=nqC2
-----END PGP SIGNATURE-----

--y5zp1yi9Gcj7gXLr--