Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp2709412rwl; Thu, 13 Apr 2023 09:48:21 -0700 (PDT) X-Google-Smtp-Source: AKy350YKhKj/00dc93hj7HMh86oQhAvwue5+wYvKWFyfDbcONEyGe0boVtimlxamCzkRhMSQlNsu X-Received: by 2002:a17:90a:e507:b0:247:e4c:d168 with SMTP id t7-20020a17090ae50700b002470e4cd168mr2611494pjy.10.1681404500769; Thu, 13 Apr 2023 09:48:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681404500; cv=none; d=google.com; s=arc-20160816; b=snW035bzyh4BA/ZwPjRobLlHaBlwICv94wVRtsfd+0nQvleffgRZctO/s0a7nmjhil pQg1YU8SqcKmSePzMiNAOuG8sKtAZ4Oqf19GKTAFL99gyeYmHoi33u5iIaTtQHhYi9bB f6yErNaizJbUUl5jcbjpUho2HCmygDhSHNX4o+EVAhX4lKemQp7Kv+DgWC2jjmoCjfTY lQv/uEwKWsuNosXnfR5isQ+pTcGff+lTe4kKArClD9eUe/NW7lQk44iGVXjXp4kC/w/5 mahi5f8hj2zQ3G1Lok29cP0xIyrlZ7xDVzjn6UCt1kg0BxXDOd2D5uwH790gtI87R3FX 4ZKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=n3HJeXO8XonVy0iNvBcT/ZlqPcy86GAK3hXk8LXGvw8=; b=J4h6L1Acdt8a1s1Mk1iUHj+V7AUM5TpUeCs+25nJpV2ahfhJj9jXHoL73z7X4KthZu 5lMejixzca7esDhd+hnCUZTPAEoqu05oGKuO003QEL24Gooky8AmsSnsjwwyOmfuqum9 PW2MH8pn0rh1ZYNVhZT6FqTx+jL58gZO3Ok/wF088LUBnGXWoq8a/UpqJztslOyiG3pC ZYfkbPlFyoLZ38Emc7cJSGxKuWZxYcU712uMRdlvgHhbnYQCBbVJ9drpB7sIlDCKoRRd +Hw7h24ak/PX1epg448tWy/qWQl4rZpWF48EmDs1Z9IbU64g91s0CeV/mBgDGNLMZ3y5 +YSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mV172mFx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o4-20020a17090ac70400b00246c09bc402si5069939pjt.117.2023.04.13.09.48.06; Thu, 13 Apr 2023 09:48:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mV172mFx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229746AbjDMQkJ (ORCPT + 99 others); Thu, 13 Apr 2023 12:40:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229913AbjDMQkH (ORCPT ); Thu, 13 Apr 2023 12:40:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D876B8A6A; Thu, 13 Apr 2023 09:40:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6777663FDC; Thu, 13 Apr 2023 16:40:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3CEFC433D2; Thu, 13 Apr 2023 16:40:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681404005; bh=izUZnBlpqKhrOemjMQlQ/aNyVeCCaykBq9pZH8LYzrE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mV172mFxB6ZMZj/kTDxvU7GqmLSM12EClHuQSW9+FuPWrJS/8sOoVp1TRoMGOQhzg tgrAzRwK0kn1rShHFmuT2uOliRUnt//OiRyUzH7CTqpqpwNnzYT1ShurwRaspSx5sq rErIjVUEdJKqX43Eszo93ZV3/wxPW9KTZDXD7F7Xio39CkEKpzg6LtqNbuYxsZzXNw D9rc9DtIFZFtftUAYjjsxwG5JwpiLFYXLN4hTj85yeshtmq6gWbfCwb0ICNytfaww4 s1W6K9wEhE1BF97kaZZVIuH1svXoX0QMuwzArhkqJ5PKzrKY9tQ+NeTifiSm0uxT9f 3gMT0Nfl+4zlw== Date: Thu, 13 Apr 2023 09:40:03 -0700 From: Jakub Kicinski To: Leon Romanovsky Cc: Haiyang Zhang , "linux-hyperv@vger.kernel.org" , "netdev@vger.kernel.org" , Dexuan Cui , KY Srinivasan , Paul Rosswurm , "olaf@aepfle.de" , "vkuznets@redhat.com" , "davem@davemloft.net" , "wei.liu@kernel.org" , "edumazet@google.com" , "pabeni@redhat.com" , Long Li , "ssengar@linux.microsoft.com" , "linux-rdma@vger.kernel.org" , "daniel@iogearbox.net" , "john.fastabend@gmail.com" , "bpf@vger.kernel.org" , "ast@kernel.org" , Ajay Sharma , "hawk@kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V3,net-next, 2/4] net: mana: Refactor RX buffer allocation code to prepare for various MTU Message-ID: <20230413094003.3fa4cd8c@kernel.org> In-Reply-To: <20230413163059.GS17993@unreal> References: <1681334163-31084-1-git-send-email-haiyangz@microsoft.com> <1681334163-31084-3-git-send-email-haiyangz@microsoft.com> <20230413130428.GO17993@unreal> <20230413163059.GS17993@unreal> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 13 Apr 2023 19:30:59 +0300 Leon Romanovsky wrote: > > So the page pool is optimized for the XDP, and that sentence is applicable to drivers > > that have set up page pool for XDP optimization. > > "but it can fallback on the regular page allocator APIs." The XDP thing is historic AFAIU, page_pool has been expanded to cover all uses cases, and is "just better" (tm) than using page allocator directly. Maybe we should update the doc.