Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp2729443rwl; Thu, 13 Apr 2023 10:03:50 -0700 (PDT) X-Google-Smtp-Source: AKy350b5PjB2M4bsbmLdQlJXoS60F0pKmQGOlEwT/uEyZJNpCp8ZOUkxix+YmYdIU4dIRkutXuyM X-Received: by 2002:a17:903:185:b0:19d:20a:a219 with SMTP id z5-20020a170903018500b0019d020aa219mr3278297plg.66.1681405430503; Thu, 13 Apr 2023 10:03:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681405430; cv=none; d=google.com; s=arc-20160816; b=ZrCa0QY65UdGQayoCmAX+fazGItfvZlz0g2W1w4hiti4YMjeOa2cs7fOTQuNXiPKSH 3BUrHsJPJg5BG8LqJmnDGjm6NLai44J4YL+ovks4HZlxQvXQbkKgi9I+q9ayAyGLocbW wyOaq2ny40lAJPpXxGB8XiIuTalTxsZ/bhncgOS147HoDAyDoPbEI8bDc0vtVx4CkVUS hWYOR0HbF52zWUpfovaeFr4dSN/D8VpW8UaD+YOaymbviJhYNJolDBbxO8R29Vk4mFs8 QecNlgjDFNG3Px+k4MAF3aao+sBbSqg0HILOAplaHBZSIpYFxczoxd2lblViY3ZOya6V WRFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=nXQMr0aIYX9SK/VZxI8RxfNvoz4nTnu4eloZRKv9yWI=; b=gpGfeudUUuZHsQ6q82IwU7tAINGI8l2gSbuKrFDu663M/e6qOsUPuiFw3F652UrpEH 5wVM688UA1cOtCGPfceQ2HLA9tvB+CjYgPDWGCkMslGqeLbRAwxqZC8GV2mOY4LyY6EL pEVvqN6jwV7lv8VCr1QIW8/h1K2wNshaCzONHaH7nfd+y46OlDUfKM1PX/QMVPp8Ubfr CT7PGyHVf+YXBaxrR6VQ5SFr7Q+4cVokuoPbMQhdE0sJmMWGyWcqjj0a9Bo5E9pDH91r Kzh4/ddVEV66fPqIF+aAAamDDV9eClCbUvOhs7Zjkw4jjqDD3xGVRJVKNezLgG3vUC1K XyHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KqbhC+LE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i30-20020a63585e000000b0050bea56f69asi2534911pgm.735.2023.04.13.10.03.30; Thu, 13 Apr 2023 10:03:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KqbhC+LE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230044AbjDMQ7i (ORCPT + 99 others); Thu, 13 Apr 2023 12:59:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229604AbjDMQ7f (ORCPT ); Thu, 13 Apr 2023 12:59:35 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0DDD59F9; Thu, 13 Apr 2023 09:59:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 69BC864035; Thu, 13 Apr 2023 16:59:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4F3DC433D2; Thu, 13 Apr 2023 16:59:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681405173; bh=bSkSu7wJY6E12OzsXzraNJfB/SMGar8eC+xZrs3OlPI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KqbhC+LEKt2Ua+orMMdfXcL18ruziKNhKLS3lM8nbujW159cmI7wEgKp2Ca04iFDX 1ZVKuI616uAVTOPTl1lgZxNvbuZ8l9x07alJP4D/tPdb9glEFip1eV/MzNiLNHBVJa IkFJeukK81mc4BdKwm0BvE550kHSFAcpbUgGHJlJNsdN6LdbbTxxIdq6yp3FAE4Ws3 Mb04+184eVcJU3PWtr+nqlDhBvVmwoKLSDLAn1HHAcelheRJGjzraSCO+xFbXDMVzz FLQKbMn6KToVDBDUDEkiXkGJUl3MxZMiqTuJmY8U3AHkUlpHmpbc2jvODu8lsiFkG3 MkKqkkoRSSYag== Date: Thu, 13 Apr 2023 19:59:29 +0300 From: Leon Romanovsky To: Jakub Kicinski Cc: Haiyang Zhang , "linux-hyperv@vger.kernel.org" , "netdev@vger.kernel.org" , Dexuan Cui , KY Srinivasan , Paul Rosswurm , "olaf@aepfle.de" , "vkuznets@redhat.com" , "davem@davemloft.net" , "wei.liu@kernel.org" , "edumazet@google.com" , "pabeni@redhat.com" , Long Li , "ssengar@linux.microsoft.com" , "linux-rdma@vger.kernel.org" , "daniel@iogearbox.net" , "john.fastabend@gmail.com" , "bpf@vger.kernel.org" , "ast@kernel.org" , Ajay Sharma , "hawk@kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V3,net-next, 2/4] net: mana: Refactor RX buffer allocation code to prepare for various MTU Message-ID: <20230413165929.GU17993@unreal> References: <1681334163-31084-1-git-send-email-haiyangz@microsoft.com> <1681334163-31084-3-git-send-email-haiyangz@microsoft.com> <20230413130428.GO17993@unreal> <20230413163059.GS17993@unreal> <20230413094003.3fa4cd8c@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230413094003.3fa4cd8c@kernel.org> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 13, 2023 at 09:40:03AM -0700, Jakub Kicinski wrote: > On Thu, 13 Apr 2023 19:30:59 +0300 Leon Romanovsky wrote: > > > So the page pool is optimized for the XDP, and that sentence is applicable to drivers > > > that have set up page pool for XDP optimization. > > > > "but it can fallback on the regular page allocator APIs." > > The XDP thing is historic AFAIU, page_pool has been expanded to cover > all uses cases, and is "just better" (tm) than using page allocator > directly. Maybe we should update the doc. The last sentence is always true :)