Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <01ef9d4f-d2dc-d584-4733-798cffda49a1@intel.com>
Date:   Thu, 13 Apr 2023 10:07:37 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH net-next v4] net: stmmac:fix system hang when setting up
 tag_8021q VLAN for DSA ports
Content-Language: en-US
To:     Yan Wang <rk.code@outlook.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <pabeni@redhat.com>, <kuba@kernel.org>,
        <mcoquelin.stm32@gmail.com>
CC:     Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        "open list:STMMAC ETHERNET DRIVER" <netdev@vger.kernel.org>,
        "moderated list:ARM/STM32 ARCHITECTURE" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        "moderated list:ARM/STM32 ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>
References: <KL1PR01MB5448C7BF5A7AAC1CBCD5C36AE6989@KL1PR01MB5448.apcprd01.prod.exchangelabs.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <KL1PR01MB5448C7BF5A7AAC1CBCD5C36AE6989@KL1PR01MB5448.apcprd01.prod.exchangelabs.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TlV4OUVnd0p1VDhYWnJ3R0dmZDVkOWZpOFVscXg2a3dYVHdXZGFMcVBQU3N0?=
 =?utf-8?B?aEg1eXc2d3Zib2ZOQllEdFUvWFVUMzF2bmloeTF0YmE2SzJEZitYdWhlNjRE?=
 =?utf-8?B?V3dwaTZvQnlEMnRmMjlGLzFxRXdOdUUrMVlWc3pUcEQ5c2kvOWRtRVZBN2h6?=
 =?utf-8?B?RDAySzVnQ2l4bkNkdXFuaERhZDg1dkd6RDhQTE9zMnFmVEs2cUQ5MFhmRUli?=
 =?utf-8?B?Z0xOb01qQmo3Wkp6WTdGZXYyRVdveXI0LzJxU1FVY2U2OHJTdS9FNWhWS0VC?=
 =?utf-8?B?WUpaaC9FMUZRMkNyZ2x2U0xQSW1hSFhoajdMTGRZaUtKVlRDNzVPOVJlSnpt?=
 =?utf-8?B?N2ltUlJDbG04OS9NQWxuOWp5dGJ4c0gvWWZpK2JhQmg5bmt6Q0ZHWi9Ha0Nu?=
 =?utf-8?B?OXhKMWJISXVrQzBLYnlqMXJOWFZmZUZCVisvYU1yalFoSnQrK0J4bEhldTY5?=
 =?utf-8?B?NUZTSGQxamp0UjhtRnFCaU5yOVAwL0JSd0F3dmdIdVkwS1hlcGl4UjlpMEhP?=
 =?utf-8?B?eFBGZ2RZL0ZiWDU2S3EyREhlbW1nVWtCRWNjTjBWcnlJOE9QSXpzWHdMLzRW?=
 =?utf-8?B?bGN3N3VHdVdZZ2MvR0FkZVpsZkRETkgzeko0SjA0UXh1V0pvWkxSS1RmUHZB?=
 =?utf-8?B?Rmh0L0VrdHZ2M1JiV2ZHYWZDdTRPcUx3T2t4YUtEMmV3cFdlUFNUcWZlUzVx?=
 =?utf-8?B?bWtsaW5uMFhYbnZaY2c5THFVdVBGaHJnbHduZUpVZVFObjBtcGszUm5tWjNq?=
 =?utf-8?B?bTJKdlk0d0N0M1hjK09lVURDLzR6MnFmQ1lCTjQrZFdoK2JtNWQzNjNoMXVK?=
 =?utf-8?B?R3VtbUlyMTNrZFMzWENtMUphQkxJckF2UmtUeXdZMWJNUE5DY3J5UlFhdGRz?=
 =?utf-8?B?VVU3eFJLY0o1WFFZN29OSTlJOGw2TVF1Ni9SVkh6T0h1akZnU09VZHFYbisr?=
 =?utf-8?B?bTBuN1NINVlsQm9xV3Axd1gwTERBY1l6UDN4WU0reVlBalBVd0NCdUJ6VGlP?=
 =?utf-8?B?aGVlZVZ6RVcwT1hQM3Jtc0hoQTJiNHhoeGxpV1k3cTQ4Y25aSzFNWUFEY0ZZ?=
 =?utf-8?B?Q001TkNnaFpWMXNWL0NReXdUbkk5dzNRbGFiRTFGbjQ1eWxXRnBFVnRvK3RS?=
 =?utf-8?B?eG4ybzVIUHRoTGdueHBQd2dyaUltYXB1L01uVC93U3NpWVJFN0JoWW0rcyt2?=
 =?utf-8?B?bmVWeUJnV3dPMjhTVis3WTZWOUt1cEQxZnpUT0c2cXhWc2prZ3hCUmROSG9s?=
 =?utf-8?B?dnhIbDNkQUwxUksyK0xpUDhVckU2QVZ5ZzhwUEZHaTNwK2RRQS9TMUdNM1pJ?=
 =?utf-8?B?S0d2VGNLa1lvbmc5UHV1MzlOUnh5RGlyczRVeEg0bGQ1RDRBUlQ4RWdDMkJ5?=
 =?utf-8?B?OE9mSVArRXp6akl3elI4ME92Zks1NFowQlU0OHR5MVdKNm5IKy9OazR4Tmlv?=
 =?utf-8?B?LzhES3hEUTJmU0NNaUdDTVJLSUZsV2VuS1k4eE9VVXAvT0t4RWE4NDlvalZZ?=
 =?utf-8?B?OUpBdkdYejlQZmk1N0VJQVN1amNycnFjYU43elZrc3V4WjNWcC9KQXRmMk5a?=
 =?utf-8?B?UU43Z1JpOHU0WjlrNWFldDdMZ0dZMkh6UTdUWlFlNGZHd2FrL2k0ZEV2UnRK?=
 =?utf-8?B?cDhTdDV6cGhMNGhQVHZzTkYwcks5WlVjL0t2MFhCbkRuSHFvT1BoeXRwVWpt?=
 =?utf-8?B?ZXZYaFpSVmZTMnF3Z1pJanlCTXhSeGk4azVYSmhoMHVMTm5ZQ29HblRUem03?=
 =?utf-8?B?OW94d3Q5YnlSOGlvdXBGODU3VER1MXBLb25Rd1FabTRuNTcxQ1MxU2hzVmtB?=
 =?utf-8?B?MFFyYjEvYkd4ckxhSDgwVTdzRVQwSFZMWGx3Y0c0SWxZYUFTZkNIODRpclRM?=
 =?utf-8?B?dmxBM2JSa2pGR29jSXp6ZDRNREoxN3JmZk5rUnZXUjFNcVkzVmtOb20rUHp0?=
 =?utf-8?B?YVoxSG4rQ0xjRGZscnJOTVFmV3lLQndpRTJvb3c3L0x1T2ErMVY0UzREeHhS?=
 =?utf-8?B?R0pmdS8rUStaMDhHSmNHQkdBUDFjSUZCa3YzL0J3THE3eFA2cktsU2RCc05J?=
 =?utf-8?B?ZDgzWEZCemhickd0N0NuUmcrVkQvMVpBWE1iN0ZkbzFvZ0hud2h1NittSGd4?=
 =?utf-8?B?VkxsZXRwZ1ZGWjYraEVHRHZaeExEQU85TXdCMGNKMnVlYTRqU2VTeDdYc202?=
 =?utf-8?B?Q0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e63a924c-0bdc-4ce2-154a-08db3c419308
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 17:07:34.2858
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DrnyCyISq44txe/Fx/PeJ6nRkCSaJHUZgzEVJzPjSdFCwLQS00JRp96+sCw4wJtfQQcdDXOZxPKuw/i/85BxCvvLAWWI4bAKy8qhk8ekK+8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6943
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/13/2023 8:06 AM, Yan Wang wrote:
> The system hang because of dsa_tag_8021q_port_setup()->
> 				stmmac_vlan_rx_add_vid().
> 
> I found in stmmac_drv_probe() that cailing pm_runtime_put()
> disabled the clock.
> 
> First, when the kernel is compiled with CONFIG_PM=y,The stmmac's
> resume/suspend is active.
> 
> Secondly,stmmac as DSA master,the dsa_tag_8021q_port_setup() function
> will callback stmmac_vlan_rx_add_vid when DSA dirver starts. However,
> The system is hanged for the stmmac_vlan_rx_add_vid() accesses its
> registers after stmmac's clock is closed.
> 
> I would suggest adding the pm_runtime_resume_and_get() to the
> stmmac_vlan_rx_add_vid().This guarantees that resuming clock output
> while in use.
> 
> Signed-off-by: Yan Wang <rk.code@outlook.com>

This looks identical to the net fix you posted at [1]. I don't think we
need both?

[1]:
https://lore.kernel.org/netdev/KL1PR01MB5448020DE191340AE64530B0E6989@KL1PR01MB5448.apcprd01.prod.exchangelabs.com/