Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Apr 2023 20:19:18 +0300
From:   Leon Romanovsky <leon@kernel.org>
To:     Yixin Shen <bobankhshen@gmail.com>
Cc:     linux-kernel@vger.kernel.org, rdunlap@infradead.org,
        akpm@linux-foundation.org, netdev@vger.kernel.org,
        davem@davemloft.net, edumazet@google.com, ncardwell@google.com
Subject: Re: [PATCH net-next] lib/win_minmax: export symbol of
 minmax_running_min
Message-ID: <20230413171918.GX17993@unreal>
References: <20230413164726.59019-1-bobankhshen@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230413164726.59019-1-bobankhshen@gmail.com>
Precedence: bulk

On Thu, Apr 13, 2023 at 04:47:26PM +0000, Yixin Shen wrote:
> This commit export the symbol of the function minmax_running_min
> to make it accessible to dynamically loaded modules. It can make
> this library more general, especially for those congestion
> control algorithm modules who wants to implement a windowed min
> filter.
> 
> Signed-off-by: Yixin Shen <bobankhshen@gmail.com>
> ---
>  lib/win_minmax.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/win_minmax.c b/lib/win_minmax.c
> index ec10506834b6..1682e614309c 100644
> --- a/lib/win_minmax.c
> +++ b/lib/win_minmax.c
> @@ -97,3 +97,4 @@ u32 minmax_running_min(struct minmax *m, u32 win, u32 t, u32 meas)
>  
>  	return minmax_subwin_update(m, win, &val);
>  }
> +EXPORT_SYMBOL(minmax_running_min);

Please provide in-tree kernel user for that EXPORT_SYMBOL.

Thanks

> -- 
> 2.25.1
>