Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230412200913.1570873-1-pbonzini@redhat.com>
In-Reply-To: <20230412200913.1570873-1-pbonzini@redhat.com>
From:   Vipin Sharma <vipinsh@google.com>
Date:   Thu, 13 Apr 2023 10:36:57 -0700
Message-ID: <CAHVum0fDp8B0YSYdmMV0OHjA8s5O1Ba2-i81WB8ybhzbRp8RGg@mail.gmail.com>
Subject: Re: [PATCH] selftests/kvm: touch all pages of args on each memstress iteration
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        bgardon@google.com, seanjc@google.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Apr 12, 2023 at 1:09=E2=80=AFPM Paolo Bonzini <pbonzini@redhat.com>=
 wrote:
>
> Access the same memory addresses on each iteration of the memstress
> guest code.  This ensures that the state of KVM's page tables
> is the same after every iteration, including the pages that host the
> guest page tables for args and vcpu_args.
>

AMD and eptad=3D0 reasoning you gave in
https://lore.kernel.org/lkml/199f404d-c08e-3895-6ce3-36b21514f487@redhat.co=
m
should also be included here.

"It also reproduces on Intel with pml=3D0 and eptad=3D0; the reason is due
to the different semantics of dirty bits for page-table pages on AMD
and Intel.  Both AMD and eptad=3D0 Intel treat those as writes, therefore
more pages are dropped before the repopulation phase when dirty logging
is disabled.

The "missing" page had been included in the population phase because it
hosts the page tables for vcpu_args, but repopulation does not need it."

> This difference is visible on the dirty_log_page_splitting_test
> on AMD machines.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  tools/testing/selftests/kvm/lib/memstress.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/tools/testing/selftests/kvm/lib/memstress.c b/tools/testing/=
selftests/kvm/lib/memstress.c
> index 3632956c6bcf..df457452d146 100644
> --- a/tools/testing/selftests/kvm/lib/memstress.c
> +++ b/tools/testing/selftests/kvm/lib/memstress.c
> @@ -65,6 +65,9 @@ void memstress_guest_code(uint32_t vcpu_idx)
>         GUEST_ASSERT(vcpu_args->vcpu_idx =3D=3D vcpu_idx);
>
>         while (true) {
> +               for (i =3D 0; i < sizeof(memstress_args); i +=3D args->gu=
est_page_size)
> +                       (void) *((volatile char *)args + i);
> +
>                 for (i =3D 0; i < pages; i++) {
>                         if (args->random_access)
>                                 page =3D guest_random_u32(&rand_state) % =
pages;
> --
> 2.39.1
>

Apart from the commit log.
Reviewed-by: Vipin Sharma <vipinsh@google.com>