Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Apr 2023 21:36:58 +0300
From:   Alexey Dobriyan <adobriyan@gmail.com>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Chunguang Wu <aman2008@qq.com>, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs/proc: add Kthread flag to /proc/$pid/status
Message-ID: <59774223-680e-4b64-87ea-ab7e524be369@p183>
References: <tencent_3E1CBD85D91AD4CDDCB5F429A3948EB94306@qq.com>
 <20230412141216.c8f2c1313f34ee0100ac9ae4@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230412141216.c8f2c1313f34ee0100ac9ae4@linux-foundation.org>
Precedence: bulk

On Wed, Apr 12, 2023 at 02:12:16PM -0700, Andrew Morton wrote:
> On Wed, 12 Apr 2023 22:34:02 +0800 Chunguang Wu <aman2008@qq.com> wrote:
> 
> > user can know that a process is kernel thread or not.
> > 
> > ...
> >
> > --- a/fs/proc/array.c
> > +++ b/fs/proc/array.c
> > @@ -434,6 +434,12 @@ int proc_pid_status(struct seq_file *m, struct pid_namespace *ns,
> >  
> >  	task_state(m, ns, pid, task);
> >  
> > +	if ((mm == NULL) || (task->flags & PF_KTHREAD)) {
> > +		seq_puts(m, "Kthread:\tYes\n");
> > +	} else {
> > +		seq_puts(m, "Kthread:\tNo\n");
> > +	}

"mm" check is redundant. PF_KTHREAD should be enough.
If you're doing this, just print 0/1. 

> >  	if (mm) {
> >  		task_mem(m, mm);
> >  		task_core_dumping(m, task);
> 
> Well..   Why is this information useful?

I want to add: for a shell script.
Real programs can read /proc/*/stat .

> What is the use case?
> 
> There are many ways of working this out from the existing output - why
> is this change required?