Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2f955dc3105570df0acc2695739183ed.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20230413-topic-lahaina_vidcc-v1-2-134f9b22a5b3@linaro.org>
References: <20230413-topic-lahaina_vidcc-v1-0-134f9b22a5b3@linaro.org> <20230413-topic-lahaina_vidcc-v1-2-134f9b22a5b3@linaro.org>
Subject: Re: [PATCH 2/2] clk: qcom: Introduce SM8350 VIDEOCC
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     Marijn Suijten <marijn.suijten@somainline.org>,
        linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Konrad Dybcio <konrad.dybcio@linaro.org>
To:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Rob Herring <robh+dt@kernel.org>,
        Taniya Das <tdas@codeaurora.org>
Date:   Thu, 13 Apr 2023 12:04:44 -0700
User-Agent: alot/0.10
Precedence: bulk

Quoting Konrad Dybcio (2023-04-13 11:44:59)
> diff --git a/drivers/clk/qcom/videocc-sm8350.c b/drivers/clk/qcom/videocc=
-sm8350.c
> new file mode 100644
> index 000000000000..186a5bd9e184
> --- /dev/null
> +++ b/drivers/clk/qcom/videocc-sm8350.c
> @@ -0,0 +1,575 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (c) 2019-2020, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2023, Linaro Limited
> + */
> +
> +#include <linux/clk-provider.h>
> +#include <linux/module.h>
> +#include <linux/platform_device.h>
> +#include <linux/pm_clock.h>
> +#include <linux/pm_runtime.h>
> +#include <linux/regmap.h>
> +
> +#include <dt-bindings/clock/qcom,sm8350-videocc.h>
> +#include <dt-bindings/reset/qcom,sm8350-videocc.h>
> +
> +#include "clk-alpha-pll.h"
> +#include "clk-branch.h"
> +#include "clk-rcg.h"
> +#include "clk-regmap.h"
> +#include "clk-regmap-divider.h"
> +#include "common.h"
> +#include "reset.h"
> +#include "gdsc.h"
> +
> +enum {
> +       DT_BI_TCXO,
> +       DT_BI_TCXO_AO,
> +       DT_SLEEP_CLK,
> +};
> +
> +enum {
> +       P_BI_TCXO,
> +       P_BI_TCXO_AO,
> +       P_SLEEP_CLK,
> +       P_VIDEO_PLL0_OUT_MAIN,
> +       P_VIDEO_PLL1_OUT_MAIN,
> +};
> +
> +static struct pll_vco lucid_5lpe_vco[] =3D {

const

> +       { 249600000, 1750000000, 0 },
> +};
> +
> +static const struct alpha_pll_config video_pll0_config =3D {
> +       .l =3D 0x25,
> +       .alpha =3D 0x8000,
> +       .config_ctl_val =3D 0x20485699,
> +       .config_ctl_hi_val =3D 0x00002261,
> +       .config_ctl_hi1_val =3D 0x2a9a699c,
> +       .test_ctl_val =3D 0x00000000,
> +       .test_ctl_hi_val =3D 0x00000000,
> +       .test_ctl_hi1_val =3D 0x01800000,
> +       .user_ctl_val =3D 0x00000000,
> +       .user_ctl_hi_val =3D 0x00000805,
> +       .user_ctl_hi1_val =3D 0x00000000,
> +};
> +
> +static struct clk_alpha_pll video_pll0 =3D {
> +       .offset =3D 0x42c,
> +       .vco_table =3D lucid_5lpe_vco,
> +       .num_vco =3D ARRAY_SIZE(lucid_5lpe_vco),
> +       .regs =3D clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_LUCID],
> +       .clkr =3D {
> +               .hw.init =3D &(struct clk_init_data){

const

> +                       .name =3D "video_pll0",
> +                       .parent_data =3D &(const struct clk_parent_data){
> +                               .index =3D DT_BI_TCXO,
> +                       },
> +                       .num_parents =3D 1,
> +                       .ops =3D &clk_alpha_pll_lucid_5lpe_ops,
> +               },
[...]
> +
> +static const struct regmap_config video_cc_sm8350_regmap_config =3D {
> +       .reg_bits =3D 32,
> +       .reg_stride =3D 4,
> +       .val_bits =3D 32,
> +       .max_register =3D 0x10000,
> +       .fast_io =3D true,
> +};
> +
> +static struct qcom_cc_desc video_cc_sm8350_desc =3D {
> +       .config =3D &video_cc_sm8350_regmap_config,
> +       .clks =3D video_cc_sm8350_clocks,
> +       .num_clks =3D ARRAY_SIZE(video_cc_sm8350_clocks),
> +       .resets =3D video_cc_sm8350_resets,
> +       .num_resets =3D ARRAY_SIZE(video_cc_sm8350_resets),
> +       .gdscs =3D video_cc_sm8350_gdscs,
> +       .num_gdscs =3D ARRAY_SIZE(video_cc_sm8350_gdscs),
> +};
> +
> +static void video_cc_sm8350_pm_runtime_disable(void *data)
> +{
> +       pm_runtime_disable(data);
> +}
> +
> +static int video_cc_sm8350_probe(struct platform_device *pdev)
> +{
> +       struct regmap *regmap;
> +       int ret;
> +
> +       pm_runtime_enable(&pdev->dev);
> +
> +       ret =3D devm_add_action_or_reset(&pdev->dev, video_cc_sm8350_pm_r=
untime_disable, &pdev->dev);

devm_pm_runtime_enable()?

> +       if (ret)
> +               return ret;
> +