Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9d66afdb-40bd-4254-547e-05f6481dd550@amd.com>
Date:   Thu, 13 Apr 2023 14:40:10 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v3 2/6] efi/cper: Export cper_mem_err_unpack() for use by
 modules
Content-Language: en-US
To:     Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc:     alison.schofield@intel.com, vishal.l.verma@intel.com,
        ira.weiny@intel.com, bwidawsk@kernel.org, dan.j.williams@intel.com,
        dave.jiang@intel.com, linux-cxl@vger.kernel.org, rrichter@amd.com,
        linux-kernel@vger.kernel.org, bhelgaas@google.com,
        Ard Biesheuvel <ardb@kernel.org>, linux-efi@vger.kernel.org
References: <20230411180302.2678736-1-terry.bowman@amd.com>
 <20230411180302.2678736-3-terry.bowman@amd.com>
 <20230413170816.0000333b@Huawei.com>
From:   Terry Bowman <Terry.Bowman@amd.com>
In-Reply-To: <20230413170816.0000333b@Huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWlWb2FNV1YvRnM5Z0N3UyswWHJpd2lQWjR2NDdsSlJlS3ZtWXN3ZXBQU1FH?=
 =?utf-8?B?NUU0V3Y1cmhVZHdHZXpmOHJ5em1qK1RRaXM3RlY0QW5pM0RnU1BnVDdIdXNu?=
 =?utf-8?B?YUxOTUVzcTZYekpTSGxnVGdLTi9zTjl5QS80MEp0bWhnYm1tLzBSZ2hQYmMr?=
 =?utf-8?B?YkxjSkxnWDRLOUF4M050c3M4QmpYYkw5elVOMGd3aFUwUG5nYjRkdnF2Wmsv?=
 =?utf-8?B?VER4dGV3dHFtWFlFcDRYOUdzdWlFRHJmS256b2xZRkMxMEs3V3JEMW9sWWVD?=
 =?utf-8?B?VXBvMGFIQjU5MUYvNjhFQXpPdFkvUGtsQXJaSGlDNUg5ZVBidEg2OTRmdURG?=
 =?utf-8?B?MEZ3TG9CaXBvSzlGQjhjMmVzUUNzYTZkMVVTc1dkNGtHK2pUUVBhZzNiZU1a?=
 =?utf-8?B?Q0dxL3hMeVNiV2lWQndCdzlocmNBMU1halFsWFFlQ21SRE9uM2RTcWtSTVVp?=
 =?utf-8?B?VkJoQ2JmVkxnN2toelNHS3pPRDRaMmJPcjBZK2VCSkJOQzdlaHlhVEtqbDlk?=
 =?utf-8?B?ZEM1cXpjeHdHelFLNUlVMnYvWHNTNXplWDhqSytwRVByY1BwK2doYSs0VUpT?=
 =?utf-8?B?U2RqSWNYM3FlMXFXTTlxU2QrRXFjWGgzeUFra0htUHZYVUpDeUMrS2oweG5p?=
 =?utf-8?B?U1RpWDFueWhDSURFZkdNQ3Z0SnlqOTFhSWNNNUQvTTYzbU9rL2Z5aGZzUVJW?=
 =?utf-8?B?dVFORk1HVFlwa2pzZngreUlYNW1weExNOTN4NERUVkNrdnhySU5uaUVxMzBF?=
 =?utf-8?B?TzRvamxKY3ByN290cDlmclo2d0s3Q2d2WjZqYnZ1TDUrRmZ4K2Jwdjg2V01k?=
 =?utf-8?B?NWxka0ZXejI4ODByTXUzNTM0L2JGV0QvWWs4ZnUxMUk5SHU5K2pIaXp6RmFZ?=
 =?utf-8?B?RFpXbmpaMWthaW02Nlk5UDc0dWl0Z3Nsa3JSK3Y2S1VaaktFdy9TNHBIbXp4?=
 =?utf-8?B?R2ZBQUdQaTM1RTd6U04xTEpjZUpEVFhYN3ZXakgzMEtZM0s2cFNESFZwNlo4?=
 =?utf-8?B?eUxHQkQ1a3BSQlFIK0VBc3EyM3BhNGIrSFMyN1NlMzk4ZEtmNzE1WE5Zd045?=
 =?utf-8?B?bHdhMVBubEEraVdGV3RsQnZCODJhaUt0UmVZWWkyL3FvNG1BNUNQSzdJYXBE?=
 =?utf-8?B?ajdCV2JrZjlZUFpqb29rYmdRMXhoZDJUZ1ZLRTZyRVBIR3owcEhVdnp5RlZh?=
 =?utf-8?B?blIwcDNVN3BXR3FqRVVYVzNiemVZeUQvc0ZuU0dPckQrQlhxM0RvNVF2MDNo?=
 =?utf-8?B?K0tURUxpTjNHc2N1N3ZYb2pZaHI3a09yZENIb0RwY09Ja0JVSWEzalBxMDM2?=
 =?utf-8?B?NFFZRTVhWW1ScU8zQnVNbkZSb05MN2Z6eWtRUUFsWmw1cDA1WDA3MzFwSVNL?=
 =?utf-8?B?dlR1Qkd1Wkd6c2VBMDhYUTRkc3NzSmFxeTJ2ZVhNQ3pjcWVpQ1dWcG9WQkM3?=
 =?utf-8?B?c1ZFRDVEK0J3bzZHKzlYbERZM3BTZlhQME9WeEhXcjNaUzlBSWZ0a2pEbTRS?=
 =?utf-8?B?UWNyU0p2WWNhTWF0SWM1ZFY0MlNCUGhtc0FYK0FXNjV5YkR5OHBhNEEwYjFT?=
 =?utf-8?B?UFk2dUIySndBZWVGVWhNdXN5TFY5aXRVbEF6R01IaEt0MVBYTGszdHYyVldE?=
 =?utf-8?B?MGxML2tyVE9QUTVDS3dBWkg1bjVxRkVxZGtZcktOV2RRZ2tqdHR1NmRuTG00?=
 =?utf-8?B?cVRhbnpwakJTaTc4enpRNnQwaVRlVDEwcWtWRTFvb1FZRk9SQWk5UGd2YzBr?=
 =?utf-8?B?OHB3dEU4RXZJMnlRQ2hia05Ub1Z6bzAveStJaXdHZ3lxTjRTTFlyYUk3d0di?=
 =?utf-8?B?TCttNzdUM2xEV0R1aC9lUGhsNHpkUWM0VHRrV2FrRGxSbkRla1JHM0kzdW9t?=
 =?utf-8?B?UlVDSC9vTU50NUxWVmpTVDlOOEhVL2t2UytrMUpKY29uUG00M05RVXRCVWhD?=
 =?utf-8?B?cEhyNHNjSXdXTjBVcXdpQ3dwSk45dlZ2aXU5aUlPMjRuK3pQZmhISlpFQlNT?=
 =?utf-8?B?aEw5RzJTRzRLeEd5QTUrM3REUGllcjJXWEM1LzFiQ1BpUU5GbE52QTBrbmhC?=
 =?utf-8?B?QmM5WTJpcS9GNW52SnV4dEJTbjBDU05GY2IzZFdBNnhRajhwT1g5Z3ZoWTU5?=
 =?utf-8?Q?4+Oa7xIOnTewV2B0MmNJEnyXg?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f9e65e6b-949d-4483-2f38-08db3c56e5cf
X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6390.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 19:40:12.4882
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: N/zmmuHej3mIs+UIXlq0atJ8Zp8uxcq7qiKvOHZL7YgYKqpZfSNF2pHv6d9bTUqDP0Zbqx7r5G7W/2neTK1rxQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7442
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jonathan,

On 4/13/23 11:08, Jonathan Cameron wrote:
> On Tue, 11 Apr 2023 13:02:58 -0500
> Terry Bowman <terry.bowman@amd.com> wrote:
> 
>> The CXL driver plans to use cper_print_aer() for restricted CXL host (RCH)
>> logging. This is not currently possible if CXL is built as a loadable
>> module because cper_print_aer() depends on cper_mem_err_unpack() which
>> is not exported.
>>
>> Export cper_mem_err_unpack() to enable cper_print_aer() usage in
>> CXL and other loadable modules.
> 
> No problem with the export, but I'm struggling to see the path that needs it.
> Could you give a little more detail, perhaps a call path?
> 

The cper_print_aer() is used to log RCH dport AER errors. This is needed 
because the RCH dport AER errors are not handled directly by the AER port 
driver. I'll add these details to the patch.

Regards,
Terry

> Thanks,
> 
> Jonathan
> 
>>
>> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
>> Cc: Ard Biesheuvel <ardb@kernel.org>
>> Cc: linux-efi@vger.kernel.org
>> ---
>>  drivers/firmware/efi/cper.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/firmware/efi/cper.c b/drivers/firmware/efi/cper.c
>> index 35c37f667781..ff15e12160ae 100644
>> --- a/drivers/firmware/efi/cper.c
>> +++ b/drivers/firmware/efi/cper.c
>> @@ -350,6 +350,7 @@ const char *cper_mem_err_unpack(struct trace_seq *p,
>>  
>>  	return ret;
>>  }
>> +EXPORT_SYMBOL_GPL(cper_mem_err_unpack);
>>  
>>  static void cper_print_mem(const char *pfx, const struct cper_sec_mem_err *mem,
>>  	int len)
>