Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230227171751.1211786-1-jpiotrowski@linux.microsoft.com>
 <ZAd2MRNLw1JAXmOf@google.com> <959c5bce-beb5-b463-7158-33fc4a4f910c@linux.microsoft.com>
 <ZDSa9Bbqvh0btgQo@google.com> <ecd3d8de-859b-e5dd-c3bf-ea9c3c0aac60@linux.microsoft.com>
 <ZDWEgXM/UILjPGiG@google.com> <61d131da-7239-6aae-753f-2eb4f1b84c24@linux.microsoft.com>
 <ZDg6w+1v4e/uRDfF@google.com> <ZDhTeIXRdcXDaD54@google.com>
In-Reply-To: <ZDhTeIXRdcXDaD54@google.com>
From:   David Matlack <dmatlack@google.com>
Date:   Thu, 13 Apr 2023 13:21:44 -0700
Message-ID: <CALzav=dv2MhoZ1BLqJWmmJv=H6vRaRUEcAJPydjrzJf1wdYEOA@mail.gmail.com>
Subject: Re: [PATCH] KVM: SVM: Disable TDP MMU when running on Hyper-V
To:     Sean Christopherson <seanjc@google.com>
Cc:     Jeremi Piotrowski <jpiotrowski@linux.microsoft.com>,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Tianyu Lan <ltykernel@gmail.com>,
        Michael Kelley <mikelley@microsoft.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Apr 13, 2023 at 12:10=E2=80=AFPM Sean Christopherson <seanjc@google=
.com> wrote:
>
> On Thu, Apr 13, 2023, Sean Christopherson wrote:
> > Aha!  Idea.  There are _at most_ 4 possible roots the TDP MMU can encou=
nter.
> > 4-level non-SMM, 4-level SMM, 5-level non-SMM, and 5-level SMM.  I.e. n=
ot keeping
> > inactive roots on a per-VM basis is just monumentally stupid.
>
> One correction: there are 6 possible roots:
>
>   1. 4-level !SMM !guest_mode (i.e. not nested)
>   2. 4-level SMM !guest_mode
>   3. 5-level !SMM !guest_mode
>   4. 5-level SMM !guest_mode
>   5. 4-level !SMM guest_mode
>   6. 5-level !SMM guest_mode
>
> I forgot that KVM still uses the TDP MMU when running L2 if L1 doesn't en=
able
> EPT/TDP, i.e. if L1 is using shadow paging for L2.  But that really doesn=
't change
> anything as each vCPU can already track 4 roots, i.e. userspace can satur=
ate all
> 6 roots anyways.  And in practice, no sane VMM will create a VM with both=
 4-level
> and 5-level roots (KVM keys off of guest.MAXPHYADDR for the TDP root leve=
l).

Why do we create a new root for guest_mode=3D1 if L1 disables EPT/NPT?