Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8b602852596974df384b2d7088cadd64.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20230413-critter-synopsis-dac070a86cb4@spud>
References: <20230413-critter-synopsis-dac070a86cb4@spud>
Subject: Re: [PATCH v1] clk: microchip: fix potential UAF in auxdev release callback
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     conor@kernel.org, Conor Dooley <conor.dooley@microchip.com>,
        stable@vger.kernel.org,
        Daire McNamara <daire.mcnamara@microchip.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Claudiu Beznea <claudiu.beznea@microchip.com>,
        linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
To:     Conor Dooley <conor@kernel.org>
Date:   Thu, 13 Apr 2023 15:43:45 -0700
User-Agent: alot/0.10
Precedence: bulk

Quoting Conor Dooley (2023-04-13 15:20:45)
> From: Conor Dooley <conor.dooley@microchip.com>
>=20
> Similar to commit 1c11289b34ab ("peci: cpu: Fix use-after-free in
> adev_release()"), the auxiliary device is not torn down in the correct
> order. If auxiliary_device_add() fails, the release callback will be
> called twice, resulting in a UAF. Due to timing, the auxdev code in this
> driver "took inspiration" from the aforementioned commit, and thus its
> bugs too!
>=20
> Moving auxiliary_device_uninit() to the unregister callback instead
> avoids the issue.
>=20
> CC: stable@vger.kernel.org
> Fixes: b56bae2dd6fd ("clk: microchip: mpfs: add reset controller")
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---

Applied to clk-next