Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp3191025rwl; Thu, 13 Apr 2023 17:36:11 -0700 (PDT) X-Google-Smtp-Source: AKy350Z+iGDe4Mk59AoJut3gCEnJIkGzpdB9w275j+ZWfScjMMnutRFfZew3FGhTqqp3WbNTzeSn X-Received: by 2002:a17:90a:8c86:b0:247:1081:d08e with SMTP id b6-20020a17090a8c8600b002471081d08emr5922663pjo.8.1681432570808; Thu, 13 Apr 2023 17:36:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681432570; cv=none; d=google.com; s=arc-20160816; b=fSnR8nUZwa5YQRXQO8pwCLKOAzTnvtVE2G+XYdGAYQ+jsrrVFZOOigusdP5liVrICS kisEBG062KE6voOeuKHffLxRrCXGfwj5MvfBoXtFcICEoYGSZTqCEYbLKtgKTFX+3S6f i3PobnnN3OOP5EVsTcwyq0PoRGbHctLVCHW9vK4pxcBZiky94EFofp79gJmA9jnkuGXT cRNctraMHcKgvBnIipSIKNw0fliTRCKadrucC0L1ifIxzfDumMXFQgff2amiF+aIaTWE I2/7M0bh/QdFpXlpI+AlBOYzjErvOC1CR6cUE5FErcIpVjsmujqoPE1fSqTl+a8C04/T kP7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=VqUT0h3T9DoBGpj4454pVSsU484YratLmvipr0uxCkE=; b=0MwH4IjF6zxuZeXnKIrtlM5y2wPVrH74sgFM9WRP1KVatGOjtEGnbR2U5DBOtkzl0c CjiMX9GtgtuAuLaE+VfJrzk+BLeg+svlsS/hJK4qvXgDZ+Jr50zU4KPAz70gNQMAyQaP FpHWRzEI7L7JcD1/c5TLhnhQTNfD1yoisjzsm2KcIc3bX2ano90F8QZ5NhjiG3h0VcOj oQu92BWAlXT0UuKoovrn4AhGPrxpaugmamgh13g0a/PXVPJneiMVi2JERbWBYh1DOMyw FiYyu5z4Z0biE62Zs+LP5c9oYZ0AVw0RvNcqmN96m2ndtTnLjsWxq35INbRi1cR7iVXk 42Mg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="bhMNyx/r"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p6-20020a654906000000b005030925d31asi3261994pgs.203.2023.04.13.17.35.54; Thu, 13 Apr 2023 17:36:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="bhMNyx/r"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229564AbjDNAc2 (ORCPT + 99 others); Thu, 13 Apr 2023 20:32:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229479AbjDNAc2 (ORCPT ); Thu, 13 Apr 2023 20:32:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AE57B7; Thu, 13 Apr 2023 17:32:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A0EFA6154A; Fri, 14 Apr 2023 00:32:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54A45C433EF; Fri, 14 Apr 2023 00:32:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681432345; bh=VqUT0h3T9DoBGpj4454pVSsU484YratLmvipr0uxCkE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=bhMNyx/rbBdmZNmBaSVTQITczQgOV7Rzh4tDnCe1rMQL+6sIJAZY5fQtGQ9STmYLD Tsl3D97zNWpR9q2PqNOp4NpCmf2J6DgBSu83ps6f0CTSFqQZhfgSSJIrZmJbjTJXz4 csE7BJdrRsIUEG1sedjspDYgXNwxknODTQszWqY9dv1CRSAKv2gCpXhGN0VqQLoN/E ciJenZukBmMuWAAiAieB1s1mYEIw8qbo9mHDjn9+NTMyL3CQafhZ98hwcUOIggHoZs SUCBFKZxxgwLQRJGlCBnPg0gAZgcy3AgwxCopNErI/QqccdZNSRFfGVsPFnLYoMc9b 8rpaSO0PVQjCg== Message-ID: Date: Thu, 13 Apr 2023 18:32:24 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH net-next v2] net/ipv6: silence 'passing zero to ERR_PTR()' warning Content-Language: en-US To: Haoyi Liu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: hust-os-kernel-patches@googlegroups.com, yalongz@hust.edu.cn, error27@gmail.com, Dongliang Mu , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230413101005.7504-1-iccccc@hust.edu.cn> From: David Ahern In-Reply-To: <20230413101005.7504-1-iccccc@hust.edu.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/13/23 4:10 AM, Haoyi Liu wrote: > Smatch complains that if xfrm_lookup() returns NULL then this does a > weird thing with "err": xfrm_lookup is a wrapper around xfrm_lookup_with_ifid which returns either either a valid dst or ERR_PTR(err).