Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ming Qian <ming.qian@nxp.com>
To:     mchehab@kernel.org, hverkuil-cisco@xs4all.nl
Cc:     shawnguo@kernel.org, robh+dt@kernel.org, s.hauer@pengutronix.de,
        kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
        xiahong.bao@nxp.com, eagle.zhou@nxp.com, tao.jiang_2@nxp.com,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: [PATCH] media: amphion: drop repeated codec data for vc1l format
Date:   Fri, 14 Apr 2023 09:55:42 +0800
Message-Id: <20230414015543.6580-1-ming.qian@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rNaL1GAFuNVud+L4Nh24cZk7DgIVa2/S36s1WDnHzFKxQs6qWdUXATpoXrrg?=
 =?us-ascii?Q?962qEq85CpiJvVAgTuAhiYlj8IJJ3IEKO7VbkOoxwx5ZprqBCntBXHhCSD+i?=
 =?us-ascii?Q?QSkDw8VfH2HX1ispBR/NOICazefYdZ0NuiMaDAMxXMEzbYhaAn6AoxGJkoyT?=
 =?us-ascii?Q?P15jYewfRHUVSeRDcT0eHnU4QWwLxvv4mPoS7+QMtICvy0xsJHeTB5h2WJUP?=
 =?us-ascii?Q?XLb9HjbEU6l2+evCaE1qK4F6rFy/CpjwYHXIEVIZFAK/JmGdVYrFihnMteYT?=
 =?us-ascii?Q?RTl6uAQfGiNpyiiSnBk/D/o3zmqrbzFbGmKVKBXYF3+vqp19iu+PmoqyaZRe?=
 =?us-ascii?Q?YTiryffH/rQaa6rZRS3EbvyXE3fczqxZ1MQjyICyQ4Z/TZtvrX+XhcdW5RSZ?=
 =?us-ascii?Q?jyuAFDUWCFyrlUDeWWct3KQFRKDycoirYbLbXqLqzu8P0azG7CEqS/dYDkHF?=
 =?us-ascii?Q?NnqtU2oW9ukcv9p8g4i9WXqlpIuUNtM+ry32vo0JTOkCxZHDfxtXXiZzIXaV?=
 =?us-ascii?Q?JCaHmnYU76186+vgHuHxlmKcdhtW1KBNG6aW7IAki5MXhBECO3v2WErGapgX?=
 =?us-ascii?Q?Jl9y0UwzU5kD7gdk51s0kIKbxlkhWRTllKMSgJwbW/BijT+FAC5qlKV/wPpi?=
 =?us-ascii?Q?f/uxaMDuHUDTrAA1FrqWAhd0GxpHqUyFfNqDOYIOnc9A3xrzFYUHcosCamwh?=
 =?us-ascii?Q?uUX7pYmnI28SvLhziuLzY4/RaOVdnDdHRS3ekfLu2qSSNM6G+sAD8B4tT6Ro?=
 =?us-ascii?Q?adp8V/696dXyFOema51MHg/yDDI46tsYfFONAx/ibmzkKpIycMSOSKH2ibh9?=
 =?us-ascii?Q?dDdeu1Ah5zdgAGgb9JUXJ0rd/IcE7JcDoPfXFY6hg7mkW2Rr3VGD+0SBui4j?=
 =?us-ascii?Q?S5wTJoHf4hrgNO7swCfmDFJXRwfhnyQQ68Lw744r1OW0DFtpnwqAqpsAvK0p?=
 =?us-ascii?Q?KZvKBuk+MikdOkrmS1EAbi2OLmyC9StoKsvDyzfIRWKZca5yel1ozDkrW0re?=
 =?us-ascii?Q?b4PgJmp8Z7LNNcmuLPjmYMoX6oSTtxKaLu5OHW5gdt+B61BfOfEOsgzyHRus?=
 =?us-ascii?Q?WxEnEx4uWJ2x8FjAcS/s6D7FN4C/17WHAicbazpCY6zzRbGj/sBOYZebyQJi?=
 =?us-ascii?Q?fJv+khu6aByFJf/jOhqljZEC25exVZk7nsYagwAwpR7nqMkIEEdJmPKeyymt?=
 =?us-ascii?Q?C5djNPeblRIJ8vgJGroIgjuEjVJbIvSTt3Iqf9qh+AFzh1N91YNAr6Y5x9PK?=
 =?us-ascii?Q?Qn5Fxz7Qj5XbFyzrPMYFKCmzXLinV9pTLeI6IzXIeMk3oknE2QPkzq8+xtIM?=
 =?us-ascii?Q?sbkUOl2yliN6UVrQ3V6baMHcxPdIkGDcABMRrg6G3moozYlbmZl0UWQuqjGL?=
 =?us-ascii?Q?vtLw3HvzjOjSxUnNWf0M1tZ8O4pdxXBK0HuufjHGCzufcRiMkxX3UjG1pqtd?=
 =?us-ascii?Q?PbLhXIzwlgLhWFBO62t4kZmZZBsuX1AYPcKwL78NDMAIQrF/yAUPwrGDB1VV?=
 =?us-ascii?Q?AaqwbKYQrnRAvRby5VJF0fkaeL76u8aTuJ/KtM70RP8xrLUsrSI6NKF5EcW8?=
 =?us-ascii?Q?bwZxOveCs+1+9Y85KEDlWsbVDnSypTS9r/gdU9Tr?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b34842ff-afb8-4866-e5b9-08db3c8b69cc
X-MS-Exchange-CrossTenant-AuthSource: DB8PR04MB6346.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 01:56:07.9515
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 32VLx44TrDgRQc+JfNysFFIsVL9WcAJLO0uUSxkojMUtL63cjAgScPJBkVy+65U9XJs+wJqqnIQmFP/2l5WoZA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9342
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

For format V4L2_PIX_FMT_VC1_ANNEX_L,
the codec data is replaced with startcode,
and then driver drop it, otherwise it may led to decoding error.

It's amphion vpu's limitation

Driver has dropped the first codec data,
but need to drop the repeated codec data too.

Fixes: e670f5d672ef ("media: amphion: only insert the first sequence startcode for vc1l format")
Signed-off-by: Ming Qian <ming.qian@nxp.com>
Tested-by: xiahong.bao <xiahong.bao@nxp.com>
---
 drivers/media/platform/amphion/vpu_malone.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/media/platform/amphion/vpu_malone.c b/drivers/media/platform/amphion/vpu_malone.c
index ef44bff9fbaf..e96994437429 100644
--- a/drivers/media/platform/amphion/vpu_malone.c
+++ b/drivers/media/platform/amphion/vpu_malone.c
@@ -1344,6 +1344,8 @@ static int vpu_malone_insert_scode_vc1_l_seq(struct malone_scode_t *scode)
 	int size = 0;
 	u8 rcv_seqhdr[MALONE_VC1_RCV_SEQ_HEADER_LEN];
 
+	if (vpu_vb_is_codecconfig(to_vb2_v4l2_buffer(scode->vb)))
+		scode->need_data = 0;
 	if (scode->inst->total_input_count)
 		return 0;
 	scode->need_data = 0;
-- 
2.38.1