Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp3273046rwl; Thu, 13 Apr 2023 19:20:16 -0700 (PDT) X-Google-Smtp-Source: AKy350ab/2/SyrnL6arndCLS24u+zWv3yxp5n4GzBals8nfcKUl8pqpATk5vrJkpWks9k8Ip7T47 X-Received: by 2002:a17:903:1d1:b0:1a4:fca9:7f44 with SMTP id e17-20020a17090301d100b001a4fca97f44mr1163451plh.56.1681438816024; Thu, 13 Apr 2023 19:20:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681438816; cv=none; d=google.com; s=arc-20160816; b=sOtVV1V/Em+SCjeiurEInhk29b8yQxUhExk7lpf6HT5rg9JocHo0zHRvNuPgp6atPZ aLqm7hmF7NIvY7+QasmCrFil3j8+QMNpkq7L/tAqKeZZOAFZ1DvXvNA/AuMKSRusPl4x cSkhMxqTsfHyVB82K7RWyWMrb3lZAjQPIt47nXbzDQ9UavytaZ2Or06J01kCFxO74aRY t/4uvb3wL0tEXDwpgx49/gRISbDNrzMUeItsTJdWjXPQBx4WNZdijHMeL6DOGWFz3hep yQSdIaKyigNtpDCMIEBXSz2MtPSRit92Q9BU/VfH4yGRCST7VDO+IdktLG4RoY6X5TLm qOmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=KZUA/RoJHJ6qS4Kx5ByQojqxW8WEBGv+KThTGaJxh3U=; b=zh2UNa/0hGycCKq4lqzyBLbNj7oS2E4W2AckyaP8jKzgmwkV+SPuubLJ1Onk8CnLXY xi/VorJSuJ4sNi4hj12qe9oZdCedxNHn3MXOvddcWV59R+ev2CMt6J5v6RpLpZjniU/q FIQi3E0mkeZ4NFFDKSZ1L7F06Lx17SdtTbV29G+o7Cs+DrEZDHIjqUFY9kVK668J5ALe A7pnpGTlPX/1ORbzOVL7Fv/8wsk/WRt57zeMcNS/PnC3ICDEBv/1HOLkhUJWL+IJTXDG hsXH7tM+BSzC/r/UAo1RibHD3H4qaqmNPbALR6WmbjC/LReQL5XUOW+cIt8oTVJdptXV fnGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baikalelectronics.ru header.s=post header.b=RrUReIi3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=baikalelectronics.ru Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g13-20020a170902c38d00b001a05d8436d8si3240777plg.475.2023.04.13.19.20.02; Thu, 13 Apr 2023 19:20:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@baikalelectronics.ru header.s=post header.b=RrUReIi3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=baikalelectronics.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229886AbjDNCTS (ORCPT + 99 others); Thu, 13 Apr 2023 22:19:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229625AbjDNCTP (ORCPT ); Thu, 13 Apr 2023 22:19:15 -0400 Received: from post.baikalelectronics.com (post.baikalelectronics.com [213.79.110.86]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A6767524B; Thu, 13 Apr 2023 19:18:59 -0700 (PDT) Received: from post.baikalelectronics.com (localhost.localdomain [127.0.0.1]) by post.baikalelectronics.com (Proxmox) with ESMTP id E8F52E0EAB; Fri, 14 Apr 2023 05:18:57 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= baikalelectronics.ru; h=cc:cc:content-transfer-encoding :content-type:content-type:date:from:from:message-id :mime-version:reply-to:subject:subject:to:to; s=post; bh=KZUA/Ro JHJ6qS4Kx5ByQojqxW8WEBGv+KThTGaJxh3U=; b=RrUReIi3ScT/SqmM7A4oZ8q CQpkETlmNI3h+txuC5JwNjv378JxdETuMWvZv7xDM5WVjqG/9UKm9bJoKDHvcAnt S4OVj4RbIq8aevwORJOjIcSCATneElKz3HIrbSUXlmmJ+rLcTbZ+pZ+BQzT9buwh SyTOVsZ0TASqqPr9xNGA= Received: from mail.baikal.int (mail.baikal.int [192.168.51.25]) by post.baikalelectronics.com (Proxmox) with ESMTP id D0947E0E1D; Fri, 14 Apr 2023 05:18:57 +0300 (MSK) Received: from localhost (10.8.30.14) by mail (192.168.51.25) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 14 Apr 2023 05:18:57 +0300 From: Serge Semin To: Bjorn Helgaas , Lorenzo Pieralisi , Cai Huoqing , Jingoo Han , Gustavo Pimentel , Vinod Koul , Manivannan Sadhasivam , Yoshihiro Shimoda , Rob Herring CC: Serge Semin , Serge Semin , Alexey Malahov , Pavel Parkhomenko , , , Subject: [PATCH v4 00/14] PCI: dwc: Relatively simple fixes and cleanups Date: Fri, 14 Apr 2023 05:18:18 +0300 Message-ID: <20230414021832.13167-1-Sergey.Semin@baikalelectronics.ru> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.8.30.14] X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It turns out the recent DW PCIe-related patchset was merged in with several relatively trivial issues left unsettled (noted by Bjorn and Manivannan). All of these lefovers have been fixed in this patchset. Namely the series starts with two bug-fixes. The first one concerns the improper link-mode initialization in case if the CDM-check is enabled. The second unfortunate mistake I made in the IP-core version type helper. In particular instead of testing the IP-core version type the macro function referred to the just IP-core version which obviously wasn't what I intended. Afterwards two @Mani-noted fixes follow. Firstly the dma-ranges related warning message is fixed to start with "DMA-ranges" word instead of "Dma-ranges". Secondly the Baikal-T1 PCIe Host driver is converted to perform the asynchronous probe type which saved us of about 15% of bootup time if no any PCIe peripheral device attached to the port. Then the patchset contains the Baikal-T1 PCIe driver fix. The corresponding patch removes the false error message printed during the controller probe procedure. I accidentally added the unconditional dev_err_probe() method invocation. It was obviously wrong. Then two trivial cleanups are introduced. The first one concerns the duplicated fast-link-mode flag unsetting. The second one implies dropping a redundant empty line from the dw_pcie_link_set_max_speed() function. The series continues with a patch inspired by the last @Bjorn note regarding the generic resources request interface. As @Bjorn correctly said it would be nice to have the new interface used wider in the DW PCIe subsystem. Aside with the Baikal-T1 PCIe Host driver the Toshiba Visconti PCIe driver can be easily converted to using the generic clock names. That's what is done in the noted patch. The patchset is closed with a series of MAINTAINERS-list related patches. Firstly after getting the DW PCIe RP/EP DT-schemas refactored I forgot to update the MAINTAINER-list with the new files added in the framework of that procedure. All the snps,dw-pcie* schemas shall be maintained by the DW PCIe core driver maintainers. Secondly seeing how long it took for my patchsets to review and not having any comments from the original driver maintainers I'd suggest to add myself as the reviewer to the DW PCIe and eDMA drivers. Thus hopefully the new updates review process will be performed with much less latencies. For the same reason @Manivannan is added to the maintainers list of the DW PCIe/eDMA drivers as he already agreed to be in. Link: https://lore.kernel.org/linux-pci/20230217093956.27126-1-Sergey.Semin@baikalelectronics.ru/ Changelog v2: - Rebase onto the kernel 6.3-rc2. Link: https://lore.kernel.org/linux-pci/20230313200816.30105-1-Sergey.Semin@baikalelectronics.ru/ Changelog v3: - Drop the patch: [PATCH v2 01/11] PCI: dwc: Fix port link CSR improper init if CDM check enabled and rebase onto the already submitted by @Yoshihiro fix: commit cdce67099117 ("PCI: dwc: Fix PORT_LINK_CONTROL update when CDM check enabled") - Just resend. Link: https://lore.kernel.org/linux-pci/20230411033928.30397-1-Sergey.Semin@baikalelectronics.ru/ Changelog v4: - Demote @Gustavo to being DW PCIe/eDMA drivers reviewer: [PATCH v4 9/14] MAINTAINERS: Demote Gustavo Pimentel to DW PCIe core reviewer [PATCH v4 12/14] MAINTAINERS: Demote Gustavo Pimentel to DW EDMA driver reviewer - Add Manivannan to the DW PCIe/eDMA drivers maintainers list: [PATCH v4 10/14] MAINTAINERS: Add Manivannan to DW PCIe core maintainers list [PATCH v4 13/14] MAINTAINERS: Add Manivannan to DW eDMA driver maintainers list Signed-off-by: Serge Semin Cc: Alexey Malahov Cc: Pavel Parkhomenko Cc: linux-pci@vger.kernel.org Cc: dmaengine@vger.kernel.org Cc: linux-kernel@vger.kernel.org Serge Semin (14): PCI: dwc: Fix erroneous version type test helper PCI: dwc: Fix inbound iATU entries out-of-bounds warning message PCI: bt1: Enable async probe type PCI: bt1: Fix printing false error message PCI: dwc: Drop duplicated fast-link-mode flag unsetting PCI: dwc: Drop empty line from dw_pcie_link_set_max_speed() PCI: visconti: Convert to using generic resources getter MAINTAINERS: Add all generic DW PCIe RP/EP DT-schemas MAINTAINERS: Demote Gustavo Pimentel to DW PCIe core reviewer MAINTAINERS: Add Manivannan to DW PCIe core maintainers list MAINTAINERS: Add myself as the DW PCIe core reviewer MAINTAINERS: Demote Gustavo Pimentel to DW EDMA driver reviewer MAINTAINERS: Add Manivannan to DW eDMA driver maintainers list MAINTAINERS: Add myself as the DW eDMA driver reviewer MAINTAINERS | 11 ++++-- drivers/pci/controller/dwc/pcie-bt1.c | 5 ++- .../pci/controller/dwc/pcie-designware-host.c | 2 +- drivers/pci/controller/dwc/pcie-designware.c | 2 - drivers/pci/controller/dwc/pcie-designware.h | 7 +++- drivers/pci/controller/dwc/pcie-visconti.c | 37 +++++++++---------- 6 files changed, 34 insertions(+), 30 deletions(-) -- 2.40.0