Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <20a75a02-e4ae-9467-49ff-5c3791bcf9b1@amd.com>
Date:   Fri, 14 Apr 2023 10:21:14 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Reply-To: nikunj@amd.com
Subject: Re: [PATCH v2 04/11] virt: sev-guest: Add simplified helper to assign
 vmpck
To:     Peter Gonda <pgonda@google.com>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org, bp@alien8.de,
        thomas.lendacky@amd.com, dionnaglaze@google.com, seanjc@google.com,
        pbonzini@redhat.com, michael.roth@amd.com, ketanch@iitk.ac.in
References: <20230326144701.3039598-1-nikunj@amd.com>
 <20230326144701.3039598-5-nikunj@amd.com>
 <CAMkAt6r4-8zwW8_JbTG6zK0DFG9PVX5Z50Xrq1C_fLBCdsrqdg@mail.gmail.com>
Content-Language: en-US
From:   "Nikunj A. Dadhania" <nikunj@amd.com>
In-Reply-To: <CAMkAt6r4-8zwW8_JbTG6zK0DFG9PVX5Z50Xrq1C_fLBCdsrqdg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a2VsRTg4Y3g0alV5MGNiZFhIakNJd3JtaXRSWUJUY2g4WUxlYTdMY1ZRMnBv?=
 =?utf-8?B?R1orb2tPZk1XVm53RGJPQkFNNVVDQ2toakV4alpTRFlDWUsxemtWVzBubkcw?=
 =?utf-8?B?NDMxWTJ2QTNWMzFxSDdjalJhbmpLNkpFdlFDSWJud29aOHhTemp4MGhrenhN?=
 =?utf-8?B?NTk4NVQzbDBBKzhTb0Jjai9USUdMcmQybGZubDZJdkVFQ2JkWnp5aEExb1lX?=
 =?utf-8?B?K3N1c0QyRFRXVzJDME91c2hjL0Nxb0xjSHZtZlNZYmdjVmFMZmlIZ083UGRG?=
 =?utf-8?B?c1BxZlpiOGw1UCtLTFd0KzFoemtyODNOUFV4NHJjKzdjWjg4ei9BTStnWjBJ?=
 =?utf-8?B?ODgrZUNKREFQOGlhR29vc3A3V1VrN2U5QURPMjF4UjlPQ0gyb0duRGVXMnRO?=
 =?utf-8?B?akhqRGRKSDJveS9yTFlFRHJNTkphM0RwbkFZQXRzYXhzS2J2L1BnVFdXSGNh?=
 =?utf-8?B?NkVuby9OZGVEalRNejZaTHVsU0xVbHdzZmZSNnI3M09FRzdKOC8rYXhkMEkz?=
 =?utf-8?B?ZUlSUWpWQmowQVJMM204bkJ3VnIrUmQ3NG9zdzVROVhxVlZDejR5TlFaMWdD?=
 =?utf-8?B?R2ViSHZ2VzZhSTVpcTc1Wi9la0YwR3loYllydmx0dmRjMmtOYkZFdGN2WXBE?=
 =?utf-8?B?QzEvMEo1YWNEQ1pZUzM4bXpDdTJrYW4yN0tIZ21yNnNXMkZLSm0xUzlVTVZl?=
 =?utf-8?B?VVN6ZkNoeEI1MWNoTitLdkZ3OU8vTmxDOSsvdmJSTUtBWXVIYUhJdTVEalZs?=
 =?utf-8?B?QW5BRlZWejlFOCtFNyszaFhxZ0lpSjFjRHdMUS9jZDRJMHRnbjFibmhGMXZY?=
 =?utf-8?B?dWJzT1RNNHdZaTRWQ0RjT0JDSk1EMCt6bEc4NllxWm40U1dUYUxRMGsybk4y?=
 =?utf-8?B?Y1NwWTc0V2c4emtVVHlONHVMc0dsYnY4Umk1SVJCalRqajJtUmZrZUNRbk4y?=
 =?utf-8?B?c2FYTWZWZ2JDWXJUVmd6dGt6a0ZmVlhWYmo1Q1NNU21KRU9xMkFKeWhLWFVU?=
 =?utf-8?B?ZXYra0JhSXc1SVJyOEdQV0hPRy9mQ28zWXY1SDFwRUpTWW0rMWNNcldjOVJO?=
 =?utf-8?B?eW9kSWFsZWlFRXpCUzZTaXNTQjA5eUVxSVpHT0pabVBkQ0hGMXlKY3R5eGtF?=
 =?utf-8?B?NGU5U2dXcE1HTGxadmFZcXZrdTdqK2FiQTRwMENXRTIzSDhyaE8wV1VHdFNq?=
 =?utf-8?B?MmhHdldSb0U2akdzQTk5RXFkTmwwQTQvSDdEK3BuUmdQdTMxMm43ejdWZmZU?=
 =?utf-8?B?TVRGN3IxVTdrajU5T1NWN0FUR3N6a25RTllaUDdiYmo4R2ZWSWFPczlzL3Q0?=
 =?utf-8?B?dlNyQ3NTc1hoemtKTWhReUtndUV0WVRBR0g1dDhSZGxHb24rOXZQQ1VlM1gw?=
 =?utf-8?B?ZVNva3pGbjh3T1JpMDIrTGErRFNic1hhWUZGMTUrYnhpb09rdCtpYmtGLzZI?=
 =?utf-8?B?TDVNd1JBNWxzMHJjTWo3S29GZm1tVWxabnhiekpxaTlkTzRuRHlUZklFVkpR?=
 =?utf-8?B?ekpHY1ZFNG5CUFhwU05KZmhTWGY4dFRucXhUTzFNcW5LYTR5ZlNuMWdYWDky?=
 =?utf-8?B?YWpRTzhjSzJkTW9aL1dUMW5FSHFxS3Q0eG9rZFY2Q2JZbWVETkhYNzE2MXov?=
 =?utf-8?B?NU4rdXd0d1BULzZWaWlnaEdSVUFWU1dPREVaR2g0NUJWd25wblpram1tSTVr?=
 =?utf-8?B?aE41RldkRWVwZW9KRnlSRlRpb0YrcmZTQUtUTEU1dUJnV3ZBZUNsM2YrUWNK?=
 =?utf-8?B?eHA0MEplQ2NjemVQbko3UE5CU1A5V080YVhUek0reTAxVW5ja0VXWFc3SnR5?=
 =?utf-8?B?ZE16TlUvMDg4MG9QaHdVMFUwZTlWMDUvUWZWVHRmWDVZS1c0a2VtL3M1Uzhr?=
 =?utf-8?B?SXkxdjdacDVSUmIwRjE3N1Z1RURsWk9xU1NFdlZHelZCRldTa3kwYVpCbGdP?=
 =?utf-8?B?aVlaVGxMZjdyN2c3eFJjdVNaTk9UekluVWE2WWNIeHl3SUtCQ3JWb0VLTUlT?=
 =?utf-8?B?YVBJSXZKYTdzQjNzZ2dIc3UzSmo5a2FqZGJTZWpQaWc1NXNqUEFraXE5cDR0?=
 =?utf-8?B?VTQ2cGpxK05RY05Lck5idHZ1dC9yNEJsZ0VBUStqd1g4d2ExaitwaC9tbnNN?=
 =?utf-8?Q?Gxqhg887M4Yhooh1dlj5y/y6N?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0887eaf0-f3b7-43b1-8675-08db3ca3e889
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6309.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 04:51:28.5945
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hvY56O61XkKzYypQwSFG1IgeVqxT+0zY9RWdLs+pvb18D4GHo7vRoUatNbFy+A5K875HhI6/1PB9bw93bGEiIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6007
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/10/2023 10:01 PM, Peter Gonda wrote:
>>
>> -static u8 *get_vmpck(int id, struct snp_secrets_page_layout *layout, u32 **seqno)
>> +bool snp_assign_vmpck(struct snp_guest_dev *dev, int vmpck_id)
>>  {
>> -       u8 *key = NULL;
>> +       if (WARN_ON(vmpck_id > 3))
>> +               return false;
> 
> Should vmpck_id be a uint to match the module parameter or should we
> check if vmpck_id < 0 ?

Thanks for pointing that out, I will make vmpck_id as a uint.

Regards
Nikunj