Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Apr 2023 09:29:59 +0200
From:   Marijn Suijten <marijn.suijten@somainline.org>
To:     Konrad Dybcio <konrad.dybcio@linaro.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Konrad Dybcio <konrad.dybcio@somainline.org>
Subject: Re: [PATCH v2 4/4] arm64: dts: qcom: sm8150-kumano: Enable SDHCI2
Message-ID: <2uinewxwwuodo2ikqt7mevtqzkcxo7kwcyey65sx2jjmitsnuy@w5wuvon4qfhi>
References: <20230315-topic-kumano_dts0-v2-0-0ca7fa521b86@linaro.org>
 <20230315-topic-kumano_dts0-v2-4-0ca7fa521b86@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230315-topic-kumano_dts0-v2-4-0ca7fa521b86@linaro.org>
Precedence: bulk

On 2023-04-11 20:14:44, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@somainline.org>
> 
> Set up and enable SDHCI2 to enable the microSD slot on Kumano
> devices.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Thanks for finally sending this and fixing the no-emmc -> no-emmc
property, I've been testing/using this out-of-tree patch for too long:

Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>

> ---
>  arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi b/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi
> index ad402f3a90c3..baafea53770b 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi
> @@ -618,6 +618,17 @@ &qupv3_id_1 {
>  	status = "okay";
>  };
>  
> +&sdhc_2 {
> +	vmmc-supply = <&vreg_l9c_2p9>;
> +	vqmmc-supply = <&vreg_l6c_2p9>;
> +	cd-gpios = <&tlmm 96 GPIO_ACTIVE_HIGH>;
> +	bus-width = <4>;
> +	no-sdio;
> +	no-mmc;
> +
> +	status = "okay";
> +};
> +
>  &tlmm {
>  	gpio-reserved-ranges = <126 4>;
>  	gpio-line-names = "NFC_ESE_SPI_MISO", /* GPIO_0 */
> 
> -- 
> 2.40.0
>