Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7eabae11-6a65-c51d-ff39-8205057e497a@sangfor.com.cn>
Date:   Fri, 14 Apr 2023 15:55:05 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH v11 1/8] function_graph: Support recording and printing
 the return value of function
Content-Language: en-US
From:   Donglin Peng <pengdonglin@sangfor.com.cn>
To:     mhiramat@kernel.org, rostedt@goodmis.org
Cc:     huangcun@sangfor.com.cn, dinghui@sangfor.com.cn,
        catalin.marinas@arm.com, mark.rutland@arm.com,
        paul.walmsley@sifive.com, palmer@dabbelt.com, bp@alien8.de,
        tglx@linutronix.de, aou@eecs.berkeley.edu,
        rmk+kernel@armlinux.org.uk, linux@armlinux.org.uk, will@kernel.org,
        peterz@infradead.org, mingo@redhat.com, zhangqing@loongson.cn,
        chenhuacai@kernel.org, kernel@xen0n.name, dolinux.peng@gmail.com,
        x86@kernel.org, linux-trace-kernel@vger.kernel.org,
        loongarch@lists.linux.dev, linux-riscv@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Florian Kauer <florian.kauer@linutronix.de>,
        dave.hansen@linux.intel.com, hpa@zytor.com, xiehuan09@gmail.com
References: <cover.1680954589.git.pengdonglin@sangfor.com.cn>
 <1fc502712c981e0e6742185ba242992170ac9da8.1680954589.git.pengdonglin@sangfor.com.cn>
 <66fe9288-05ff-1bf3-dd40-e7b3cbdf1af9@sangfor.com.cn>
In-Reply-To: <66fe9288-05ff-1bf3-dd40-e7b3cbdf1af9@sangfor.com.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/4/14 15:44, Donglin Peng wrote:
> On 2023/4/8 20:42, Donglin Peng wrote:
>> Analyzing system call failures with the function_graph tracer can be a
>> time-consuming process, particularly when locating the kernel function
>> that first returns an error in the trace logs. This change aims to
>> simplify the process by recording the function return value to the
>> 'retval' member of 'ftrace_graph_ent' and printing it when outputting
> 
> There is a mistake, the retval member is added to ftrace_graph_ret.

Hi Steve, could you please correct this mistake before merging it into
linux-next?

> 
>> the trace log.
>>