Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: ifd894703:Fastmail
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\))
Subject: Re: [PATCH] Mips: Fix _CONST64_(x) as unsigned
From:   Jiaxun Yang <jiaxun.yang@flygoat.com>
In-Reply-To: <20230411063144.3119-1-zhangqing@loongson.cn>
Date:   Fri, 14 Apr 2023 09:13:21 +0100
Cc:     Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
        linux-kernel@vger.kernel.org, Huacai Chen <chenhuacai@kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <3A77E6D2-2BFD-4728-B33F-4EEFD0BB07BD@flygoat.com>
References: <20230411063144.3119-1-zhangqing@loongson.cn>
To:     Qing Zhang <zhangqing@loongson.cn>
Precedence: bulk


> 2023=E5=B9=B44=E6=9C=8811=E6=97=A5 07:31=EF=BC=8CQing Zhang =
<zhangqing@loongson.cn> =E5=86=99=E9=81=93=EF=BC=9A
>=20
> Addresses should all be of unsigned type to avoid unnecessary =
conversions.

It=E2=80=99s defined as signed for a reason. To keep consistent with =
32-bit address, which
Is sign-extended on 64bit systems.

Thanks
Jiaxun

>=20
> Signed-off-by: Qing Zhang <zhangqing@loongson.cn>
> ---
> arch/mips/include/asm/addrspace.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/arch/mips/include/asm/addrspace.h =
b/arch/mips/include/asm/addrspace.h
> index 59a48c60a065..75d36115a25e 100644
> --- a/arch/mips/include/asm/addrspace.h
> +++ b/arch/mips/include/asm/addrspace.h
> @@ -25,9 +25,9 @@
> #define _ATYPE32_ int
> #define _ATYPE64_ __s64
> #ifdef CONFIG_64BIT
> -#define _CONST64_(x) x ## L
> +#define _CONST64_(x) x ## UL
> #else
> -#define _CONST64_(x) x ## LL
> +#define _CONST64_(x) x ## ULL
> #endif
> #endif
>=20
> --=20
> 2.20.1
>=20