Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Apr 2023 16:22:36 +0800
From:   Yujie Liu <yujie.liu@intel.com>
To:     Christoph Hellwig <hch@lst.de>
CC:     <oe-lkp@lists.linux.dev>, <lkp@intel.com>,
        <linux-kernel@vger.kernel.org>, David Sterba <dsterba@suse.com>,
        Johannes Thumshirn <johannes.thumshirn@wdc.com>,
        Anand Jain <anand.jain@oracle.com>,
        <linux-btrfs@vger.kernel.org>, <ying.huang@intel.com>,
        <feng.tang@intel.com>, <fengwei.yin@intel.com>
Subject: Re: [linus:master] [btrfs] 4ae2edf12d: fio.write_iops -11.9%
 regression
Message-ID: <ZDkNTJfu83DrecW1@yujie-X299>
References: <202304140917.9e9f5c1-yujie.liu@intel.com>
 <20230414052458.GA11616@lst.de>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230414052458.GA11616@lst.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WdHFT8g/eNItamRT8gCPOibbNdMLqjRvofhvXYMvx48RhajKNJkYMwut5zAG?=
 =?us-ascii?Q?Dq36ya6yyeD6zTgO5/feio9AgDSuEpUdCauRuSkIuPlKxX0V8j0xNHjAln3/?=
 =?us-ascii?Q?9HWggmAQi1cFGHuXSsLsoc3CSME4gWeff5FaYezWTC+EET7gJR8MrMRV6gRP?=
 =?us-ascii?Q?yd9vhuu6Ac1zgjdQ30kHB4bTHpImj1y936mfapPkO+UPzMDMq2aliRi+S0ij?=
 =?us-ascii?Q?p+/K99cr35ffNeE/3Oj/Lp2m06oY9ttvy+c52gJwJ56DtwQI0C7acwocVf7G?=
 =?us-ascii?Q?21CAwT1F+455y/RIm+tx6Vlnd6a9cAjGnGyTWaD1cACucKwRkn2jhUAG4/TF?=
 =?us-ascii?Q?5ApZhHom18iAti+apJR3ry9yRPbqAttu1+iUbaF73CwzdkVOPx8LvEJ4Bxb2?=
 =?us-ascii?Q?ZwL3fmk0URmuH5W20Gc5aXw7UOD9hP7v+XzwS9SNqQjILNaF5leuQ5XJX9Rb?=
 =?us-ascii?Q?87mgU/35PGZ2cCd6rGKelmLB1uYsA+YmIrCK1B8VWFTbuPSfcSBevYbVCKDN?=
 =?us-ascii?Q?KqgDRQXakd5YS/HCobUKqeERKw0jV8fKloXHqxtF4l1wUeuIjM3u57JLnpgZ?=
 =?us-ascii?Q?tlHfrfMcNyvRVu0PyZkMter6UQRJxbqx6FnZdw3bN2ztpOzwMxkILCsGtupE?=
 =?us-ascii?Q?DWXOofrOUK7lrR1pFtlTk71bcd8vv+Yw57PpXdbnyHFNjwkjlsIc8Ajf09S9?=
 =?us-ascii?Q?end+mxaid2rl1mnDdllx+r+mlESmjrX2Mh9iy2hxoQYAq+PCdXOu8qFNLUNw?=
 =?us-ascii?Q?M9bPltFloX8tt8R3RhZM0q6oUiFuJapw4+/gBA73Zh4WPxUf2G6m+bPsOUlV?=
 =?us-ascii?Q?zrYklJ04/0ywU+js7verzcFiVJIs1Jik66qfFFycFlWR24HcK0nZyaUy6DcP?=
 =?us-ascii?Q?rwvwoOCBbqOH4eAl7eCwtRGIhFxrH1mPJ355/4Si76Uj+noIykC9RljE4IXC?=
 =?us-ascii?Q?zWMu/rqXXzwnEO5LmfYdT/IxaKVW5xqeZz80YCSxVDaAfqWpG1BWbnTjH1Jt?=
 =?us-ascii?Q?Otc6mulqCBlZUsJdHRYTawT13n5D3uslrKE7ddpw6xGYlZEohEuxYKK6/fFf?=
 =?us-ascii?Q?38eSHL4K40gv7BfNhmHVYqdN6lbZI1pHTncjv8hou4r4KI+CJLpKi7H+hpwe?=
 =?us-ascii?Q?2ipVeulKHl06BvtEMkBPJQou6WyQCbKsAOijt4IA9OYOQ2fiifKpw6REirV/?=
 =?us-ascii?Q?8v/cdPPs++ntnsEevkjfFDFNI8zN8EWEfSNogj9y2E+ZPmkVWoOG8Nx66zMJ?=
 =?us-ascii?Q?REwt65m+7nWpqiSUr/EkD0WBM+xK1YQTr+XXXyiLfTGw0im1mIfPJyqu77q5?=
 =?us-ascii?Q?vj21HvSbj3Bs7gUNJkAXVMvdlyszWSMsaBmNyu9VoLr6EvWZAKcIwCoxge9w?=
 =?us-ascii?Q?SFY+RdDrzDrZpx18j1w5WfY9sJ+F7ul7J7kPrDhyT8O5Y/rT/dzyIUeHhPeT?=
 =?us-ascii?Q?HWazNz3VEpztr1C20eqlqPoMCrByje1/7fqt6oaTLgHWU7Qx7QRp9Ljnzdwz?=
 =?us-ascii?Q?UPvptXfPXXKB5icGjOxnejEYMcEsmr9Dyhw3YrvMTapNwm6waP3obgYTh5ND?=
 =?us-ascii?Q?IhMhLojrLZF7pstWCoHKiR1oRILN7sC4Rw39o0d1?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d6a02bd-cc70-40df-8776-08db3cc1d832
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6392.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 08:25:45.9711
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QKZrS64CEp4jxKgK3XCZPLeWerdBiehHbQae2NmYLeisNviXe4T3+vwG3gtTwhIrEiMWIJnhKii3su0XJ/d06w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5392
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Apr 14, 2023 at 07:24:58AM +0200, Christoph Hellwig wrote:
> On Fri, Apr 14, 2023 at 10:01:51AM +0800, kernel test robot wrote:
> > Hello,
> > 
> > kernel test robot noticed a -11.9% regression of fio.write_iops on:
> > 
> > commit: 4ae2edf12d49fdbaea2dfda0bb2ec06501bd3493 ("btrfs: simplify parameters of btrfs_lookup_bio_sums")
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> 
> Can you revalidate this?  The patch is purely a parameter passing
> cleanup, so a large reduction in IOPS looks very suspicious.

Sorry this is a false positive report.

The environment was inconsistent when testing this commit and its
parent. We've revalidated under same environment and confirmed there is
no regression:

=========================================================================================
bs/compiler/cpufreq_governor/direct/disk/fs/ioengine/kconfig/nr_task/rootfs/runtime/rw/tbox_group/test_size/testcase:
  4k/gcc-11/performance/direct/1HDD/btrfs/io_uring/x86_64-rhel-8.3/100%/debian-11.1-x86_64-20220510.cgz/300s/write/lkp-icl-2sp1/128G/fio-basic

commit:
  5fa356531e33e ("btrfs: remove the direct I/O read checksum lookup optimization")
  4ae2edf12d49f ("btrfs: simplify parameters of btrfs_lookup_bio_sums")

5fa356531e33e7c7 4ae2edf12d49fdbaea2dfda0bb2
---------------- ---------------------------
         %stddev     %change         %stddev
             \          |                \
      9370            -0.7%       9309        fio.write_iops


Sorry again for the inconvenience. We will improve our workflow to
reduce false positives.

--
Best Regards,
Yujie