Date: Wed, 26 Sep 2007 19:32:33 +0200
From: Guillaume Chazarain <guichaz@yahoo.fr>
To: balbir@linux.vnet.ibm.com
Cc: Guillaume Chazarain <guichaz@yahoo.fr>,
       Andrew Morton <akpm@linux-foundation.org>,
       Oleg Nesterov <oleg@tv-sign.ru>, Jonathan Lim <jlim@sgi.com>,
       Jay Lan <jlan@cthulhu.engr.sgi.com>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] taskstats: separate PID/TGID stats producers to
 complete the TGID ones
Message-ID: <20070926193233.50f7a26a@localhost.localdomain>
In-Reply-To: <46F559A5.5060900@linux.vnet.ibm.com>
References: <20070921233038.21607.51089.stgit@localhost.localdomain>
	<46F559A5.5060900@linux.vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1135
Lines: 33

Le Sat, 22 Sep 2007 23:36:29 +0530,
Balbir Singh <balbir@linux.vnet.ibm.com> a écrit :

[reordered]

> How about calling this one fill_threadgroup_stats()?
> How about we call function add_tsk_stats()?
> I still prefer braces around do <--> while, I think the code is easier
> to read with them.
> Could we further split the tsacct and delayacct/taskstats patches.

Hi Balbir,

Thank for your review, hopefully I addressed all your items in this
series.

> So we always call fill_threadgroup later, is there a reason for
> that. Can the order of calls be arbitrary or is there a dependency?

Yes, as you saw there is this dependency, it is needed only for
[PATCH 7/8] taskstats: fix stats->ac_exitcode to work on threads and use group_exit_code
but I found it simpler to put the calls in the right order from the
beginning.

Thanks again, and sorry for the double mail bomb.

-- 
Guillaume
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/