Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Apr 2023 12:40:35 +0300
From:   Tony Lindgren <tony@atomide.com>
To:     Ilpo =?utf-8?B?SsOkcnZpbmVu?= <ilpo.jarvinen@linux.intel.com>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        Johan Hovold <johan@kernel.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-omap@vger.kernel.org,
        linux-serial <linux-serial@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] serial: 8250: Clear port->pm on port specific driver
 unbind
Message-ID: <20230414094035.GF36234@atomide.com>
References: <20230413070342.36155-1-tony@atomide.com>
 <ZDgoi2mFYYqswAhu@smile.fi.intel.com>
 <20230414054726.GE36234@atomide.com>
 <63b333cb-13c7-db58-9cf-697aa1c4c48a@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <63b333cb-13c7-db58-9cf-697aa1c4c48a@linux.intel.com>
Precedence: bulk

* Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> [230414 07:36]:
> On Fri, 14 Apr 2023, Tony Lindgren wrote:
> 
> > * Andy Shevchenko <andriy.shevchenko@linux.intel.com> [230413 16:06]:
> > > On Thu, Apr 13, 2023 at 10:03:41AM +0300, Tony Lindgren wrote:
> > > > Let's fix the issue by clearing port->pm in serial8250_unregister_port().
> > > 
> > > Sounds to me like a fix that needs a Fixes tag.
> > 
> > Maybe commit c161afe9759d ("8250: allow platforms to override PM hook.").
> > 
> > That's a bit unclear though as the hardware specific functions were
> > available at that point as they were passed in platform data. This can
> > be seen with git blame c161afe9759d drivers/serial/8250.c. To me it seems
> > the port->pm became potentially invalid if a serial port device driver
> > started implementing PM runtime?
> > 
> > Maybe just tagging it with Cc: stable is better if no obvious Fixes tag
> > can be figured out.
> 
> I'd just put that c161afe9759d there. It seems quite harmless even if it 
> would be unnecessary before some driver commit which is much harder to 
> pinpoint (and it would likely turn out old enough to not matter anyway 
> for the kernels stable cares about).

OK works for me.

I'm now wondering still if we should clear all the conditional hardware
specific functions too in addition to port->pm that get set in
serial8250_register_8250_port(). Maybe best done in a separate patch
as needed.. Any suggestions?

> I forgot to give this earlier:
> 
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Thanks,

Tony