Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230414084619.31524-1-johan+linaro@kernel.org>
In-Reply-To: <20230414084619.31524-1-johan+linaro@kernel.org>
From:   Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Date:   Fri, 14 Apr 2023 12:36:48 +0300
Message-ID: <CAA8EJppa6OUqaiN61mDr_xSEsAqJtLHGvwuwBDcWYaeLEwkVYQ@mail.gmail.com>
Subject: Re: [PATCH RESEND v2] firmware/psci: demote suspend-mode warning to
 info level
To:     Johan Hovold <johan+linaro@kernel.org>
Cc:     Mark Rutland <mark.rutland@arm.com>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Sudeep Holla <sudeep.holla@arm.com>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Arnd Bergmann <arnd@arndb.de>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 14 Apr 2023 at 11:47, Johan Hovold <johan+linaro@kernel.org> wrote:
>
> On some Qualcomm platforms, like SC8280XP, the attempt to set PC mode
> during boot fails with PSCI_RET_DENIED and since commit 998fcd001feb
> ("firmware/psci: Print a warning if PSCI doesn't accept PC mode") this
> is now logged at warning level:
>
>         psci: failed to set PC mode: -3
>
> As there is nothing users can do about the firmware behaving this way,
> demote the warning to info level and clearly mark it as a firmware bug:
>
>         psci: [Firmware Bug]: failed to set PC mode: -3
>
> Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
> Acked-by: Sudeep Holla <sudeep.holla@arm.com>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---

For the sake of completeness:
Acked-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

>
> This one fell between the cracks so resending with tags added.
>
> Mark or Lorenzo, is this something you can pick up?
>
> Johan
>


-- 
With best wishes
Dmitry