Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Apr 2023 11:39:17 +0200
Message-ID: <875y9yn6pm.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     ReaperLi <ReaperLi@glenfly.com>
Cc:     <perex@perex.cz>, <tiwai@suse.com>, <linux-kernel@vger.kernel.org>,
        jasontao <jasontao@glenfly.com>
Subject: Re: [PATCH] ALSA: hda: Glenfly: add HD Audio PCI IDs and HDMI Codec Vendor IDs.
In-Reply-To: <20230414085055.27323-1-ReaperLi@glenfly.com>
References: <20230414085055.27323-1-ReaperLi@glenfly.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 14 Apr 2023 10:50:55 +0200,
ReaperLi wrote:
> 
> From: jasontao <jasontao@glenfly.com>
> 
> Add a set of HD Audio PCI IDS, and the HDMI codec vendor IDs for
> Glenfly Arise.
> 
> Signed-off-by: jasontao <jasontao@glenfly.com>

Your Signed-off-by tag seems missing.  The person who submitted the
patch must give the own Signed-off-by tag.  That's a legal
requirement.

Moreover, the patch doesn't seem applicable with git-am.  Please fix
your mailer setup to stop mangling tabs with spaces.
At best, use git-send-email for submission.

If anything else can't work, use a mail attachment as a last resort.

The code change itself looks good to me.  Please resubmit for the
above points.


thanks,

Takashi