Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Kubalewski, Arkadiusz" <arkadiusz.kubalewski@intel.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "jiri@resnulli.us" <jiri@resnulli.us>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>
Subject: RE: [RFC PATCH v1] ice: add CGU info to devlink info callback
Thread-Topic: [RFC PATCH v1] ice: add CGU info to devlink info callback
Thread-Index: AQHZbURL//7N1kf7H06LoNzMTKXBn68ol1EAgACoMpCAABhVgIABPbbA
Date:   Fri, 14 Apr 2023 10:04:05 +0000
Message-ID: <DM6PR11MB4657EF2201A5E110697C9E129B999@DM6PR11MB4657.namprd11.prod.outlook.com>
References: <20230412133811.2518336-1-arkadiusz.kubalewski@intel.com>
        <20230412203500.36fb7c36@kernel.org>
        <DM6PR11MB46577E14FE17ADA6D1E74E789B989@DM6PR11MB4657.namprd11.prod.outlook.com>
 <20230413080405.30bbe3bd@kernel.org>
In-Reply-To: <20230413080405.30bbe3bd@kernel.org>
Accept-Language: pl-PL, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0OiKSa9hnQEEXhaF/Ke+X8y3hGBTQBzL1DQ8m4ZdaP8iR7Jwjar5BoI6nkZd?=
 =?us-ascii?Q?uSgFOnONJ98DzLgCzDWgfM8jUr+/iq011FZcYgKnR3s2JLjsUCQOgOcLiGtY?=
 =?us-ascii?Q?XZJuNxIKf4QVl2s4b6Ssw4Dxx391kVdzM0mzc5pkVUqtlQxL/iK/ab8rDvws?=
 =?us-ascii?Q?Ne+6D92UZh0cfyKA5kL7N8Ps6WHD4VmxVee8hnAqqcLFe6sRN7NhKlBBYapr?=
 =?us-ascii?Q?zdNZHAB08pRvpWH2N12UzDG1fO833l+Sb0RmlJ7toGcUNOZv7hCvmIz+wn8K?=
 =?us-ascii?Q?kNtGlhNXUgeruaAXOItg5a4moX76WGz0x2YmGQ0XQ0fZkGblhJThBqEtr+JH?=
 =?us-ascii?Q?zKVGc5VNvZ2A+vvL3CALpRXaki6Ta40eEQPPo0MGNoa3apu/8y6Z1g/joQgK?=
 =?us-ascii?Q?Chs8LG7BDID1H67Giok6ACt3W4of0m36eg9CFeWSzYAItSifmxRpbn+oiu22?=
 =?us-ascii?Q?eKLqV1RYrQgKEZkLW5s8hw55SGHzWVvO3yiUH5B+WWVtyvfVf5oe157nHLVi?=
 =?us-ascii?Q?ujiTyjCPZcsru1qaGMNWY+6gIvA64bfswWiXAz7ta6KvdSjdF94wur4vhuYH?=
 =?us-ascii?Q?BSK1aCYIgfAXncswGCDySGyppTPtlpgq/pY2Z+k0ztWQIYzNy2NeFJKR3Ay5?=
 =?us-ascii?Q?q720d8rm3lw5hXpyrsLq4UyM23jA0oNs+z+JcX9yXJ7oJXSQ7fvX9YadTxE9?=
 =?us-ascii?Q?mUgYP5epnsEZFfFiEllZJj+2qtN3g2keMtBzUYuuL3zJu1iR22tfaumL4+Q1?=
 =?us-ascii?Q?WbAcEgy3VCGUSo8Ny7Ol+QP3D+7sgMwl+CaBVhu7uuR9Wtax+KhanYC2okBk?=
 =?us-ascii?Q?u1Vki/BlqvUjPJldb3Am2zVzrIg2EqSG1nYQZEWilvdSIvk01mSNGvnJf2Fv?=
 =?us-ascii?Q?wG7ZGQnLJr7Msfk7eHIYNQb0mv00+JTxGftmCIkibwkfE9VvaUv7KSVe0KMW?=
 =?us-ascii?Q?tmp7OaM1K3cF5rKfzGDUi4m/LgRQdSc0UpxX9GSltMBpZN5bgeA8VaeiPIHP?=
 =?us-ascii?Q?PofbPQn43uBa0FAGniAs+p8Ll1K6fOzVhaXGod3dc5XXsl8jkkvPmmayia0k?=
 =?us-ascii?Q?tu4wZC2GQxN/BaI+9J3r7+XYhQbY+cY/FjRR0KYo2MDRYQqEVpv7+283Phsj?=
 =?us-ascii?Q?iPt78GkWkNPiHWRkajDxf+Rg0iRm5t6KWK6lvejP/VabF1fdCNaTKmEPhmej?=
 =?us-ascii?Q?HwHL15cn4MwFJssfpYanyJu3+I+rVJSRAePLhAxW5gajYnQ7ZDdUNyPErqAq?=
 =?us-ascii?Q?AgUHI4WjH0sQQ6h5krNg4o8js2Vm723LS1BZa0h+KBCQtVsCGeVeQ7bFmeX+?=
 =?us-ascii?Q?o0koW/EenT4cAJVuyVY81NEariuq9a3tZVSrDMN8x1FvIXuepAK8Zn+76bz5?=
 =?us-ascii?Q?ejSNn5dhZnqGOjwaORh40vngJKhqxDpX+5qg7wlN4U0CzW/5L2FfBD3vAJ9D?=
 =?us-ascii?Q?PLjm0B0O7BDiFKJe+YxY4yhU+fXbTvABaTWCJwMN2LLmlNc1YJQ/gAlK82y4?=
 =?us-ascii?Q?Y5vBodfqIdhK3oQb9qtB9A7s3vLk85k70CbHtnyoMrLn/DG1QxSqJ8INvXOY?=
 =?us-ascii?Q?7mVGGCd9rkdB8joJHmkfqxuyITATgJQIk1F7L2I+CZwB5pnigyQWlXIyxnRl?=
 =?us-ascii?Q?7Q=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4657.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d397050-d098-46da-71ea-08db3ccf94dc
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2023 10:04:05.6182
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AdX4zIre5ssUud1UXmRIFgs8tMUQJmleq1CjtbjGjynB0ZT6g1MuhyB6C0A++tb6OzKtUhuQWz5M0voRMyBYlLfaql1i3sANpAe8w1XfPIc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6687
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>From: Jakub Kicinski <kuba@kernel.org>
>Sent: Thursday, April 13, 2023 5:04 PM
>
>On Thu, 13 Apr 2023 13:43:52 +0000 Kubalewski, Arkadiusz wrote:
>> >Is it flashed together with the rest of the FW components of the NIC?
>> >Or the update method is different?
>>
>> Right now there is no mechanics for CGU firmware update at all, this is =
why I
>> mention that this is for now mostly for debugging purposes.
>> There are already some works ongoing to have CGU FW update possible, fir=
st
>>with
>> Intel's nvmupdate packages and tools. But, for Linux we probably also go=
nna
>> need to support update through devlink, at least this seems right thing =
to
>>do,
>> as there is already possibility to update NIC firmware with devlink.
>
>Only FW versions which are updated with a single flashing operation /
>are part of a single FW image should be reported under the device
>instance. If the flash is separate you need to create a separate
>devlink (sub)instance or something along those lines.
>
>Differently put - the components in the API are components of the FW
>image, not components of a board.
>
>We had a similar discussion about "line cards" before.

Well, this makes sense.

Although I double checked, and it seems I wasn't clear on previous explanat=
ion.
Once FW update is possible with Intel's nvmupdate tools, the devlink FW upd=
ate
also going to update CGU firmware (part of nvm-flash region), so after all =
this
seems a right place for this info.

Thanks,
Arkadiusz