Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: ie3994620:Fastmail
Date:   Fri, 14 Apr 2023 13:19:01 +0300
From:   "Kirill A. Shutemov" <kirill@shutemov.name>
To:     Vlastimil Babka <vbabka@suse.cz>
Cc:     "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Borislav Petkov <bp@alien8.de>,
        Andy Lutomirski <luto@kernel.org>,
        Sean Christopherson <seanjc@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Joerg Roedel <jroedel@suse.de>,
        Ard Biesheuvel <ardb@kernel.org>,
        Andi Kleen <ak@linux.intel.com>,
        Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        David Rientjes <rientjes@google.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Ingo Molnar <mingo@redhat.com>,
        Dario Faggioli <dfaggioli@suse.com>,
        Dave Hansen <dave.hansen@intel.com>,
        Mike Rapoport <rppt@kernel.org>,
        David Hildenbrand <david@redhat.com>,
        Mel Gorman <mgorman@techsingularity.net>,
        marcelo.cerri@canonical.com, tim.gardner@canonical.com,
        khalid.elmously@canonical.com, philip.cox@canonical.com,
        aarcange@redhat.com, peterx@redhat.com, x86@kernel.org,
        linux-mm@kvack.org, linux-coco@lists.linux.dev,
        linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv9 03/14] mm/page_alloc: Fake unaccepted memory
Message-ID: <20230414101901.j3zoji6vmjzpjiec@box>
References: <20230330114956.20342-1-kirill.shutemov@linux.intel.com>
 <20230330114956.20342-4-kirill.shutemov@linux.intel.com>
 <835dfe65-d9dd-0b16-37d4-920e97f1bca0@suse.cz>
 <20230403143915.uc4tnpgmssvpdqxu@box.shutemov.name>
 <20230403155011.aodnd5ratcyeie52@box.shutemov.name>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230403155011.aodnd5ratcyeie52@box.shutemov.name>
Precedence: bulk

On Mon, Apr 03, 2023 at 06:50:11PM +0300, Kirill A. Shutemov wrote:
> On Mon, Apr 03, 2023 at 05:39:15PM +0300, Kirill A. Shutemov wrote:
> > On Mon, Apr 03, 2023 at 03:39:53PM +0200, Vlastimil Babka wrote:
> > > On 3/30/23 13:49, Kirill A. Shutemov wrote:
> > > > For testing purposes, it is useful to fake unaccepted memory in the
> > > > system. It helps to understand unaccepted memory overhead to the page
> > > > allocator.
> > > 
> > > Ack on being useful for testing, but the question is if we want to also
> > > merge this patch into mainline as it is?
> > 
> > I don't insist on getting it upstream, but it can be handy to debug
> > related bugs in the future.
> > 
> > > > The patch allows to treat memory above the specified physical memory
> > > > address as unaccepted.
> > > > 
> > > > The change only fakes unaccepted memory for page allocator. Memblock is
> > > > not affected.
> > > > 
> > > > It also assumes that arch-provided accept_memory() on already accepted
> > > > memory is a nop.
> > > 
> > > I guess to be in mainline it would have to at least gracefully handle the
> > > case of accept_memory actually not being a nop, and running on a system with
> > > actual unaccepted memory (probably by ignoring the parameter in such case).
> > > Then also the parameter would have to be documented.
> > 
> > As it is written now, accept_memory() is nop on system with real
> > unaccepted memory if the memory is already accepted. Arch-specific code
> > will check against own records to see if the memory needs accepting. If
> > not, just return.
> > 
> > And the option will not interfere with unaccepted memory declared by EFI
> > memmap. It can extend it, but that's it.
> > 
> > Looks safe to me.
> > 
> > > Speaking of documented parameters, I found at least two that seem a more
> > > generic variant of this (but I didn't look closely if that makes sense):
> > > 
> > > efi_fake_mem=   nn[KMG]@ss[KMG]:aa[,nn[KMG]@ss[KMG]:aa,..] [EFI; X86]
> > >     Add arbitrary attribute to specific memory range by
> > >     updating original EFI memory map.
> 
> As of now, efi_fake_mem= can adjust attributes of memory. Unaccepted is
> type of memory, not an attribute. I guess we can allow it override type
> too. But syntax is going to be fun.

efi_fake_mem applied too late. Bitmap that represents unaccepted memory
for kernel created at kernel decompression stage, but efi_fake_mem=
handled in main kernel.

I don't think pushing efi_fake_mem to decompressor makes sesne. I would
rather drom the feature altogether.

-- 
  Kiryl Shutsemau / Kirill A. Shutemov