Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7493c173-6693-f4d2-f658-196aa90a8db6@linaro.org>
Date:   Fri, 14 Apr 2023 13:10:08 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH 2/2] clk: qcom: Introduce SM8350 VIDEOCC
Content-Language: en-US
To:     Bjorn Andersson <andersson@kernel.org>
Cc:     Andy Gross <agross@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Taniya Das <tdas@codeaurora.org>,
        Marijn Suijten <marijn.suijten@somainline.org>,
        linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230413-topic-lahaina_vidcc-v1-0-134f9b22a5b3@linaro.org>
 <20230413-topic-lahaina_vidcc-v1-2-134f9b22a5b3@linaro.org>
 <20230414032726.ppssnbensuzcrjrm@ripper>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <20230414032726.ppssnbensuzcrjrm@ripper>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 14.04.2023 05:27, Bjorn Andersson wrote:
> On Thu, Apr 13, 2023 at 08:44:59PM +0200, Konrad Dybcio wrote:
>> diff --git a/drivers/clk/qcom/videocc-sm8350.c b/drivers/clk/qcom/videocc-sm8350.c
> [..]
>> +static struct clk_alpha_pll video_pll0 = {
>> +	.offset = 0x42c,
>> +	.vco_table = lucid_5lpe_vco,
>> +	.num_vco = ARRAY_SIZE(lucid_5lpe_vco),
>> +	.regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_LUCID],
>> +	.clkr = {
>> +		.hw.init = &(struct clk_init_data){
> 
> I know it's tiny, but please add a <space> between ) and { of these.
Sure!

> 
>> +			.name = "video_pll0",
>> +			.parent_data = &(const struct clk_parent_data){
>> +				.index = DT_BI_TCXO,
>> +			},
>> +			.num_parents = 1,
>> +			.ops = &clk_alpha_pll_lucid_5lpe_ops,
>> +		},
>> +	},
>> +};
> [..]
>> +
>> +static int __init video_cc_sm8350_init(void)
>> +{
>> +	return platform_driver_register(&video_cc_sm8350_driver);
>> +}
>> +subsys_initcall(video_cc_sm8350_init);
> 
> You don't need this at subsys_initcall(), please use
> module_platform_driver().
Right, we don't need to decode console boot logs..

Konrad
> 
> Thanks,
> Bjorn