Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Apr 2023 13:14:04 +0200
From:   Jan Kara <jack@suse.cz>
To:     Yangtao Li <frank.li@vivo.com>
Cc:     Jan Kara <jack@suse.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] quota: mark PRINT_QUOTA_WARNING as BROKEN
Message-ID: <20230414111404.cohbcdy6nmgigaga@quack3>
References: <20230413163833.43913-1-frank.li@vivo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230413163833.43913-1-frank.li@vivo.com>
Precedence: bulk

On Fri 14-04-23 00:38:32, Yangtao Li wrote:
> User should use notification via netlink socket. PRINT_QUOTA_WARNING is
> deprecated since commit 8e8934695dfd ("quota: send messages
> via netlink"), so mark it as BROKEN.
> 
> Signed-off-by: Yangtao Li <frank.li@vivo.com>

Thanks. I've merged the patch (with somewhat updated changelog) to my tree.

								Honza

> ---
>  fs/quota/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/quota/Kconfig b/fs/quota/Kconfig
> index d5a85a8062d0..10e9a0efc6c2 100644
> --- a/fs/quota/Kconfig
> +++ b/fs/quota/Kconfig
> @@ -28,7 +28,7 @@ config QUOTA_NETLINK_INTERFACE
>  
>  config PRINT_QUOTA_WARNING
>  	bool "Print quota warnings to console (OBSOLETE)"
> -	depends on QUOTA
> +	depends on QUOTA && BROKEN
>  	default y
>  	help
>  	  If you say Y here, quota warnings (about exceeding softlimit, reaching
> -- 
> 2.35.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR