Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp385679rwe; Fri, 14 Apr 2023 04:32:47 -0700 (PDT) X-Google-Smtp-Source: AKy350Z3KZN2JIEFbWkNbdvkOrOl7irvqjY1/7smYZA/vIj5XWnKvKsAB26svpSFLjGBhI+5hpG1 X-Received: by 2002:a17:902:c405:b0:1a1:a8db:495d with SMTP id k5-20020a170902c40500b001a1a8db495dmr3425288plk.4.1681471967255; Fri, 14 Apr 2023 04:32:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681471967; cv=none; d=google.com; s=arc-20160816; b=OkZm7G5gAP1rIW2ryVDIDB457ph6bl7m54SgL5XAAtJ0PKeJhb/YEk+pEdBYYm8d7y DH7+LbY91qJYqvynyIBHm8/46Nqp1mSJUcNhciShKevwIqs2xDpiOI3dyNVaQIFoZh/D QS+tZrbu529Gk7cfLQaR8+APTj4EqRhC5/9eNHg8X9IEa5qHrMbIcH2UsH9mxcIpj5rW JWUlx/Vau+bb8QA1crqDXGb/t6X/ePZOK8853un1lMfPPj4nZrADESxr9v2elaC3ZEBy KmOeGNyY7u0qMEogS/8/4G1CJ5XHm9S7kV+QnOTc6TYVAtq0kOD93xYzhqjHhVta2ili gvEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:to:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=1jwXYFBzbS7qmut3eza5zD1XmDDlqA0VGbM9zH71iqE=; b=Xy3LYrQFqaNe26oSEDjqOixMm3fJVTAgbFiFa5bCERgPuSAN15bNmfR9pHbai6C3km IoWhlMBdrYB88v3xUhGboxVoXpXLWEXgtdIY4AmZllXvpUGp+/16IlpMHgVadCpmqbXi 046Gvy56cJNFCtyoUB+Pfa7s8aQsLSXYVEizrwZrX7HyFcHALpHNoq3TRZ0Ljz9jBRzn YS984LwPxqRAPRdxp7UQOl+sBoCXXmDo0lda3itTfmzB3ApmVt4CUanvu73TcCghb0SH jaGDTvm1i9r2m4VZ9xjryrO7/Na0PcAGmVBVAImqCZVtGECvLwm1+BKTVH2huJO2xnre 9G5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uz3YGGGh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x14-20020a63170e000000b0051358b5c88bsi4191347pgl.452.2023.04.14.04.32.35; Fri, 14 Apr 2023 04:32:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uz3YGGGh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230017AbjDNLcQ (ORCPT + 99 others); Fri, 14 Apr 2023 07:32:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230004AbjDNLcO (ORCPT ); Fri, 14 Apr 2023 07:32:14 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C00D8A5A for ; Fri, 14 Apr 2023 04:31:53 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id qb20so44360878ejc.6 for ; Fri, 14 Apr 2023 04:31:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681471904; x=1684063904; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1jwXYFBzbS7qmut3eza5zD1XmDDlqA0VGbM9zH71iqE=; b=uz3YGGGh1WIUzK5nb6vzZtT+IWY9+fITr45V4nvz/hxzO1MqXi2UhqV03a68CRNyEG 5tlTNUL23h7HjO7AifGn/HAxZ0OAa2ofd31mCkx5k081sEK8ApwJ8DyxRLH2csldMbAX SHt12haQsUfxxLVbexh412tIksTtO91ovpZB07eE7lYAKvtlqhFqi9efrTQrxFe3KRb5 LLKw+tsH0yZoIQf2PwCEybCiXNOoZcug8N0fPIkVwrEHPblWciukInisZN3fcixdOSb/ shLjDgbkbs2KrxQoyBifk+T11G54g9c+W3JAr80Q73XCtPX8V8nH1BQ/ARroUjZvOa6J k5kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681471904; x=1684063904; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1jwXYFBzbS7qmut3eza5zD1XmDDlqA0VGbM9zH71iqE=; b=DzEUDVA8EGegw5uhGmBzKElYxQKzmW9+d5MXFd/QwHgygOk+YbTlJuhaXHRuQJZ/Hh hXY0+X25GZpUy7yKRJOTlXAouPgXLo1yt3MlGO4QhvNwlWINTgxa9PQ1PRxX5XQ5D9co 5xAcTFXgW+EfCSJ40UQyDksLFuJyf29n7Nd+FBexlLn8bMfa8Vq925ifgRU9fEBLg9WF SzqvFEfulQ9dVieoSzM/3qFmjYvYbUGipgb2O2stcM0p2t9tqsT4zROUDlo1Hfp7eW5L 07nAMdDy0qKIeBj+eIu7Ek+0FcS9WjMg0qQXqyD5i8gVDTPthSPFwGt/U/0wyYiKVNzO lIlA== X-Gm-Message-State: AAQBX9fKVrjJL06JhuNeN6/pRObJ+ccvK8spBSN+haJsQPYoLTlyRfc1 OdUFvend1mgu7SkVSO1Q5BuuEA== X-Received: by 2002:a17:906:3888:b0:94a:8a82:9cab with SMTP id q8-20020a170906388800b0094a8a829cabmr6016358ejd.42.1681471904108; Fri, 14 Apr 2023 04:31:44 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:40b9:8c57:b112:651d? ([2a02:810d:15c0:828:40b9:8c57:b112:651d]) by smtp.gmail.com with ESMTPSA id hs13-20020a1709073e8d00b0094ece70481csm1311311ejc.197.2023.04.14.04.31.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Apr 2023 04:31:43 -0700 (PDT) Message-ID: <875aaaa6-ac8a-fbf6-edd3-fde5444220b8@linaro.org> Date: Fri, 14 Apr 2023 13:31:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [EXT] Re: [PATCH 1/2] dt-bindings: watchdog: marvell octeonTX2 GTI system atchdog driver Content-Language: en-US To: Bharat Bhushan , "wim@linux-watchdog.org" , "linux@roeck-us.net" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "linux-watchdog@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20230414102342.23696-1-bbhushan2@marvell.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/04/2023 13:29, Bharat Bhushan wrote: > >> >>> + >>> +examples: >>> + - | >>> + soc { >>> + #address-cells = <2>; >>> + #size-cells = <2>; >>> + >>> + watchdog@802000040000 { >>> + compatible = "marvell-octeontx2-wdt"; >>> + reg = <0x8020 0x40000 0x0 0x20000>; >> >> Are you sure that this is correct DTS? 32-bit numbers are usually 8-digit long. Plus >> size of 0x20000 is crazy huge. And the unit address is a bit unusual. Are you sure >> dtc W=1 does not say about any errors in your DTS? > > Each cell is 32bit, so if we specify less than upper values becomes zeros (0s). ... and what is the convention/coding style of your subarch? Is to have short or 0-padded reg addresses? Anyway, I have doubts this was tested, so please confirm that dtbs W=1 and dtbs_check produce no errors on your DTS. BTW, where is the DTS? Best regards, Krzysztof