Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp387476rwe; Fri, 14 Apr 2023 04:34:28 -0700 (PDT) X-Google-Smtp-Source: AKy350b00XObZz/rqVlhyEN3wkK8PSGtF02CvrCw2OekW7Z8iUPKf88gUAHFGBNFDdOQ4Nc01fEd X-Received: by 2002:a17:90a:4f4d:b0:234:13a3:6e67 with SMTP id w13-20020a17090a4f4d00b0023413a36e67mr5341932pjl.12.1681472068345; Fri, 14 Apr 2023 04:34:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681472068; cv=none; d=google.com; s=arc-20160816; b=xIxcz72cWPpWpUh9jOuCbaH16oriFCg+0ryYdRsvCTIXy0RlPuSYGz/WP3QJ8g/Eq4 VA7FMyMpsr0hgRHXLnCaj60+VTU0gmmzQCBxHAzN+PDgfr95ZeYS5/IXdkRyBPObAfKx kqls5C5Oex+IBaMNvnR8BofgmiTHMq8vuNft39g6S7MHJVxGBqqfjqT3LMlz1LrV6vnr L+z8bjXY/4l5K3+gbbOKO85U14Wxq4M1/wt1zKlpA4zcJy8qBovu4QpezEjMXgm+phos eB/coIu5KJRz27kK9zzuYHtqa0IobRh0eLeQGIPKm/bYkKJ+9/rzmeYWwfRaLdprfBij qECQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=kDywA5nzzG8PDOGzLd47TShAUBCkfpN1bPDv+Nlseqw=; b=WRqRqSN6pBITrUc0tEIpdWI9RLe+GFIpwemJjt2VR4Dr+vWyU2ieWHW7/uX0OgQDVn MzspxTJUiZDZnsPH57wUZH1ikSJIiJJiGj7y1U4yMvhHnT1kXcekuSg656vJzMckz0Iy n7Mn871S+tdj7EM72rSr2n0CPsngwgDbD6tJcd2Ke2gskzcB1SiuZrOEJIdpznPOaPwA XuWRxEooJVGEac4DPCGst6t38h+ZPD65Cynr2aUAw+UkEeURtBHsU1Mxze6E9UFcQNl5 KTn0M++nXKDvBNigTgBUhtEthXv0sB+6SkN5beJp5PkEyWGd2AfnVTTsnugE3g/OvEHz kSjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wE9RKmde; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id na14-20020a17090b4c0e00b0023d2847e355si7972917pjb.0.2023.04.14.04.34.16; Fri, 14 Apr 2023 04:34:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wE9RKmde; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230099AbjDNLeL (ORCPT + 99 others); Fri, 14 Apr 2023 07:34:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229805AbjDNLeK (ORCPT ); Fri, 14 Apr 2023 07:34:10 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA52F8A41 for ; Fri, 14 Apr 2023 04:34:07 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id ud9so44586861ejc.7 for ; Fri, 14 Apr 2023 04:34:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681472046; x=1684064046; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kDywA5nzzG8PDOGzLd47TShAUBCkfpN1bPDv+Nlseqw=; b=wE9RKmde+wKXtU9MTYLEOct8qq+bULIWhBM1+kFiAIbN1E9xG98wmd8oovOFhJG7Gx IpKjSq81+inoRgM8PzR3CKWJmq2djz5y/R2B7uvdk3MZphQtQkarM1oma1fbWQ7Nnnm/ VuknmubBBwri1AuAabd58qP5lDSEGyQjPo00KXLmBAzUMal3bEDiiMo2nD2YCVSNXEcz jVkOpD7DR4W66VRmnScecowcKspnaPbieGDHE2+R44/kodoI9qrwEq62Y/5aj9vPXxSv vKtR5oY7ob34ESDJv3DnVU9ehqPma2a7o0//W30kMibsCY/6aEPjfrFeEpHPDY/o/Yd6 KOeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681472046; x=1684064046; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kDywA5nzzG8PDOGzLd47TShAUBCkfpN1bPDv+Nlseqw=; b=mILLOCY1RU/s8QPGI4mdHAnne0wL0FbYTe6cga4z52Jk3wyuoZExHiK6tdO3p8cO++ Rmynx43w9/N3vKyeJyJN60R1g/vREAAmMibvWECc+QDXaKkhBgBOI6ZCQ8aKrIKGNOHw YgONESzdgREOoyrRrBLur9ioeDMNWF9J2e9viKvOjA8Lwgz6r5FclauA0zvFGJj44YDm SR+UlPYThccfG8vSkigQ9AjPOmV3gE9HI9j7DEWl/FhWMovBvD3a4akX7zp3YaYdJAzK +Nyfi7p9edCYlTA4zERlC8s1JnfNEXiuDb9WhPl1zZGKqiYw7gLdzp+XSDLcXu4Zuiqc er8w== X-Gm-Message-State: AAQBX9cvTuQhuFFLCF70NEWFeVaTul2/j+aQiQOQVoksuHp6fp7DO58r N9L56IJs1IyKzSYWkuKKX1xALQ== X-Received: by 2002:a17:906:3a05:b0:92f:f655:cc78 with SMTP id z5-20020a1709063a0500b0092ff655cc78mr5411666eje.53.1681472046353; Fri, 14 Apr 2023 04:34:06 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:40b9:8c57:b112:651d? ([2a02:810d:15c0:828:40b9:8c57:b112:651d]) by smtp.gmail.com with ESMTPSA id x6-20020a170906b08600b0094e6db4d4a1sm2313659ejy.186.2023.04.14.04.34.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Apr 2023 04:34:05 -0700 (PDT) Message-ID: Date: Fri, 14 Apr 2023 13:34:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 3/5] arm64: dts: ti: k3-j721e-som-p0: Add TP6594 family PMICs Content-Language: en-US To: Esteban Blanc , nm@ti.com, vigneshr@ti.com, kristo@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, sterzik@ti.com, u-kumar1@ti.com, jneanne@baylibre.com, jpanis@baylibre.com, aseketeli@baylibre.com References: <20230414112843.1358067-1-eblanc@baylibre.com> <20230414112843.1358067-4-eblanc@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: <20230414112843.1358067-4-eblanc@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/04/2023 13:28, Esteban Blanc wrote: > From: Jerome Neanne > > This patch adds support for TPS6594 PMIC family on wakup I2C0 bus. > Theses devices provides regulators (bucks and LDOs), but also > GPIOs, a RTC, a watchdog, an ESM (Error Signal Monitor) > which monitors the SoC error output signal, and a PFSM > (Pre-configurable Finite State Machine) which manages the > operational modes of the PMIC. > > Signed-off-by: Jerome Neanne > Signed-off-by: Esteban Blanc > --- > arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi | 171 ++++++++++++++++++++ > 1 file changed, 171 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi > index e289d5b44356..a9511e82478a 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi > @@ -150,6 +150,12 @@ J721E_WKUP_IOPAD(0xfc, PIN_INPUT_PULLUP, 0) /* (H24) WKUP_I2C0_SDA */ > >; > }; > > + pmic_irq_pins_default: pmic-irq-pins-default { > + pinctrl-single,pins = < > + J721E_WKUP_IOPAD(0xd4, PIN_INPUT, 7) /* (G26) WKUP_GPIO0_9 */ > + >; > + }; > + > mcu_fss0_ospi0_pins_default: mcu-fss0-ospi0-pins-default { > pinctrl-single,pins = < > J721E_WKUP_IOPAD(0x0000, PIN_OUTPUT, 0) /* MCU_OSPI0_CLK */ > @@ -308,3 +314,168 @@ &c71_0 { > memory-region = <&c71_0_dma_memory_region>, > <&c71_0_memory_region>; > }; > + > +&wkup_i2c0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&wkup_i2c0_pins_default>; > + clock-frequency = <400000>; > + status = "okay"; > + > + tps659413: tps659413@48 { Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Same everywhere else. Best regards, Krzysztof