Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sai Krishna Gajula <saikrishnag@marvell.com>
To:     Simon Horman <simon.horman@corigine.com>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>,
        Linu Cherian <lcherian@marvell.com>,
        Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        Ratheesh Kannoth <rkannoth@marvell.com>
Subject: Re: [net PATCH v2 6/7] octeontx2-af: Skip PFs if not enabled
Thread-Topic: [net PATCH v2 6/7] octeontx2-af: Skip PFs if not enabled
Thread-Index: AQHZbsh+lMIfZBhkXk2MfCR6UxkQMQ==
Date:   Fri, 14 Apr 2023 11:58:58 +0000
Message-ID: <BY3PR18MB47075CA6FF5B4D095ED526BEA0999@BY3PR18MB4707.namprd18.prod.outlook.com>
References: <20230407122344.4059-1-saikrishnag@marvell.com>
 <20230407122344.4059-7-saikrishnag@marvell.com>
 <ZDGAlpI+5hfcHe3r@corigine.com>
In-Reply-To: <ZDGAlpI+5hfcHe3r@corigine.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?o7aiGqKEnPVPsngFVqiKLwOIXB7jnKocHWbPfZ2qYP4+0axZ7S9Yu3txFwu/?=
 =?us-ascii?Q?yxAe7u59owCzoTxf4icaO1COKCLSKQcrehAHsh/d1WdnVO2k0WP9otGvVA7X?=
 =?us-ascii?Q?wtMUn/RugcM58FSJOgdyn2eBuKYkgP1m1AwHKVp7plMdEWpMsVrNhhXvNa54?=
 =?us-ascii?Q?Mavl1gwam1SQB7DcJL2nCCLRwfm8WE2H0jtaEBzY9kj7QZpAsbI7+yUKXeBC?=
 =?us-ascii?Q?PBXZcQ6V8T4hdNA7eXyO+8KWED+Pj/tgR9nMllrwiy/CjgFtbjjUUFxZXAbX?=
 =?us-ascii?Q?CjAgfshh9To1pHT4wGksg/rsdYw9m96zc9PzsCaOBU64DrENgTRo23g3iYcy?=
 =?us-ascii?Q?cMxeYcGVv1Bo3ndaHMzArZJ2fBz0z9QoVcqAqURtA20GDCHzGgO/mmsAoCCz?=
 =?us-ascii?Q?NarMSh0R1ydyg/cB8HpvhZ14TTlyC0lOdSzfaES8fnFZfiqnyxz6dUwHKudZ?=
 =?us-ascii?Q?xdR/ahX2dnvUHb0WfA3DGTa18lye5SkaWX4p94Rn3zeopieNr6QroB8c9yep?=
 =?us-ascii?Q?/kFviU+i3u/aVhs6zpTsG35df1Ep2n6PsAcX50N/HMyfhXP37w61BRgAL5aS?=
 =?us-ascii?Q?bonYoc9GAsHeVQgxAgn7eAcC9EvPd4kEnHkD4/AJQpXIJ8PbDKOmQ8YoZpYE?=
 =?us-ascii?Q?650UxXuo28Eek+Un90qJTp4DQwmkwK/wKgUw8lo/WL8sQQd56tHj3gFKUrrJ?=
 =?us-ascii?Q?vqOOm50kA9SFb2sL+PnVveF/GKEuWMzf5c2v3WIu37l7GxpfzIW9iIJgvb3e?=
 =?us-ascii?Q?ZACKmyLMlOorfurpEflAKq4Zlf6SlZwE1mDO8mt5RdKPU3Dni8qVcksNoUSR?=
 =?us-ascii?Q?15xdhIBQRmdMioWFXYJyNc1Rwt7DKvKX6FQ82tCDMlSIl5jr7DDvg7NkPTjw?=
 =?us-ascii?Q?NHOecqDIznzoeP1gSQb8KjDv1GixzND8Os79fGsZUflIb/qOejG3vIKq7yDj?=
 =?us-ascii?Q?CHEWPtjm6OtCYYiU9N5PmqJjeAr0vqXGEYyd4vCoxq5slstW0QWAOAOJejH7?=
 =?us-ascii?Q?rNA1VsYiuyBrB3j95vV9FJPDH6SBmlU5B12L7JRqx21VU38xlXrUPE7dBmyc?=
 =?us-ascii?Q?SzwSyw2ikR9Mw9hMX5jLWbkJQW7ZIcSuVEa7t9hQMb/gLnZLdjCzRZNFRLnV?=
 =?us-ascii?Q?S40WHWj5GQklpTEb/uPwwt19bwxe9b/hyti56muhxUxyUo/XG9uzyiTuOqVB?=
 =?us-ascii?Q?nLYFcJ7mWMbC2b32RRxeSFcBWLAEKIQLbSxoM3UsmAV+25zGtGFjU3K26LwU?=
 =?us-ascii?Q?xjwD7BQFlYfW2fbBzruQvYONGNPNeGpHXND5p4FVzAgWahT3qMUY05PebiEA?=
 =?us-ascii?Q?icvAK/srmoHQv3IvABtO2gEIBMfJO25zefYCpzFOsxEDQ9tdexX0aQo2Dx3N?=
 =?us-ascii?Q?c5glQp1y5QEuZtwPoiH+ieqTeCELyVS8oqe2/K0L2bJsGgOIebGIbdbaozRS?=
 =?us-ascii?Q?LUy+2rSENYaZmg+BZOBd7i778piYSSGscgfnXrivKkDjB20bAfNRua/TNTHT?=
 =?us-ascii?Q?r/dijn8ULyofLNKRuhTtELHB4nJzbUVO22FqTXs3yYZUIqFVs7b8DoJIARHt?=
 =?us-ascii?Q?ShiGVfZbX72va65SXcFktMjHPUmkfEcJVXfe6en/?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4707.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f873fa0-6876-4e69-7894-08db3cdfa16f
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2023 11:58:58.6292
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: z8RE3Ozsi62dl6vnNXmQJXqLsHor6gZTjF3Ciks7q8Z8QDY2/d7pN/AoqzeGHq55lp0qNjwNlRftc/4h2ZRVww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2605
X-Proofpoint-GUID: uy-KqI6_l3ZOJ8s_vz58GXAd8jvtlROX
X-Proofpoint-ORIG-GUID: uy-KqI6_l3ZOJ8s_vz58GXAd8jvtlROX
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-14_06,2023-04-14_01,2023-02-09_01
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Please see inline,

> -----Original Message-----
> From: Simon Horman <simon.horman@corigine.com>
> Sent: Saturday, April 8, 2023 8:26 PM
> To: Sai Krishna Gajula <saikrishnag@marvell.com>
> Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
> pabeni@redhat.com; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; Sunil Kovvuri Goutham <sgoutham@marvell.com>;
> Geethasowjanya Akula <gakula@marvell.com>; richardcochran@gmail.com;
> Linu Cherian <lcherian@marvell.com>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>;
> Subbaraya Sundeep Bhatta <sbhatta@marvell.com>; Ratheesh Kannoth
> <rkannoth@marvell.com>
> Subject: Re: [net PATCH v2 6/7] octeontx2-af: Skip PFs if not enabled
>=20
> On Fri, Apr 07, 2023 at 05:53:43PM +0530, Sai Krishna wrote:
> > From: Ratheesh Kannoth <rkannoth@marvell.com>
> >
> > Skip mbox initialization of disabled PFs. Firmware configures PFs and
> > allocate mbox resources etc. Linux should configure particular PFs,
> > which ever are enabled by firmware.
> >
> > Fixes: 9bdc47a6e328 ("octeontx2-af: Mbox communication support btw AF
> > and it's VFs")
> > Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com>
> > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
> > Signed-off-by: Sai Krishna <saikrishnag@marvell.com>
>=20
> ...
>=20
> > @@ -2343,8 +2349,27 @@ static int rvu_mbox_init(struct rvu *rvu, struct
> mbox_wq_info *mw,
> >  	int err =3D -EINVAL, i, dir, dir_up;
> >  	void __iomem *reg_base;
> >  	struct rvu_work *mwork;
> > +	unsigned long *pf_bmap;
> >  	void **mbox_regions;
> >  	const char *name;
> > +	u64 cfg;
> > +
> > +	pf_bmap =3D devm_kcalloc(rvu->dev, BITS_TO_LONGS(num),
> sizeof(long),
> > +GFP_KERNEL);
>=20
> Hi Sai and Ratheesh,
>=20
> I am a little confused about the lifecycle of pf_bmap.
> It is a local variable of this function.
> But it is allocated using devm_kcalloc(), so it will persist for the life=
 of the
> device.
>=20
> Also, I note that rvu_mbox_init() has too call sites.
> So is there a situation where a pf_bmap is allocated more than once for t=
he
> same rvu->dev instance?
>=20
> It seems to me it would be more appropriate to allocate bf_bmap using
> kcalloc() take clear to free it before leaving rvu_mbox_init(), as is alr=
eady
> done for mbox_regions.
>=20

We will prepare v3 patch according to the suggested changes using kcalloc()=
.

> > +	if (!pf_bmap)
> > +		return -ENOMEM;
>=20
> ...