Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Apr 2023 14:21:28 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Pankaj Raghav <p.raghav@samsung.com>
Cc:     brauner@kernel.org, viro@zeniv.linux.org.uk,
        akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, mcgrof@kernel.org,
        gost.dev@samsung.com, hare@suse.de
Subject: Re: [RFC 4/4] fs/buffer: convert create_page_buffers to
 create_folio_buffers
Message-ID: <ZDlTWILV+E7XAzDy@casper.infradead.org>
References: <20230414110821.21548-1-p.raghav@samsung.com>
 <CGME20230414110827eucas1p20e5f6bc74025acfb62b13465f267fa84@eucas1p2.samsung.com>
 <20230414110821.21548-5-p.raghav@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230414110821.21548-5-p.raghav@samsung.com>
Precedence: bulk

On Fri, Apr 14, 2023 at 01:08:21PM +0200, Pankaj Raghav wrote:
> fs/buffer do not support large folios as there are many assumptions on
> the folio size to be the host page size. This conversion is one step
> towards removing that assumption. Also this conversion will reduce calls
> to compound_head() if create_folio_buffers() calls
> folio_create_empty_buffers().

I'd call this folio_create_buffers(), but other than that, looks good.