Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp552221rwe; Fri, 14 Apr 2023 06:50:55 -0700 (PDT) X-Google-Smtp-Source: AKy350bS7Nqn2YnIWhIK3ofdVvRDPOZhorIe0AUtpovWE0eacspDhEIAgeOp/Os+UB9CBAwylu25 X-Received: by 2002:a17:90b:2317:b0:23f:81ac:80b8 with SMTP id mt23-20020a17090b231700b0023f81ac80b8mr5226821pjb.40.1681480255428; Fri, 14 Apr 2023 06:50:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681480255; cv=none; d=google.com; s=arc-20160816; b=aQoinVh3ds4UVuy4rct8VNZFPc8hm8gCuI/qyDIGTM9wojkEF2yTsoIp/CXVgQPGXm UaJVHdCmY6pLSzcqr3ZrQ8nXSuFg9uLewx7qHDMhkGLMbwmZI9zr8lDNWbNXZ/F/GR5W vRilkgDh5PpvSwBfoX13QuDL76qItqxiSW2uS63OIzC7S+RDdoXkIu/aSTD8/USFW0Oj pkMiEZsKhnhlAsmMzBTm+q1VocZk8fWYCS7RKa0SzR9D8y56nv4C70nvXBZ3977z4Owf RZ3LM9Wvth3NGoyLoIW+Z8Xokg21gw1qTN0Opeqoh02B7C/QqDaKOYgd1Grpupntckq+ Rsow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-signature; bh=tVTQPul/JXATpe+rLUOKdbwaHI2COkJc82nsUk9iRu0=; b=sr30NzJEP0mkQ/dW68BK54VERdfrpIjICyL6iu1KdH7ZOGvGGUmTwiqe0AiMaM6ugN XQnSsVOUDVcos+N+ydaF1cbP3VkSDxqc5JrR5PXrkPo7ZrwDVbX0X9NWZMB+mYwBN/m6 X2BMu5eORfK5sDWnhp1AeastmPc3Zzqdf4bu/p9EB7Z3qjTSFHaN+T+GmaPVSxzH9mJm OnbBFmjxGuy8r8G6+1e8bzxaGbNKyqB+w/j1VXZEx9JrFWsnNmvQ0M+EAoyosFVLL63D MgTSWxpbXHNUwVxXkl5XlH+WFbSr5kLLAR+6wjrWN9dFR5jas8fBnqFndQyKu3bEprkY b10g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=yrrU8Rd8; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n2-20020a170902d2c200b001a235350e69si4951489plc.104.2023.04.14.06.50.39; Fri, 14 Apr 2023 06:50:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=yrrU8Rd8; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229965AbjDNNtk (ORCPT + 99 others); Fri, 14 Apr 2023 09:49:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229735AbjDNNtj (ORCPT ); Fri, 14 Apr 2023 09:49:39 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE0A7B77E; Fri, 14 Apr 2023 06:49:11 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 262D9219D7; Fri, 14 Apr 2023 13:49:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1681480150; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=tVTQPul/JXATpe+rLUOKdbwaHI2COkJc82nsUk9iRu0=; b=yrrU8Rd8A6t3YfPMmwobhbRVKgeH14EUpv9J7/J74OlCc/kJNuZgarcU3PNAUH61RBAUxM 3b5vspT9hfcvBkrii/eKZvjDWZLTwodFjnI6S9SYS4eCK40AZiYFy7zwbqAkJIJb0ZMVLy Ru/9vvTOVF1QGjm5/TFinKWlsMglZI8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1681480150; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=tVTQPul/JXATpe+rLUOKdbwaHI2COkJc82nsUk9iRu0=; b=3Cm3KiqT004Qj8aTzVi0lrNxTyArJdXb6TAd7XXHhwgQ6kHnpe7eQRbw8AREzmsFzx4G1F qBLrXxO/oJelEBBg== Received: from adalid.arch.suse.de (adalid.arch.suse.de [10.161.8.13]) by relay2.suse.de (Postfix) with ESMTP id D12BB2C143; Fri, 14 Apr 2023 13:49:09 +0000 (UTC) Received: by adalid.arch.suse.de (Postfix, from userid 16045) id C146951C23D9; Fri, 14 Apr 2023 15:49:09 +0200 (CEST) From: Hannes Reinecke To: Pankaj Raghav Cc: Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, mcgrof@kernel.org, Hannes Reinecke Subject: [PATCH] mm/filemap: allocate folios according to the blocksize Date: Fri, 14 Apr 2023 15:49:08 +0200 Message-Id: <20230414134908.103932-1-hare@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If the blocksize is larger than the pagesize allocate folios with the correct order. Signed-off-by: Hannes Reinecke --- mm/filemap.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/mm/filemap.c b/mm/filemap.c index 05fd86752489..468f25714ced 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -1927,7 +1927,7 @@ struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, folio_wait_stable(folio); no_page: if (!folio && (fgp_flags & FGP_CREAT)) { - int err; + int err, order = 0; if ((fgp_flags & FGP_WRITE) && mapping_can_writeback(mapping)) gfp |= __GFP_WRITE; if (fgp_flags & FGP_NOFS) @@ -1937,7 +1937,9 @@ struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, gfp |= GFP_NOWAIT | __GFP_NOWARN; } - folio = filemap_alloc_folio(gfp, 0); + if (mapping->host->i_blkbits > PAGE_SHIFT) + order = mapping->host->i_blkbits - PAGE_SHIFT; + folio = filemap_alloc_folio(gfp, order); if (!folio) return NULL; @@ -2492,9 +2494,11 @@ static int filemap_create_folio(struct file *file, struct folio_batch *fbatch) { struct folio *folio; - int error; + int error, order = 0; - folio = filemap_alloc_folio(mapping_gfp_mask(mapping), 0); + if (mapping->host->i_blkbits > PAGE_SHIFT) + order = mapping->host->i_blkbits - PAGE_SHIFT; + folio = filemap_alloc_folio(mapping_gfp_mask(mapping), order); if (!folio) return -ENOMEM; @@ -3607,14 +3611,16 @@ static struct folio *do_read_cache_folio(struct address_space *mapping, pgoff_t index, filler_t filler, struct file *file, gfp_t gfp) { struct folio *folio; - int err; + int err, order = 0; + if (mapping->host->i_blkbits > PAGE_SHIFT) + order = mapping->host->i_blkbits - PAGE_SHIFT; if (!filler) filler = mapping->a_ops->read_folio; repeat: folio = filemap_get_folio(mapping, index); if (!folio) { - folio = filemap_alloc_folio(gfp, 0); + folio = filemap_alloc_folio(gfp, order); if (!folio) return ERR_PTR(-ENOMEM); err = filemap_add_folio(mapping, folio, index, gfp); -- 2.35.3