Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Apr 2023 16:14:56 +0200
From:   Stephan Gerhold <stephan@gerhold.net>
To:     jbreva@nayarsystems.com
Cc:     Loic Poulain <loic.poulain@linaro.org>,
        Sergey Ryazanov <ryazanov.s.a@gmail.com>,
        Johannes Berg <johannes@sipsolutions.net>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: wwan: Expose secondary AT port on DATA1
Message-ID: <ZDlf4Kutl511lIQ_@gerhold.net>
References: <20230414-rpmsg-wwan-secondary-at-port-v1-1-6d7307527911@nayarsystems.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230414-rpmsg-wwan-secondary-at-port-v1-1-6d7307527911@nayarsystems.com>
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, Apr 14, 2023 at 01:07:40PM +0200, Jaime Breva via B4 Relay wrote:
> From: Jaime Breva <jbreva@nayarsystems.com>
> 
> Our use-case needs two AT ports available:
> One for running a ppp daemon, and another one for management
> 
> This patch enables a second AT port on DATA1
> 
> Signed-off-by: Jaime Breva <jbreva@nayarsystems.com>

Acked-by: Stephan Gerhold <stephan@gerhold.net>

Thanks,
Stephan

> ---
>  drivers/net/wwan/rpmsg_wwan_ctrl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wwan/rpmsg_wwan_ctrl.c b/drivers/net/wwan/rpmsg_wwan_ctrl.c
> index 31c24420ab2e..e964bdeea2b3 100644
> --- a/drivers/net/wwan/rpmsg_wwan_ctrl.c
> +++ b/drivers/net/wwan/rpmsg_wwan_ctrl.c
> @@ -149,6 +149,7 @@ static const struct rpmsg_device_id rpmsg_wwan_ctrl_id_table[] = {
>  	/* RPMSG channels for Qualcomm SoCs with integrated modem */
>  	{ .name = "DATA5_CNTL", .driver_data = WWAN_PORT_QMI },
>  	{ .name = "DATA4", .driver_data = WWAN_PORT_AT },
> +	{ .name = "DATA1", .driver_data = WWAN_PORT_AT },
>  	{},
>  };
>  MODULE_DEVICE_TABLE(rpmsg, rpmsg_wwan_ctrl_id_table);
> 
> ---
> base-commit: c9c3395d5e3dcc6daee66c6908354d47bf98cb0c
> change-id: 20230414-rpmsg-wwan-secondary-at-port-db72a66ce74a
> 
> Best regards,
> -- 
> Jaime Breva <jbreva@nayarsystems.com>
>