Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759081AbXIZTX3 (ORCPT ); Wed, 26 Sep 2007 15:23:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756036AbXIZTXV (ORCPT ); Wed, 26 Sep 2007 15:23:21 -0400 Received: from sj-iport-3-in.cisco.com ([171.71.176.72]:31034 "EHLO sj-iport-3.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755820AbXIZTXU (ORCPT ); Wed, 26 Sep 2007 15:23:20 -0400 X-IronPort-AV: E=Sophos;i="4.21,198,1188802800"; d="scan'208";a="528445005" To: Matthew Wilcox Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] Change dmapool free block management X-Message-Flag: Warning: May contain useful information References: <20070926185757.GM3899@parisc-linux.org> <1190833279354-git-send-email-willy@linux.intel.com> From: Roland Dreier Date: Wed, 26 Sep 2007 12:23:15 -0700 In-Reply-To: <1190833279354-git-send-email-willy@linux.intel.com> (Matthew Wilcox's message of "Wed, 26 Sep 2007 15:01:18 -0400") Message-ID: User-Agent: Gnus/5.1008 (Gnus v5.10.8) XEmacs/21.4.20 (linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OriginalArrivalTime: 26 Sep 2007 19:23:16.0335 (UTC) FILETIME=[B04087F0:01C80072] Authentication-Results: sj-dkim-2; header.From=rdreier@cisco.com; dkim=pass ( sig from cisco.com/sjdkim2002 verified; ); Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 697 Lines: 15 > Also add documentation for how dma pools work, move the header above the > includes, add my copyright, add the original author's copyright, add a > GPL v2 licence to the file and fix the includes. The fact that you have all these other changes mixed in makes the main change very difficult to review. Also I assume the main change is "Change dmapool free block management" -- but I'm left wondering exactly how and why you're changing it. - R. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/