Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <505f1aac-8348-56c2-b925-6a905af9be24@samsung.com>
Date:   Fri, 14 Apr 2023 17:01:47 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
        Thunderbird/102.10.0
Subject: Re: [RFC 2/4] buffer: add alloc_folio_buffers() helper
Content-Language: en-US
To:     Matthew Wilcox <willy@infradead.org>
CC:     <brauner@kernel.org>, <viro@zeniv.linux.org.uk>,
        <akpm@linux-foundation.org>, <linux-fsdevel@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <mcgrof@kernel.org>,
        <gost.dev@samsung.com>, <hare@suse.de>
From:   Pankaj Raghav <p.raghav@samsung.com>
In-Reply-To: <ZDlP2fevtfD5gMPd@casper.infradead.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <20230414110821.21548-1-p.raghav@samsung.com>
        <CGME20230414110826eucas1p2c5afcbd64c536a803751b41d03eb9e99@eucas1p2.samsung.com>
        <20230414110821.21548-3-p.raghav@samsung.com>
        <ZDlP2fevtfD5gMPd@casper.infradead.org>
Precedence: bulk

On 2023-04-14 15:06, Matthew Wilcox wrote:
> On Fri, Apr 14, 2023 at 01:08:19PM +0200, Pankaj Raghav wrote:
>> Folio version of alloc_page_buffers() helper. This is required to convert
>> create_page_buffers() to create_folio_buffers() later in the series.
>>
>> It removes one call to compound_head() compared to alloc_page_buffers().
> 
> I would convert alloc_page_buffers() to folio_alloc_buffers() and
> add
> 
> static struct buffer_head *alloc_page_buffers(struct page *page,
> 		unsigned long size, bool retry)
> {
> 	return folio_alloc_buffers(page_folio(page), size, retry);
> }
> 
> in buffer_head.h
> 
> (there are only five callers, so this feels like a better tradeoff
> than creating a new function)
> 
That is a good idea and follows the usual pattern for folio conversion. I will
send a new version soon with your other comments as well.

--
Pankaj