Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b6ca629e-f4d9-9f31-ecd7-6db6d53b8d55@amd.com>
Date:   Fri, 14 Apr 2023 10:17:51 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v3 2/6] efi/cper: Export cper_mem_err_unpack() for use by
 modules
Content-Language: en-US
From:   Terry Bowman <Terry.Bowman@amd.com>
To:     Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc:     alison.schofield@intel.com, vishal.l.verma@intel.com,
        ira.weiny@intel.com, bwidawsk@kernel.org, dan.j.williams@intel.com,
        dave.jiang@intel.com, linux-cxl@vger.kernel.org, rrichter@amd.com,
        linux-kernel@vger.kernel.org, bhelgaas@google.com,
        Ard Biesheuvel <ardb@kernel.org>, linux-efi@vger.kernel.org
References: <20230411180302.2678736-1-terry.bowman@amd.com>
 <20230411180302.2678736-3-terry.bowman@amd.com>
 <20230413170816.0000333b@Huawei.com>
 <9d66afdb-40bd-4254-547e-05f6481dd550@amd.com>
 <20230414124805.00000479@Huawei.com>
 <aba5d2ee-f451-145c-81c2-72595129483b@amd.com>
In-Reply-To: <aba5d2ee-f451-145c-81c2-72595129483b@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V0V5cTJ6Q1c5R09JK1NadmNacWxEVERaaDBBSjZFdG1xRzRFT1M1dUU1cVp4?=
 =?utf-8?B?OTJoVU1SbDYvT0YwTFBYVnY2VG1vd1lBT0MySWdGSTJjVEJwa2JEYk00QjZ3?=
 =?utf-8?B?Tmg2RG0wQzdHdlVXeW5mOWZOTlZhVzh5M0RLS1kvV1NyVjYxcExhenB4K1JK?=
 =?utf-8?B?Nk5rdlNETGpsenVOcm10aGxWQkNRcmpDM3doallLd0dNRjNTRnpUQkhBMkI3?=
 =?utf-8?B?OVorL0Y1L1h0cTN4ay9NSTVzWlVRMmQ1R3EyV3lvTTFRL2NuSXIrUHBqc0dp?=
 =?utf-8?B?bGx6OFRlSEFxZ0ZrcnA4VEFBWVNVYUNrc1pDemJxZGpDTldjdTUyc1VVRU1z?=
 =?utf-8?B?dWRjU01sU3llY0M3TDZHaGVNMzVIM3ZpdVB0SENUc3lsWmsrTkxoZmFlL2x3?=
 =?utf-8?B?M1BWMlRJRWhOQ2dCRWhLMEN5d1ZnV1l6T3AyUkFNVStrcGhub3c4UzNSR29E?=
 =?utf-8?B?L0l0T2xETllOWEpvNlg2SHg3ekJ4NUoxOTR6WWZ3dGdQL2RYamg2ZUp2WmhH?=
 =?utf-8?B?V2VJM29ZQWxrbEVpcEFpblRzdUpUTTRsRXJBMjgwcXF2WldOUDIxanVzWnpO?=
 =?utf-8?B?alpVN1V6cndIT21mMmQ3bk1WdjAwaHFvSUVPWU5KVG0vb3ZMVDI2b1NYS25O?=
 =?utf-8?B?c3lRaVJDSEZDelBOa04vNEFlN1lWM1kxa3ZzdEdTZ25BSy9tRmFvR3l6MUFF?=
 =?utf-8?B?OGFySWFRdERHdG5hTHN2TTBYZy92U3JBa05EZC8zRHhySkxVa2xKTzg3dFU4?=
 =?utf-8?B?WlBFTmJQMXBrVU9XbnZQNGVwTHJndzhIRUp5QUZ1Mi9JOEdZeWZnZ2FjQi90?=
 =?utf-8?B?Sk9laUxNWmQ1STdCOEFOU2kzRE9LOXRja3E2ZGk5em5pZFQ4djNxMExqZTZz?=
 =?utf-8?B?M2MzODFCNDJUY040K2pkSkg1ZHZpQ1EzQUxJYWw0SGp1RHU3UWdRRXRQQk9V?=
 =?utf-8?B?anRaWjdvaFlBd3A0cTBlZ1VtcW1LeEx1Z3lKOEpaNlJvWktlNFpBazdOSTBG?=
 =?utf-8?B?cFh5Rmc5NHg4NkxNK2RkNnZTQmd3TkJYWmZKRHhFR0dIZytZS0N1eG1JczFI?=
 =?utf-8?B?cmNDS1lnUjlURzZ0d2RvMlVEMmI4MHZaRU95WXI0Zy9zSjBMaUFUelprRm9w?=
 =?utf-8?B?VGkzakFnTUtoZFM3TkM3aEVEdUVQelNsampJODh1Q3BqZkVVdGw0cEFQcTMr?=
 =?utf-8?B?WnNQbWpPc01neEZnaHBDbStKV1JFVXYzYWZ0VlRqQTRDT3AwMENJRVlkcjkw?=
 =?utf-8?B?Mk9aaVBXN01pN1RXR1p3Y093Q01ZNTlNMlVzY1JCZ1Z2VDUyNWlsVDV5Wm5C?=
 =?utf-8?B?OXgzZlFjeUwyZWFNWWd2SE42Wi9CMndoSm9CcXFrRUtPZWkwNTRBMnZURElw?=
 =?utf-8?B?S2IvMzB2b2lrbW1GSnRYSWZXWnBOVHV0VW1MNkI3bUZjVnB6VmxiRDhYMG9N?=
 =?utf-8?B?Yjg3YkVIMzJBZ3M3dHlMLzZWeFZJRno2Z3dBV2N5cTZRTGNzejkzZlRvN1Rr?=
 =?utf-8?B?Z2lNTEwzeFRIMk9IWVI5ZXRyMUFmT3UzY2c5TTJCT2ZhcDZuYTRmdldVUkEw?=
 =?utf-8?B?eis3cVorUlJTaDlVMzQzeHh6ZkhWSGJQdTBuNk9IdkhqNEhNTDhrUXl6Y0Nv?=
 =?utf-8?B?WE96OWdoRFBKeGNzM2lCSnc5bnRsUm9TYmdIZHI0NXpmY0ZqYmptbW9xckgw?=
 =?utf-8?B?RDEvbnN0WGcwRzJ2bDBFcjJzM2NRZ3RjYkhqKzE5YkN4WThwTFk0RlVWS1BP?=
 =?utf-8?B?b09zZDA4WDI4eXlRYkxZQWhYcjY2NEpKcVFCTjVWaVlzakE0VzQrSkVTeEpL?=
 =?utf-8?B?eTFINExYOHNVTzdJdUlUMFEvNXJHZWRiY1F1RUFLQ2Jvd2IxVjNEYmJ0Nkx1?=
 =?utf-8?B?cmFEL1RlTEozQjA2SnRUUlFrR1FrTkE1VnoyRlpXdHA5dG5hamQwZGFYbzFD?=
 =?utf-8?B?alRHNjl1c1dsRjJ4cmEzbjYrU05zT2pHNGRWemlSSzN4aGVuYzdkMDhyY1NE?=
 =?utf-8?B?MEl2QnZvazl2VDVROXY2WHlnNEFzWHZ0c0hZMWZ2RGNFQlVmUngyWmk0dkpL?=
 =?utf-8?B?MDc0UERsb1ZRSjRoeHZtZjFwVkExNlcxZzQ3RlAzTGlwTkFNMzFkRmRVVFNK?=
 =?utf-8?Q?QPtKUH+8wrK7m36EZl2IIjbSZ?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 36e95e93-69f3-4b31-461a-08db3cfb6b9e
X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6390.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 15:17:54.4883
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FjR5a6kB71tkue6jLAzqgfCSlCM+4IL63/7ktKhEyrhKkx6iXeHIB0BoWONGqakF0uDICEy97eSD6iwb/OA84Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6072
X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/14/23 08:24, Terry Bowman wrote:
> 
> 
> On 4/14/23 06:48, Jonathan Cameron wrote:
>> On Thu, 13 Apr 2023 14:40:10 -0500
>> Terry Bowman <Terry.Bowman@amd.com> wrote:
>>
>>> Hi Jonathan,
>>>
>>> On 4/13/23 11:08, Jonathan Cameron wrote:
>>>> On Tue, 11 Apr 2023 13:02:58 -0500
>>>> Terry Bowman <terry.bowman@amd.com> wrote:
>>>>   
>>>>> The CXL driver plans to use cper_print_aer() for restricted CXL host (RCH)
>>>>> logging. This is not currently possible if CXL is built as a loadable
>>>>> module because cper_print_aer() depends on cper_mem_err_unpack() which
>>>>> is not exported.
>>>>>
>>>>> Export cper_mem_err_unpack() to enable cper_print_aer() usage in
>>>>> CXL and other loadable modules.  
>>>>
>>>> No problem with the export, but I'm struggling to see the path that needs it.
>>>> Could you give a little more detail, perhaps a call path?
>>>>   
>>>
>>> The cper_print_aer() is used to log RCH dport AER errors. This is needed 
>>> because the RCH dport AER errors are not handled directly by the AER port 
>>> driver. I'll add these details to the patch.
>>
>> Ah. I wasn't particularly clear.  cper_print_aer() is fine, but oddly
>> I'm not seeing where that results in a call to cper_mem_err_unpack()
>>
>> More than possible my grep skills are failing me!
>>
>> Jonathan
>>
> 
> I see. Without this patch, if include/ras/ras_event.h  cper_mem_err_unpack() 
> 
> We use 
> 
> 

Testing shows this patch is no longer needed. This patch was required for earlier
implementation calling the aer trace macros directly. I will remove this
patch in next patchset revision.

Regards,
Terry

>>>
>>> Regards,
>>> Terry
>>>
>>>> Thanks,
>>>>
>>>> Jonathan
>>>>   
>>>>>
>>>>> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
>>>>> Cc: Ard Biesheuvel <ardb@kernel.org>
>>>>> Cc: linux-efi@vger.kernel.org
>>>>> ---
>>>>>  drivers/firmware/efi/cper.c | 1 +
>>>>>  1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/drivers/firmware/efi/cper.c b/drivers/firmware/efi/cper.c
>>>>> index 35c37f667781..ff15e12160ae 100644
>>>>> --- a/drivers/firmware/efi/cper.c
>>>>> +++ b/drivers/firmware/efi/cper.c
>>>>> @@ -350,6 +350,7 @@ const char *cper_mem_err_unpack(struct trace_seq *p,
>>>>>  
>>>>>  	return ret;
>>>>>  }
>>>>> +EXPORT_SYMBOL_GPL(cper_mem_err_unpack);
>>>>>  
>>>>>  static void cper_print_mem(const char *pfx, const struct cper_sec_mem_err *mem,
>>>>>  	int len)  
>>>>   
>>