Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Apr 2023 17:27:44 +0200
From:   thomas@t-8ch.de
To:     Jorge Lopez <jorgealtxwork@gmail.com>
Cc:     hdegoede@redhat.com, platform-driver-x86@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9] HP BIOSCFG driver - Documentation
Message-ID: <f91ee2ff-3a24-4e2b-bf68-f1c5400b7462@t-8ch.de>
References: <20230412144821.5716-1-jorge.lopez2@hp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230412144821.5716-1-jorge.lopez2@hp.com>
Precedence: bulk

Hi Jorge,

On 2023-04-12 09:48:21-0500, Jorge Lopez wrote:
> [..]
>
> +What:		/sys/class/firmware-attributes/*/authentication/SPM/statusbin
> +Date:		March 29
> +KernelVersion:	5.18
> +Contact:	"Jorge Lopez" <jorge.lopez2@hp.com>
> +Description:	'statusbin' is a read-only file that returns 'status' information
> +		in binary format. This file provides a mechanism for components
> +		downstream (e.g. Recovery Agent) can read the status and public
> +		key modulus.

This is still missing docs about how to interpret the contents of the
"statusbin" file.

"components downstream" -> userspace.


I think we can start with the code review.

Could you also provide a sample of the attribute files?
I'm especially curious about the different instances of the sure-start
attributes, including current_value, possible_values and the auditlog
properties.

Also is the userspace component for this published somewhere?
If so it would be useful to refer to it from the commit message.

Thanks,
Thomas