Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Apr 2023 17:56:29 +0200
From:   Andreas Kemnade <andreas@kemnade.info>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     pavel@ucw.cz, lee@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, linux-leds@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Matti Vaittinen <mazziesaccount@gmail.com>
Subject: Re: [PATCH v4 1/2] dt-bindings: leds: Add ROHM BD2606MVV LED driver
Message-ID: <20230414175629.2f03e503@aktux>
In-Reply-To: <20230414175412.37a15572@aktux>
References: <20230414055341.335456-1-andreas@kemnade.info>
        <20230414055341.335456-2-andreas@kemnade.info>
        <f9da7499-3fb3-1ce6-db0b-d87febee2052@linaro.org>
        <20230414175412.37a15572@aktux>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 14 Apr 2023 17:54:12 +0200
Andreas Kemnade <andreas@kemnade.info> wrote:

> On Fri, 14 Apr 2023 17:28:49 +0200
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> 
> > On 14/04/2023 07:53, Andreas Kemnade wrote:  
> > > Document ROHM BD2606MVV LED driver devicetree bindings.    
> > 
> > Subject: no improvements and no comments from your side. Why?
> >   
> old subject (v2):
> 
> dt-bindings: leds: ROHM BD2606MVV LED driver
> 
> Your comment:
> Subject: maybe drop "driver" (suggests it is for Linux drivers, although
> maybe it matches the actual hardware here?) and add missing verb, e.g.
> "Add ROHM ..."
> 
> New Subject (v3/4):
> dt-bindings: leds: Add ROHM BD2606MVV LED driver
> 
> What is still missing?
> 
ok, answering myself:
missing verb was added ("Add")

but
s/driver//
is missing

Sorry.

Regards,
Andreas