Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp776692rwe; Fri, 14 Apr 2023 09:33:00 -0700 (PDT) X-Google-Smtp-Source: AKy350YtlmS0xhNnACd4EKLbHxsn10bPxrjwBxDCWzGXsEFrQUWvGxM3U9PajEU16tmpNj2AH4Z8 X-Received: by 2002:a05:6a00:240b:b0:637:253a:531c with SMTP id z11-20020a056a00240b00b00637253a531cmr8523819pfh.27.1681489980187; Fri, 14 Apr 2023 09:33:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681489980; cv=none; d=google.com; s=arc-20160816; b=KFyH7P9+2ioEykuODDWUMH+VgXu1LQBFBuzU1Ik3tPNkmDf4aixDJk54pRvjNwTyu3 UZiGxV8ut1PXbGbGGHT5qF6UVM+dXAC6YparIWh7a2Aaym0+fwcoX5c5FHzgmYdDcxR7 NxK8UOMSUHAco5MpTJ9tLufyD9ClAKfUQsiMV90rGEDNHmnRhMKJNZP8IInMDXw6jnSn lXXVE3tD8EI6osbfopzR08O01Rxohl8Opr2OKg6yfGszOlHjzXlCk8A/HWom3ThKWBCA P6mXyoKa2rJ8Wpwlgw7k2uCI2Whq3BnRmNFjiAYyl2b9e+xqHWG4M42hxTOjWkWP10J0 T/wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=5b/9r03boRV4UanYn1RNmzB2JpdCWtq18uHUNH61CVs=; b=pVTBsfFj2PB5WubYTHIt/J5+cfn5XuDP9QHo2fCp+ZFwyAv2iUsiiCqgPxu6J0Qjti sriBPwQJ7rkQzEh1kANyIbx72ud5W1GqVQda7LqxpyrijRcP/FO2ofZcWnzjYgJpTgdk 405CaJrYXwhPcoBA2vv48DPojSeJEBnWjNQ0naAu4izmVBnrSXyfpTfGKfLEp5mbl3k3 8wdqtEql64DoE5C+2qPEksxWMsk1DJ/Vci2sEOZOrN2/gd10vMTEzhthYjHqLS675rWD 0w9S/XUNIH2dzZP0+Y6TIUTBc8Z+WJ5/cd+LcKIHmIf0aBcuZ293K6+vMAMNuKjvtfuG L54g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@dectris.com header.s=google header.b=pIQNUABR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=dectris.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j70-20020a638b49000000b0051b6cf91f72si2303830pge.528.2023.04.14.09.32.45; Fri, 14 Apr 2023 09:33:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@dectris.com header.s=google header.b=pIQNUABR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=dectris.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229651AbjDNQcE (ORCPT + 99 others); Fri, 14 Apr 2023 12:32:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229469AbjDNQcC (ORCPT ); Fri, 14 Apr 2023 12:32:02 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9492D977C for ; Fri, 14 Apr 2023 09:31:29 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-94a342f3ebcso438375366b.0 for ; Fri, 14 Apr 2023 09:31:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dectris.com; s=google; t=1681489881; x=1684081881; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5b/9r03boRV4UanYn1RNmzB2JpdCWtq18uHUNH61CVs=; b=pIQNUABRqfz5G9IJM9lizr0vPl0WgB7n4aWZwZUe/kF73YAamGDV377CeXdl3tawD9 kq34tFZFPldbRMdqDikQFALSsSWfziPQZwMO6nLRKUytsmCwRnBk7q4JsWELm6ADvBrs wZwK5QNA4bcVQ9oZFNH1ueUmNoKf/StC9Cqds= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681489881; x=1684081881; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5b/9r03boRV4UanYn1RNmzB2JpdCWtq18uHUNH61CVs=; b=CxglZR5qdSTkWKQv00XA7fniercEFyRe3+eWlnadkUy/VOhekPLVZ01vMnBdhWR/Ht sf6i6G6fRtK0TVVpgV89Kl0TpQhTVbT1hu0uG9RgtSkG/jX361vxRcTgDJsT4PIl+Cae pzbPA3CoNb4mUiRrBjbRzwhaLuRDb0NWZD9agF0YlXH+z5IKbVQb/1MyvIXeKYuTmPrm CkrrFEsTS0jdDLeUJ9UICxLIx8OJENKIQCiFKsioyVclsdHyPTUnlYa73qaE3jIX8JNH ZcFg7UGRqt4TMi3UC+Amzphz5t9buB6d6fBK0sjkpbMMXXm4+9shVhcyj6K1AkPAImdP wNKQ== X-Gm-Message-State: AAQBX9fhngWLORf2c9x5wStn7wi+5OEsXu6lc/TutzR0EGhfekuoYJa8 +R7FYBhFPvcXpuvejOXxLwE4+9QMnzO38VEmZub7uQ== X-Received: by 2002:a50:8d43:0:b0:4fc:fc86:5f76 with SMTP id t3-20020a508d43000000b004fcfc865f76mr3343019edt.6.1681489880762; Fri, 14 Apr 2023 09:31:20 -0700 (PDT) MIME-Version: 1.0 References: <20230406130205.49996-1-kal.conley@dectris.com> <20230406130205.49996-2-kal.conley@dectris.com> <87sfdckgaa.fsf@toke.dk> <875ya12phx.fsf@toke.dk> <87ile011kz.fsf@toke.dk> In-Reply-To: <87ile011kz.fsf@toke.dk> From: Kal Cutter Conley Date: Fri, 14 Apr 2023 18:36:04 +0200 Message-ID: Subject: Re: [PATCH bpf-next v3 1/3] xsk: Support UMEM chunk_size > PAGE_SIZE To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Maciej Fijalkowski , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Magnus Karlsson , Jonathan Lemon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > In addition, presumably when using this mode, the other XDP actions > (XDP_PASS, XDP_REDIRECT to other targets) would stop working unless we > add special handling for that in the kernel? We'll definitely need to > handle that somehow... I am not familiar with all the details here. Do you know a reason why these cases would stop working / why special handling would be needed? For example, if I have a UMEM that uses hugepages and XDP_PASS is returned, then the data is just copied into an SKB right? SKBs can also be created directly from hugepages AFAIK. So I don't understand what the issue would be. Can someone explain this concern?