Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Apr 2023 09:55:53 -0700
In-Reply-To: <7332d846-fada-eb5c-6068-18ff267bd37f@linux.microsoft.com>
Mime-Version: 1.0
References: <20230413231251.1481410-1-seanjc@google.com> <7332d846-fada-eb5c-6068-18ff267bd37f@linux.microsoft.com>
Message-ID: <ZDmFmfPWmGxX855M@google.com>
Subject: Re: [PATCH] KVM: x86: Preserve TDP MMU roots until they are
 explicitly invalidated
From:   Sean Christopherson <seanjc@google.com>
To:     Jeremi Piotrowski <jpiotrowski@linux.microsoft.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, David Matlack <dmatlack@google.com>,
        Ben Gardon <bgardon@google.com>
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

On Fri, Apr 14, 2023, Jeremi Piotrowski wrote:
> On 4/14/2023 1:12 AM, Sean Christopherson wrote:
> > Preserve TDP MMU roots until they are explicitly invalidated by gifting
> > the TDP MMU itself a reference to a root when it is allocated.  Keeping a
> > reference in the TDP MMU fixes a flaw where the TDP MMU exhibits terrible
> > performance, and can potentially even soft-hang a vCPU, if a vCPU
> > frequently unloads its roots, e.g. when KVM is emulating SMI+RSM.

...

> Thank you, I just tested this and it works wonderfully! Is this still on time for 6.3?

This is too risky for 6.3, but I am comfortable applying it for 6.4.

> In case you need it:
> 
> Tested-by: Jeremi Piotrowski <jpiotrowski@linux.microsoft.com>
> 
> I'd also like to get this backported all the way back to 5.15 because the issue is
> already present there. I tried it myself, but this was before async zap and i'm
> doing something wrong with refcounts:

For 5.15, I think our best bet is to just disable the TDP MMU by default.  There
have been a _lot_ of relevant changes since 5.15, I am skeptical that this patch
can be backported to 5.15 without pulling in a big pile of changes from between
5.15 and 6.1 or so.

I added you to a related thread[*] about TDP MMU backports for 5.15, let's continue
the 5.15 discussion there.

Thanks!


[*] https://lore.kernel.org/all/ZDmEGM+CgYpvDLh6@google.com