Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4b5e45e9-6aa8-7338-acc4-db06ca1fe025@nvidia.com>
Date:   Fri, 14 Apr 2023 10:15:48 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.10.0
Subject: Re: [V6 0/9] Add Tegra234 HTE support
Content-Language: en-US
To:     Linus Walleij <linus.walleij@linaro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     thierry.reding@gmail.com, jonathanh@nvidia.com,
        linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-doc@vger.kernel.org, robh+dt@kernel.org,
        timestamp@lists.linux.dev, krzysztof.kozlowski+dt@linaro.org,
        brgl@bgdev.pl, corbet@lwn.net, gregkh@linuxfoundation.org,
        Konstantin Ryabitsev <konstantin@linuxfoundation.org>
References: <20230414004455.19275-1-dipenp@nvidia.com>
 <373eacb8-be3f-6b95-3e08-f0ff36f79891@linaro.org>
 <CACRpkdY6R9WvwOr3mVgrJcf9dVB4s13eu8juZkBt0Q+=gg2G2w@mail.gmail.com>
From:   Dipen Patel <dipenp@nvidia.com>
In-Reply-To: <CACRpkdY6R9WvwOr3mVgrJcf9dVB4s13eu8juZkBt0Q+=gg2G2w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWVCTGJ0ZXNWTlpRV3pBa0dBZHRROWExQlBXYS84ZSt1eDZYYy94elMvaHgz?=
 =?utf-8?B?NXZhRUlFT2F5T0NpVXo4amo5VVk2dlBwQVhvc0kxM09oYTd5QVdrK3FFSkth?=
 =?utf-8?B?aUd4SWxvdXJERml3amVGbVQ1ckhxTWtKbDlwczR3WlVoYUdrMFdzU1JYaVho?=
 =?utf-8?B?S2tKOTJTVytiY29yTkQrYUNZOHprbzJtOWpSK1BQWjljcXRzWGlSMUdHMllL?=
 =?utf-8?B?cnZiU1VIUXZPRlVsTHlGYWNiL2ZWU2lJb1VZcWFSbHI0dVdMU3ZRbERPUnl5?=
 =?utf-8?B?dEFyWXN4K1ovV1c1RmduZDVFeUZWTVIrc1dBSkwwcmZYaHh1VTRTWkM5UDcv?=
 =?utf-8?B?aHYwWWxVRTJlb0tmanFnNm8ybGY3ZUNQV2ZRTUhPSlhpYTRCeHRPNkU3cmdY?=
 =?utf-8?B?Q3cyVStYV1NkQTRVaHZnVE1rbnB3emdHM1IvL3h1eFVMSDIvenROUjdwY2xK?=
 =?utf-8?B?S2hMbnE2QkJGTU9VRkVEODlvVUFPbUY1YnVWY1JqMnVBak9aYVhjYVpLcEZJ?=
 =?utf-8?B?aTlhQThHSzR0RzZ5N1FaSnV3Z1pWcGlEaVJrdlJWVWF3a3g4MzZhOXJQbEpL?=
 =?utf-8?B?R0V4V0s3KzI1SU1XQ3hseW45d2psa0hKSy9XQzVSbTQrMHZYU1luK25HV1Qx?=
 =?utf-8?B?VVZxYWdoMzRCVFBCeDd1Wnpmb0w0TTNKc2tZNExaYVJRdlA0b01SVUoyajk0?=
 =?utf-8?B?NS9WRm0yeW9QZWZXeVhtSTdVYS9GOHV5MkgrRndOOTJ5KzVyU3ROc0x4OFBz?=
 =?utf-8?B?NHMrU1Avb0xOMTZPMkljMXk0S29pVXVPSEpiRVFaQTVTd2tIODJ3NlBhREVy?=
 =?utf-8?B?TUttZk1sT0JlTWFHNGlEZ0dRUHBpeEJzNGF4T2FUaDh0T0xtV3lLK2NLcmw2?=
 =?utf-8?B?WXh3TFQxS01DYkxRMGdTbXN4ak1XVmN1b0N5ZkYybVpUY09KbUVOcWptbVAx?=
 =?utf-8?B?NmRpNE1zZ3YvQk5idVZ0MXpQK3Bwc2RQSmFjWEsrRHpCV2twYUNnYkRnclpU?=
 =?utf-8?B?SzQ0V0hrak5ZZ1dPaWFKVUluNk8zOXlHeVI4RTRnZ2cxTlZ5NDQreklmYUx2?=
 =?utf-8?B?UkJtTDBuNG1VTkFMUnYrWDh2Wm9DOEMyUSthVHFTRFZRSDlRdXJ3QWozc3M0?=
 =?utf-8?B?Mzk0TkNXUFNYWHZKSmE3VXNpUmVQa29OZHVtVEJhQ3QyZ1RPeWtTbXhoZllx?=
 =?utf-8?B?QVNqLzZudU5BUkVodGlXYUU0SnRQeDN4U1RGMGRGRit2ekJDNHhzdmxPMnlD?=
 =?utf-8?B?bzZMeW1tdkxZMHM3Y2lMOTRFbkxBQmQ2TllzMkZTb0VJWnhRbVpFTzkvcFJm?=
 =?utf-8?B?SzcwRmJYOGFLYnpOT0p1TmlGQS8rYUtoV1NMMlBrWDU4eVNOSHRUaFFiQnRE?=
 =?utf-8?B?NzNNMVJWbG9yaXRmSVlQMFYweDVZakYrMWJ5V1pYR3F6QmhJT21oM2RCMnhH?=
 =?utf-8?B?dk5XTG4yZ0h1NTF6c0Ywd2VkWVN1MWQ0VHZ4aDdKaExDd21KYmxYMFZMcU5G?=
 =?utf-8?B?ZFZFVlFhS3MyM1JoR3RGZVVkd1hNaXBFbEJzemFFc0NnNFhkTlJ5TWVMWFhu?=
 =?utf-8?B?cUc0QlpZS25IRmdhZ0xkNit3ZEh6M2k5MnIvR1FpT1RxWkVEMGozS3pxS1pj?=
 =?utf-8?B?U2VFTGpCNkJPdm9jR3BJa3ZsS0JYZGVlL3JOVytLdy92bnc3eE9RTlZMZGFq?=
 =?utf-8?B?b2dDR1BRMkJVS2E2b3V5dFRVQ214enNZY0ZLblZBb2FMNjRNWjJZeUh2UUFm?=
 =?utf-8?B?VDE4S0VtblI0M3dGaTZtblFwS3hPWXV5VUhiSjd0b1VjNktLb1E3M2F4LzVt?=
 =?utf-8?B?TG9TVDdESmRjcm43TGs3MWdGR3Ntc1Nvd3ErMDdkNTBuVXY1bW9BczhzQzl0?=
 =?utf-8?B?T3M5N1h5eGtZVlgwK0dsdkxlclFTUDQ5Mk9HM2tFMkhleXhORytZSEtJQSts?=
 =?utf-8?B?Sk5WakhXMjNTcDdWWi9YUWE1bWd3M0NaQXVBaVcrNHdTM0doYVVmS1gvVmh2?=
 =?utf-8?B?VW5QSGZTbk1MZ3RIWDV1UHNwajNBeUcxSkRTd3lFd1o1YXpwcFA3R2lxdXdQ?=
 =?utf-8?B?S2N3RldhYTI0ZHlQSFhzSktWbVN5djZ2TlRzUHpxREdKejZvMThXQUdvUTA5?=
 =?utf-8?Q?3qY5Qf3fCEn7b/Uxgw22iHoc3?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 25bc863b-fbcd-49f3-4785-08db3d0be678
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6604.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 17:15:52.6351
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kH5Hl/YXivcL0ahpdLFQ1C1/zmJPsuKZWUcrJeLNNtoVRfOLQSxgerEMCsuKdeiSwfXf9QoFz6Oq0We4XrKUcA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4326
X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/14/23 1:07 AM, Linus Walleij wrote:
> On Fri, Apr 14, 2023 at 9:36 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>> On 14/04/2023 02:44, Dipen Patel wrote:
>>> This patch series mainly adds support for the Tegra234 HTE provider. In
>>> addition, it addresses dt binding comments which prompted code
>>> changes in the existing HTE provider driver without breaking the
>>> Tegra194 provider. The comments raised concern how existing code
>>> retrieves gpio controller node
>>> (the node is used to help namespace conversion between HTE and GPIOLIB).
>>> To help simplify that process, new DT property is suggested which adds
>>> gpio controller node in the HTE provider binding as phandle property. To
>>> conlude this patch series:
>>> - adds Tegra234 HTE provider
>>> - modifies existing provider code to address new dt binding for Tegra234
>>> without breaking it for the Tegra194 chip.
>>>
>>> The V1 patch series:
>>> - Adds tegra Tegra234 HTE(timestamp) provider supports.
>>> - Updates MAINTAINERS file for git tree, mail list fields.
>>> - Updates devicetree and API documentations.
>>> - Enables HTE subsystem, Tegra194 and Tegra234 HTE providers
>>> by default in arm64 defconfig and dts files.
>>
>> All your emails miss PATCH prefix. Use `git format-patch` to generate
>> proper versioned patch. Stripping important part messes up with our
>> filters. We have quite a lot of emails, so proper filtering is important.
> 
> At this point I would even recommend kernel maintainers to get b4
> into the workflow:
> https://people.kernel.org/monsieuricon/sending-a-kernel-patch-with-b4-part-1

Thanks for sharing...will have to look into it to avoid such mistakes.
> 
> This tool will also implement other desired behaviours and version
> the patch set for you.
> 
> I am gradually adopting it for my own work, using it all the time when
> applying patches but also getting better at using it for submitting
> them. It has a small overhead (like learning and memorizing the
> subcommands) but once you get used to it, it is really helpful.
> 
> Yours,
> Linus Walleij