Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ed27df52-969c-3d07-7c1d-2dc1566cc850@linuxfoundation.org>
Date:   Fri, 14 Apr 2023 11:16:15 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] selftests/resctrl: Fix incorrect error return on test
 complete
Content-Language: en-US
To:     Reinette Chatre <reinette.chatre@intel.com>, shuah@kernel.org
Cc:     ilpo.jarvinen@linux.intel.com, tan.shaopeng@jp.fujitsu.com,
        fenghua.yu@intel.com, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>
References: <37df0986015ecedec9a0244bdb0aa7c073bfe714.1681490161.git.reinette.chatre@intel.com>
From:   Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <37df0986015ecedec9a0244bdb0aa7c073bfe714.1681490161.git.reinette.chatre@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 4/14/23 10:43, Reinette Chatre wrote:
> An error snuck in between two recent conflicting changes:
> Until recently ->setup() used negative values to indicate
> normal test termination. This was changed in
> commit fa10366cc6f4 ("selftests/resctrl: Allow ->setup() to return
> errors") that transitioned ->setup() to use negative values
> to indicate errors and a new END_OF_TESTS to indicate normal
> termination.
> 
> commit 42e3b093eb7c ("selftests/resctrl: Fix set up schemata with 100%
> allocation on first run in MBM test") continued to use
> negative return to indicate normal test termination.
> 
> Fix mbm_setup() to use the new END_OF_TESTS to indicate
> error-free test termination.
> 
> Fixes: 42e3b093eb7c ("selftests/resctrl: Fix set up schemata with 100% allocation on first run in MBM test")
> Reported-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Link: https://lore.kernel.org/lkml/bb65cce8-54d7-68c5-ef19-3364ec95392a@linux.intel.com/
> Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
> ---
> Hi Shuah,
> 
> Apologies, this error snuck in between the two series
> merged into kselftest's next this week.
> 

No worries. This is now applied on top of others to linux-kselftest
net.

thanks,
-- Shuah