Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Apr 2023 13:24:01 -0500
From:   Nishanth Menon <nm@ti.com>
To:     Udit Kumar <u-kumar1@ti.com>
CC:     <linux-arm-kernel@lists.infradead.org>, <afd@ti.com>, <bb@ti.com>,
        <vaishnav.a@ti.com>, <j-choudhary@ti.com>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <vigneshr@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <a-govindraju@ti.com>,
        <kishon@ti.com>
Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-j7200-common-proc-board: Enable
 I2C
Message-ID: <20230414182401.2yfpwjug3naiwesi@quicksand>
References: <20230414181434.2046049-1-u-kumar1@ti.com>
 <20230414181434.2046049-3-u-kumar1@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230414181434.2046049-3-u-kumar1@ti.com>
Precedence: bulk

On 23:44-20230414, Udit Kumar wrote:
> All I2C nodes were disabled in SOC dts file and in board
> dts needed nodes were enabled.
redundant.

> This patch enables wkup_i2c0 node in board dts file.
> 
> Fixes: a9ed915cd55c ("arm64: dts: ti: k3-j7200: Enable I2C nodes at the board level")


This should'nt be fixing the commit - the commit is correct in the sense
that if the board does'nt describe a node with pinmux, the i2c is'nt
functional in the first place.

> 
> Signed-off-by: Udit Kumar <u-kumar1@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> index 63633e4f6c59..e66bbfe65ff2 100644
> --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> @@ -254,6 +254,10 @@ exp3: gpio@20 {
>  	};
>  };
>  
> +&wkup_i2c0 {
> +	status = "okay";

How about the pinmux? speed? what peripheral is on the wakeup i2c?

	Do we have an eeprom or something here?

> +};
> +
>  &main_sdhci0 {
>  	/* eMMC */
>  	non-removable;
> -- 
> 2.34.1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D