Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Apr 2023 19:43:01 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Suren Baghdasaryan <surenb@google.com>
Cc:     akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@suse.com,
        josef@toxicpanda.com, jack@suse.cz, ldufour@linux.ibm.com,
        laurent.dufour@fr.ibm.com, michel@lespinasse.org,
        liam.howlett@oracle.com, jglisse@google.com, vbabka@suse.cz,
        minchan@google.com, dave@stgolabs.net, punit.agrawal@bytedance.com,
        lstoakes@gmail.com, linux-mm@kvack.org,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-team@android.com
Subject: Re: [PATCH 1/1] mm: handle swap page faults if the faulting page can
 be locked
Message-ID: <ZDmetaUdmlEz/W8Q@casper.infradead.org>
References: <20230414180043.1839745-1-surenb@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230414180043.1839745-1-surenb@google.com>
Precedence: bulk

On Fri, Apr 14, 2023 at 11:00:43AM -0700, Suren Baghdasaryan wrote:
> When page fault is handled under VMA lock protection, all swap page
> faults are retried with mmap_lock because folio_lock_or_retry
> implementation has to drop and reacquire mmap_lock if folio could
> not be immediately locked.
> Instead of retrying all swapped page faults, retry only when folio
> locking fails.

Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>

Let's just review what can now be handled under the VMA lock instead of
the mmap_lock, in case somebody knows better than me that it's not safe.

 - We can call migration_entry_wait().  This will wait for PG_locked to
   become clear (in migration_entry_wait_on_locked()).  As previously
   discussed offline, I think this is safe to do while holding the VMA
   locked.
 - We can call remove_device_exclusive_entry().  That calls
   folio_lock_or_retry(), which will fail if it can't get the VMA lock.
 - We can call pgmap->ops->migrate_to_ram().  Perhaps somebody familiar
   with Nouveau and amdkfd could comment on how safe this is?
 - I believe we can't call handle_pte_marker() because we exclude UFFD
   VMAs earlier.
 - We can call swap_readpage() if we allocate a new folio.  I haven't
   traced through all this code to tell if it's OK.

So ... I believe this is all OK, but we're definitely now willing to
wait for I/O from the swap device while holding the VMA lock when we
weren't before.  And maybe we should make a bigger deal of it in the
changelog.

And maybe we shouldn't just be failing the folio_lock_or_retry(),
maybe we should be waiting for the folio lock with the VMA locked.